Commit 96d2928
committed
fix: use live metadata path, skip Review panel data loading during creation
Two fixes for workspace rename not updating UI:
1. App.tsx: Use currentMetadata?.namedWorkspacePath instead of the stale
selectedWorkspace.namedWorkspacePath. The live metadata updates when
the workspace is renamed, while selectedWorkspace is set once at creation.
2. ReviewPanel.tsx: Add isCreating checks to useEffects that load data.
Previously the early return only affected the render output, but the
data loading useEffects still ran and tried to call executeBash on a
workspace that wasn't in config yet.1 parent 97996b2 commit 96d2928
File tree
2 files changed
+10
-3
lines changed- src/browser
- components/RightSidebar/CodeReview
2 files changed
+10
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
576 | 576 | | |
577 | 577 | | |
578 | 578 | | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
579 | 582 | | |
580 | 583 | | |
581 | 584 | | |
| |||
586 | 589 | | |
587 | 590 | | |
588 | 591 | | |
589 | | - | |
| 592 | + | |
590 | 593 | | |
591 | 594 | | |
592 | 595 | | |
| |||
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | | - | |
| 197 | + | |
| 198 | + | |
198 | 199 | | |
199 | 200 | | |
200 | 201 | | |
| |||
242 | 243 | | |
243 | 244 | | |
244 | 245 | | |
| 246 | + | |
245 | 247 | | |
246 | 248 | | |
247 | 249 | | |
248 | 250 | | |
249 | | - | |
| 251 | + | |
| 252 | + | |
250 | 253 | | |
251 | 254 | | |
252 | 255 | | |
| |||
336 | 339 | | |
337 | 340 | | |
338 | 341 | | |
| 342 | + | |
339 | 343 | | |
340 | 344 | | |
341 | 345 | | |
| |||
0 commit comments