Commit b5c693a
authored
🤖 fix: use Radix HoverCard for git status tooltip viewport handling (#1162)
## Problem
The git status "Divergence" popup (showing line changes & commits) would
exceed the window bounds when triggered from the topmost workspace in
the sidebar. The popup used `translateY(-50%)` for centering but had no
boundary clamping, causing half the content to render above the visible
viewport.
## Solution
Replace the manual `createPortal` + coordinate positioning with Radix
`HoverCard` primitive, which handles viewport collision detection
automatically via Floating UI under the hood.
### Why Radix HoverCard?
1. **Built-in viewport collision handling** — `collisionPadding={8}`
ensures the popup stays within bounds
2. **Native hover behavior** — handles open/close delays,
cursor-to-content transitions without manual timeout logic
3. **Consistent with existing patterns** — the codebase already uses
Radix primitives (Popover, Tooltip, etc.)
4. **Less code to maintain** — removes ~90 lines of manual positioning,
timeout refs, and coordinate calculations
### Changes
- Add `hover-card.tsx` shadcn component wrapping
`@radix-ui/react-hover-card`
- Refactor `GitStatusIndicatorView` to use `<HoverCard>` instead of
`createPortal`
- Simplify `GitStatusIndicator` by removing manual hover state
management
- Use `openDelay={0}` (instant open) and `closeDelay={150}` (snappy
close)
### Net impact
- **-47 lines** in production code (117 added, 164 removed)
- Viewport overflow bug fixed
- Hover timing slightly snappier (150ms vs 300ms close delay)
---
_Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking:
`high`_1 parent d180c80 commit b5c693a
File tree
6 files changed
+119
-165
lines changed- src/browser
- components
- ui
- stories
6 files changed
+119
-165
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| 26 | + | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| |||
872 | 874 | | |
873 | 875 | | |
874 | 876 | | |
| 877 | + | |
| 878 | + | |
875 | 879 | | |
876 | 880 | | |
877 | 881 | | |
| |||
3766 | 3770 | | |
3767 | 3771 | | |
3768 | 3772 | | |
| 3773 | + | |
| 3774 | + | |
3769 | 3775 | | |
3770 | 3776 | | |
3771 | 3777 | | |
| |||
4240 | 4246 | | |
4241 | 4247 | | |
4242 | 4248 | | |
| 4249 | + | |
| 4250 | + | |
4243 | 4251 | | |
4244 | 4252 | | |
4245 | 4253 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
| 27 | + | |
34 | 28 | | |
35 | 29 | | |
36 | 30 | | |
| |||
51 | 45 | | |
52 | 46 | | |
53 | 47 | | |
54 | | - | |
| 48 | + | |
55 | 49 | | |
56 | 50 | | |
57 | 51 | | |
58 | | - | |
| 52 | + | |
59 | 53 | | |
60 | 54 | | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | 55 | | |
124 | 56 | | |
125 | 57 | | |
| |||
130 | 62 | | |
131 | 63 | | |
132 | 64 | | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
| 65 | + | |
| 66 | + | |
138 | 67 | | |
139 | | - | |
140 | | - | |
141 | 68 | | |
142 | 69 | | |
143 | 70 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
| 53 | + | |
| 54 | + | |
59 | 55 | | |
60 | | - | |
61 | 56 | | |
62 | 57 | | |
63 | 58 | | |
| |||
76 | 71 | | |
77 | 72 | | |
78 | 73 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
| 74 | + | |
| 75 | + | |
85 | 76 | | |
86 | | - | |
87 | 77 | | |
88 | 78 | | |
89 | 79 | | |
| |||
229 | 219 | | |
230 | 220 | | |
231 | 221 | | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
247 | 225 | | |
248 | 226 | | |
249 | 227 | | |
| |||
296 | 274 | | |
297 | 275 | | |
298 | 276 | | |
299 | | - | |
| 277 | + | |
300 | 278 | | |
301 | 279 | | |
302 | | - | |
| 280 | + | |
303 | 281 | | |
304 | | - | |
305 | | - | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
310 | | - | |
311 | | - | |
312 | | - | |
313 | | - | |
314 | | - | |
315 | | - | |
316 | | - | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
322 | 315 | | |
323 | 316 | | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | | - | |
345 | | - | |
346 | | - | |
347 | | - | |
348 | | - | |
349 | | - | |
350 | | - | |
351 | | - | |
352 | | - | |
353 | | - | |
354 | | - | |
355 | | - | |
356 | | - | |
357 | | - | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
358 | 324 | | |
359 | 325 | | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
360 | 350 | | |
0 commit comments