Skip to content

Commit b74e83c

Browse files
committed
🤖 perf: skip code signing in PR/merge_group builds for parallel macOS builds
The macOS build was taking 24+ minutes because code signing was enabled for merge_group events (condition was 'event_name != pull_request'). This forced sequential x64+arm64 builds to avoid keychain race conditions. Changed the condition to only enable signing for workflow_dispatch (manual testing). PRs and merge_group now build both architectures in parallel. - Before: 24m40s (sequential with signing) - After: ~4m (parallel, no signing) Releases still get proper signing via release.yml (triggered by tag publish). Generated with mux
1 parent 35ad55b commit b74e83c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

‎.github/workflows/build.yml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ jobs:
1818

1919
- uses: ./.github/actions/setup-mux
2020

21-
# Skip signing setup for PRs - electron-builder skips signing anyway,
22-
# but setting CSC_LINK forces our Makefile to build sequentially.
23-
# Without CSC_LINK, x64 and arm64 build in parallel (~90s savings).
21+
# Only sign for workflow_dispatch (manual testing of signing process).
22+
# PRs and merge_group skip signing - releases use release.yml instead.
23+
# Without CSC_LINK, x64 and arm64 builds run in parallel (~12 min faster).
2424
- name: Setup code signing
25-
if: github.event_name != 'pull_request'
25+
if: github.event_name == 'workflow_dispatch'
2626
run: ./scripts/setup-macos-signing.sh
2727
env:
2828
MACOS_CERTIFICATE: ${{ secrets.MACOS_CERTIFICATE }}
@@ -32,7 +32,7 @@ jobs:
3232
AC_APIKEY_ISSUER_ID: ${{ secrets.AC_APIKEY_ISSUER_ID }}
3333

3434
- name: Verify signing setup
35-
if: github.event_name != 'pull_request'
35+
if: github.event_name == 'workflow_dispatch'
3636
run: |
3737
if [ -n "${CSC_LINK:-}" ]; then
3838
echo "✅ Code signing enabled"

0 commit comments

Comments
 (0)