Skip to content

Commit c003916

Browse files
committed
fix: resolve flaky integration tests in resumeStream, queuedMessages, and ollama suites
1 parent 0a4415b commit c003916

File tree

3 files changed

+15
-8
lines changed

3 files changed

+15
-8
lines changed

tests/ipcMain/ollama.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ describeOllama("IpcMain Ollama integration tests", () => {
9595

9696
// Ensure Ollama model is available (idempotent - fast if cached)
9797
await ensureOllamaModel(OLLAMA_MODEL);
98-
}, 150000); // 150s timeout for tokenizer loading + potential model pull
98+
}); // 150s timeout handling managed internally or via global config
9999

100100
test("should successfully send message to Ollama and receive response", async () => {
101101
// Setup test environment
@@ -114,9 +114,9 @@ describeOllama("IpcMain Ollama integration tests", () => {
114114

115115
// Collect and verify stream events
116116
const collector = createEventCollector(env.sentEvents, workspaceId);
117-
const streamEnd = await collector.waitForEvent("stream-end", 30000);
117+
const streamEnd = await collector.waitForEvent("stream-end", 60000);
118118

119-
expect(streamEnd).toBeDefined();
119+
expect(streamEnd).not.toBeNull();
120120
assertStreamSuccess(collector);
121121

122122
// Verify we received deltas

tests/ipcMain/queuedMessages.test.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,13 @@ describeIntegration("IpcMain queuedMessages integration tests", () => {
209209
await sendMessage(env.mockIpcRenderer, workspaceId, "Message 3");
210210

211211
// Verify all messages queued
212+
// Wait until we have 3 messages in the queue state
213+
const success = await waitFor(async () => {
214+
const msgs = await getQueuedMessages(collector1, 500);
215+
return msgs.length === 3;
216+
}, 5000);
217+
expect(success).toBe(true);
218+
212219
const queued = await getQueuedMessages(collector1);
213220
expect(queued).toEqual(["Message 1", "Message 2", "Message 3"]);
214221

tests/ipcMain/resumeStream.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ describeIntegration("IpcMain resumeStream integration tests", () => {
3737
// Wait for stream to start
3838
const collector1 = createEventCollector(env.sentEvents, workspaceId);
3939
const streamStartEvent = await collector1.waitForEvent("stream-start", 5000);
40-
expect(streamStartEvent).toBeDefined();
40+
expect(streamStartEvent).not.toBeNull();
4141

4242
// Wait for at least some content or tool call to start
4343
await waitFor(() => {
@@ -92,11 +92,11 @@ describeIntegration("IpcMain resumeStream integration tests", () => {
9292

9393
// Wait for new stream to start
9494
const resumeStreamStart = await collector2.waitForEvent("stream-start", 5000);
95-
expect(resumeStreamStart).toBeDefined();
95+
expect(resumeStreamStart).not.toBeNull();
9696

9797
// Wait for stream to complete
9898
const streamEnd = await collector2.waitForEvent("stream-end", 30000);
99-
expect(streamEnd).toBeDefined();
99+
expect(streamEnd).not.toBeNull();
100100

101101
// Verify no new user message was created
102102
collector2.collect();
@@ -179,11 +179,11 @@ describeIntegration("IpcMain resumeStream integration tests", () => {
179179

180180
// Wait for stream to start
181181
const streamStart = await collector.waitForEvent("stream-start", 10000);
182-
expect(streamStart).toBeDefined();
182+
expect(streamStart).not.toBeNull();
183183

184184
// Wait for stream to complete
185185
const streamEnd = await collector.waitForEvent("stream-end", 30000);
186-
expect(streamEnd).toBeDefined();
186+
expect(streamEnd).not.toBeNull();
187187

188188
// Verify no user message was created (resumeStream should not add one)
189189
collector.collect();

0 commit comments

Comments
 (0)