Skip to content

Commit c78a48d

Browse files
committed
🤖 perf: skip code signing in merge queue to enable parallel builds
The macOS build workflow was taking 24+ minutes because code signing was enabled for merge_group events. This forced sequential x64+arm64 builds to avoid keychain race conditions. Since merge queue builds don't need signed artifacts (only releases do), we can safely skip signing and let both architectures build in parallel. This should cut the macOS build time roughly in half (~12 min). Generated with mux
1 parent 35ad55b commit c78a48d

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

.github/workflows/build.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@ jobs:
1818

1919
- uses: ./.github/actions/setup-mux
2020

21-
# Skip signing setup for PRs - electron-builder skips signing anyway,
22-
# but setting CSC_LINK forces our Makefile to build sequentially.
23-
# Without CSC_LINK, x64 and arm64 build in parallel (~90s savings).
21+
# Skip signing setup for PRs and merge queue - only release builds need signing.
22+
# Setting CSC_LINK forces our Makefile to build sequentially (to avoid keychain
23+
# race conditions), which doubles build time. Without it, x64 and arm64 build
24+
# in parallel (~12 min savings).
2425
- name: Setup code signing
25-
if: github.event_name != 'pull_request'
26+
if: github.event_name == 'workflow_dispatch'
2627
run: ./scripts/setup-macos-signing.sh
2728
env:
2829
MACOS_CERTIFICATE: ${{ secrets.MACOS_CERTIFICATE }}
@@ -32,7 +33,7 @@ jobs:
3233
AC_APIKEY_ISSUER_ID: ${{ secrets.AC_APIKEY_ISSUER_ID }}
3334

3435
- name: Verify signing setup
35-
if: github.event_name != 'pull_request'
36+
if: github.event_name == 'workflow_dispatch'
3637
run: |
3738
if [ -n "${CSC_LINK:-}" ]; then
3839
echo "✅ Code signing enabled"

0 commit comments

Comments
 (0)