🤖 refactor: DRY task orchestration + thinking policy

Consolidate shared thinking policy and reduce tool/task scaffolding.

Signed-off-by: Thomas Kosiewski <tk@coder.com>

---
_Generated with `mux` • Model: gpt-5.2 • Thinking: unknown_
<!-- mux-attribution: model=gpt-5.2 thinking=unknown -->

Change-Id: Id77858efe746d9b7551ab266f98886dc7712a5f3

Author: ThomasK33

src/browser/App.tsx

@@ -40,7 +40,7 @@ import {
   getModelKey,
 } from "@/common/constants/storage";
 import { migrateGatewayModel } from "@/browser/hooks/useGatewayModels";
-import { enforceThinkingPolicy } from "@/browser/utils/thinking/policy";
+import { enforceThinkingPolicy } from "@/common/utils/thinking/policy";
 import { getDefaultModel } from "@/browser/hooks/useModelsFromSettings";
 import type { BranchListResult } from "@/common/orpc/types";
 import { useTelemetry } from "./hooks/useTelemetry";

src/browser/components/ChatInput/index.tsx

@@ -22,7 +22,7 @@ import { ModelSettings } from "../ModelSettings";
 import { useAPI } from "@/browser/contexts/API";
 import { useThinkingLevel } from "@/browser/hooks/useThinkingLevel";
 import { migrateGatewayModel } from "@/browser/hooks/useGatewayModels";
-import { enforceThinkingPolicy } from "@/browser/utils/thinking/policy";
+import { enforceThinkingPolicy } from "@/common/utils/thinking/policy";
 import { useSendMessageOptions } from "@/browser/hooks/useSendMessageOptions";
 import {
   getModelKey,

src/browser/components/Settings/sections/TasksSection.tsx

@@ -7,6 +7,7 @@ import {
   normalizeTaskSettings,
   type TaskSettings,
   type SubagentAiDefaults,
+  type SubagentAiDefaultsEntry,
 } from "@/common/types/tasks";
 import { BUILT_IN_SUBAGENTS } from "@/common/constants/agents";
 import type { ThinkingLevel } from "@/common/types/thinking";
@@ -19,7 +20,33 @@ import {
   SelectTrigger,
   SelectValue,
 } from "@/browser/components/ui/select";
-import { enforceThinkingPolicy, getThinkingPolicyForModel } from "@/browser/utils/thinking/policy";
+import { enforceThinkingPolicy, getThinkingPolicyForModel } from "@/common/utils/thinking/policy";
+
+const INHERIT = "__inherit__";
+const ALL_THINKING_LEVELS = ["off", "low", "medium", "high", "xhigh"] as const;
+
+function updateSubagentDefaultEntry(
+  previous: SubagentAiDefaults,
+  agentType: string,
+  update: (entry: SubagentAiDefaultsEntry) => void
+): SubagentAiDefaults {
+  const next = { ...previous };
+  const existing = next[agentType] ?? {};
+  const updated: SubagentAiDefaultsEntry = { ...existing };
+  update(updated);
+
+  if (updated.modelString && updated.thinkingLevel) {
+    updated.thinkingLevel = enforceThinkingPolicy(updated.modelString, updated.thinkingLevel);
+  }
+
+  if (!updated.modelString && !updated.thinkingLevel) {
+    delete next[agentType];
+  } else {
+    next[agentType] = updated;
+  }
+
+  return next;
+}
 
 export function TasksSection() {
   const { api } = useAPI();
@@ -30,6 +57,10 @@ export function TasksSection() {
   const [saveError, setSaveError] = useState<string | null>(null);
   const saveTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null);
   const savingRef = useRef(false);
+  const pendingSaveRef = useRef<{
+    taskSettings: TaskSettings;
+    subagentAiDefaults: SubagentAiDefaults;
+  } | null>(null);
 
   const { models, hiddenModels } = useModelsFromSettings();
 
@@ -74,23 +105,36 @@ export function TasksSection() {
     if (!api) return;
     if (!loaded) return;
     if (loadFailed) return;
-    if (savingRef.current) return;
+
+    pendingSaveRef.current = { taskSettings, subagentAiDefaults };
 
     if (saveTimerRef.current) {
       clearTimeout(saveTimerRef.current);
       saveTimerRef.current = null;
     }
 
     saveTimerRef.current = setTimeout(() => {
-      savingRef.current = true;
-      void api.config
-        .saveConfig({ taskSettings, subagentAiDefaults })
-        .catch((error: unknown) => {
-          setSaveError(error instanceof Error ? error.message : String(error));
-        })
-        .finally(() => {
-          savingRef.current = false;
-        });
+      const flush = () => {
+        if (savingRef.current) return;
+        if (!api) return;
+
+        const payload = pendingSaveRef.current;
+        if (!payload) return;
+
+        pendingSaveRef.current = null;
+        savingRef.current = true;
+        void api.config
+          .saveConfig(payload)
+          .catch((error: unknown) => {
+            setSaveError(error instanceof Error ? error.message : String(error));
+          })
+          .finally(() => {
+            savingRef.current = false;
+            flush();
+          });
+      };
+
+      flush();
     }, 400);
 
     return () => {
@@ -111,57 +155,29 @@ export function TasksSection() {
     setTaskSettings((prev) => normalizeTaskSettings({ ...prev, maxTaskNestingDepth: parsed }));
   };
 
-  const INHERIT = "__inherit__";
-
   const setSubagentModel = (agentType: string, value: string) => {
-    setSubagentAiDefaults((prev) => {
-      const next = { ...prev };
-      const existing = next[agentType] ?? {};
-      const updated = { ...existing };
-
-      if (value === INHERIT) {
-        delete updated.modelString;
-      } else {
-        updated.modelString = value;
-      }
-
-      if (updated.modelString && updated.thinkingLevel) {
-        updated.thinkingLevel = enforceThinkingPolicy(updated.modelString, updated.thinkingLevel);
-      }
-
-      if (!updated.modelString && !updated.thinkingLevel) {
-        delete next[agentType];
-      } else {
-        next[agentType] = updated;
-      }
-
-      return next;
-    });
+    setSubagentAiDefaults((prev) =>
+      updateSubagentDefaultEntry(prev, agentType, (updated) => {
+        if (value === INHERIT) {
+          delete updated.modelString;
+        } else {
+          updated.modelString = value;
+        }
+      })
+    );
   };
 
   const setSubagentThinking = (agentType: string, value: string) => {
-    setSubagentAiDefaults((prev) => {
-      const next = { ...prev };
-      const existing = next[agentType] ?? {};
-      const updated = { ...existing };
-
-      if (value === INHERIT) {
-        delete updated.thinkingLevel;
-      } else {
-        const requested = value as ThinkingLevel;
-        updated.thinkingLevel = updated.modelString
-          ? enforceThinkingPolicy(updated.modelString, requested)
-          : requested;
-      }
+    setSubagentAiDefaults((prev) =>
+      updateSubagentDefaultEntry(prev, agentType, (updated) => {
+        if (value === INHERIT) {
+          delete updated.thinkingLevel;
+          return;
+        }
 
-      if (!updated.modelString && !updated.thinkingLevel) {
-        delete next[agentType];
-      } else {
-        next[agentType] = updated;
-      }
-
-      return next;
-    });
+        updated.thinkingLevel = value as ThinkingLevel;
+      })
+    );
   };
 
   return (
@@ -224,9 +240,7 @@ export function TasksSection() {
             const modelValue = entry?.modelString ?? INHERIT;
             const thinkingValue = entry?.thinkingLevel ?? INHERIT;
             const allowedThinkingLevels =
-              modelValue !== INHERIT
-                ? getThinkingPolicyForModel(modelValue)
-                : (["off", "low", "medium", "high", "xhigh"] as const);
+              modelValue !== INHERIT ? getThinkingPolicyForModel(modelValue) : ALL_THINKING_LEVELS;
 
             return (
               <div

src/browser/components/ThinkingSlider.tsx

@@ -3,7 +3,7 @@ import type { ThinkingLevel } from "@/common/types/thinking";
 import { useThinkingLevel } from "@/browser/hooks/useThinkingLevel";
 import { Tooltip, TooltipTrigger, TooltipContent } from "./ui/tooltip";
 import { formatKeybind, KEYBINDS } from "@/browser/utils/ui/keybinds";
-import { getThinkingPolicyForModel } from "@/browser/utils/thinking/policy";
+import { getThinkingPolicyForModel } from "@/common/utils/thinking/policy";
 
 // Uses CSS variable --color-thinking-mode for theme compatibility
 // Glow is applied via CSS using color-mix with the theme color

src/browser/contexts/ThinkingContext.tsx

@@ -15,7 +15,7 @@ import {
 } from "@/common/constants/storage";
 import { getDefaultModel } from "@/browser/hooks/useModelsFromSettings";
 import { migrateGatewayModel } from "@/browser/hooks/useGatewayModels";
-import { enforceThinkingPolicy } from "@/browser/utils/thinking/policy";
+import { enforceThinkingPolicy } from "@/common/utils/thinking/policy";
 import { useAPI } from "@/browser/contexts/API";
 
 interface ThinkingContextType {

src/browser/hooks/useAIViewKeybinds.ts

@@ -4,7 +4,7 @@ import { matchesKeybind, KEYBINDS, isEditableElement } from "@/browser/utils/ui/
 import { getModelKey } from "@/common/constants/storage";
 import { readPersistedState } from "@/browser/hooks/usePersistedState";
 import type { ThinkingLevel } from "@/common/types/thinking";
-import { getThinkingPolicyForModel } from "@/browser/utils/thinking/policy";
+import { getThinkingPolicyForModel } from "@/common/utils/thinking/policy";
 import { getDefaultModel } from "@/browser/hooks/useModelsFromSettings";
 import type { StreamingMessageAggregator } from "@/browser/utils/messages/StreamingMessageAggregator";
 import { isCompactingStream, cancelCompaction } from "@/browser/utils/compaction/handler";

src/browser/hooks/useSendMessageOptions.ts

@@ -10,7 +10,7 @@ import type { UIMode } from "@/common/types/mode";
 import type { ThinkingLevel } from "@/common/types/thinking";
 import type { MuxProviderOptions } from "@/common/types/providerOptions";
 import { getSendOptionsFromStorage } from "@/browser/utils/messages/sendOptions";
-import { enforceThinkingPolicy } from "@/browser/utils/thinking/policy";
+import { enforceThinkingPolicy } from "@/common/utils/thinking/policy";
 import { useProviderOptions } from "./useProviderOptions";
 import type { GatewayState } from "./useGatewayModels";
 import { useExperimentOverrideValue } from "./useExperiments";

src/browser/utils/messages/sendOptions.ts

@@ -11,7 +11,7 @@ import { toGatewayModel, migrateGatewayModel } from "@/browser/hooks/useGatewayM
 import type { SendMessageOptions } from "@/common/orpc/types";
 import type { UIMode } from "@/common/types/mode";
 import type { ThinkingLevel } from "@/common/types/thinking";
-import { enforceThinkingPolicy } from "@/browser/utils/thinking/policy";
+import { enforceThinkingPolicy } from "@/common/utils/thinking/policy";
 import type { MuxProviderOptions } from "@/common/types/providerOptions";
 import { WORKSPACE_DEFAULTS } from "@/constants/workspaceDefaults";
 import { isExperimentEnabled } from "@/browser/hooks/useExperiments";

src/common/types/tasks.ts

@@ -1,5 +1,5 @@
 import assert from "@/common/utils/assert";
-import type { ThinkingLevel } from "./thinking";
+import { coerceThinkingLevel, type ThinkingLevel } from "./thinking";
 
 export interface TaskSettings {
   maxParallelAgentTasks: number;
@@ -40,19 +40,7 @@ export function normalizeSubagentAiDefaults(raw: unknown): SubagentAiDefaults {
         ? entry.modelString.trim()
         : undefined;
 
-    const thinkingLevel = (() => {
-      const value = entry.thinkingLevel;
-      if (
-        value === "off" ||
-        value === "low" ||
-        value === "medium" ||
-        value === "high" ||
-        value === "xhigh"
-      ) {
-        return value;
-      }
-      return undefined;
-    })();
+    const thinkingLevel = coerceThinkingLevel(entry.thinkingLevel);
 
     if (!modelString && !thinkingLevel) {
       continue;

src/common/types/thinking.ts

@@ -13,6 +13,20 @@ export type ThinkingLevel = "off" | "low" | "medium" | "high" | "xhigh";
  */
 export type ThinkingLevelOn = Exclude<ThinkingLevel, "off">;
 
+export function isThinkingLevel(value: unknown): value is ThinkingLevel {
+  return (
+    value === "off" ||
+    value === "low" ||
+    value === "medium" ||
+    value === "high" ||
+    value === "xhigh"
+  );
+}
+
+export function coerceThinkingLevel(value: unknown): ThinkingLevel | undefined {
+  return isThinkingLevel(value) ? value : undefined;
+}
+
 /**
  * Anthropic thinking token budget mapping
  *