feat: dynamic integration test filtering based on changed paths

Instead of skipping the entire integration job, compute which test
directories to run based on paths-filter outputs:

- ipc filter: src/node/services, orpc, config, git, utils, common, cli, desktop, tests/ipc
- runtime filter: src/node/runtime, tests/runtime
- config changes: run all integration tests
- manual override: workflow_dispatch test_filter still works

The job always runs (unless docs-only), but tests are scoped to relevant changes.

Author: ammar-agent

.github/workflows/pr.yml

@@ -16,14 +16,15 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  # Detect what files changed to skip jobs for docs-only or browser-only PRs
+  # Detect what files changed to determine which jobs/tests to run
   changes:
     name: Detect Changes
     runs-on: ubuntu-latest
     outputs:
       docs-only: ${{ steps.filter.outputs.docs == 'true' && steps.filter.outputs.src == 'false' && steps.filter.outputs.config == 'false' }}
-      # Browser-only: only browser/renderer code changed, no backend/node changes
-      browser-only: ${{ steps.filter.outputs.browser == 'true' && steps.filter.outputs.backend == 'false' && steps.filter.outputs.config == 'false' }}
+      config: ${{ steps.filter.outputs.config }}
+      ipc: ${{ steps.filter.outputs.ipc }}
+      runtime: ${{ steps.filter.outputs.runtime }}
     steps:
       - uses: actions/checkout@v4
       - uses: dorny/paths-filter@v3
@@ -39,19 +40,20 @@ jobs:
               - 'src/**'
               - 'tests/**'
               - 'vscode/**'
-            browser:
-              - 'src/browser/**'
-              - 'src/styles/**'
-              - 'src/components/**'
-              - 'src/hooks/**'
-              - '**/*.stories.tsx'
-              - '.storybook/**'
-            backend:
-              - 'src/node/**'
+            # IPC tests: backend services, ORPC, config, common types
+            ipc:
+              - 'src/node/services/**'
+              - 'src/node/orpc/**'
+              - 'src/node/config/**'
+              - 'src/node/git/**'
+              - 'src/node/utils/**'
+              - 'src/common/**'
               - 'src/cli/**'
               - 'src/desktop/**'
-              - 'src/common/**'
               - 'tests/ipc/**'
+            # Runtime tests: runtime implementations (SSH, worktree)
+            runtime:
+              - 'src/node/runtime/**'
               - 'tests/runtime/**'
             config:
               - '.github/**'
@@ -113,8 +115,7 @@ jobs:
   test-integration:
     name: Test / Integration
     needs: [changes]
-    # Skip for docs-only or browser-only (integration tests are backend IPC tests)
-    if: ${{ needs.changes.outputs.docs-only != 'true' && needs.changes.outputs.browser-only != 'true' }}
+    if: ${{ needs.changes.outputs.docs-only != 'true' }}
     timeout-minutes: 10
     runs-on: ${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-16' || 'ubuntu-latest' }}
     steps:
@@ -123,11 +124,49 @@ jobs:
           fetch-depth: 0
       - uses: ./.github/actions/setup-mux
       - run: make build-main
-      - run: TEST_INTEGRATION=1 bun x jest --coverage --maxWorkers=100% --silent ${{ github.event.inputs.test_filter || 'tests/ipc tests/runtime' }}
+      - name: Compute test filter
+        id: test-filter
+        run: |
+          # Manual override takes precedence
+          if [[ -n "${{ github.event.inputs.test_filter }}" ]]; then
+            echo "filter=${{ github.event.inputs.test_filter }}" >> $GITHUB_OUTPUT
+            exit 0
+          fi
+          
+          # Config changes = run everything
+          if [[ "${{ needs.changes.outputs.config }}" == "true" ]]; then
+            echo "filter=tests/ipc tests/runtime" >> $GITHUB_OUTPUT
+            exit 0
+          fi
+          
+          # Build filter from changed paths
+          paths=""
+          if [[ "${{ needs.changes.outputs.ipc }}" == "true" ]]; then
+            paths="$paths tests/ipc"
+          fi
+          if [[ "${{ needs.changes.outputs.runtime }}" == "true" ]]; then
+            paths="$paths tests/runtime"
+          fi
+          paths=$(echo $paths | xargs)  # trim whitespace
+          
+          if [[ -z "$paths" ]]; then
+            echo "No integration tests needed for changed paths"
+            echo "filter=" >> $GITHUB_OUTPUT
+          else
+            echo "Running: $paths"
+            echo "filter=$paths" >> $GITHUB_OUTPUT
+          fi
+      - name: Run integration tests
+        if: ${{ steps.test-filter.outputs.filter != '' }}
+        run: TEST_INTEGRATION=1 bun x jest --coverage --maxWorkers=100% --silent ${{ steps.test-filter.outputs.filter }}
         env:
           OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
           ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
+      - name: Skip integration tests
+        if: ${{ steps.test-filter.outputs.filter == '' }}
+        run: echo "Skipping integration tests - no relevant paths changed"
       - uses: codecov/codecov-action@v5
+        if: ${{ steps.test-filter.outputs.filter != '' }}
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           files: ./coverage/lcov.info

src/common/constants/knownModels.test.ts

@@ -39,9 +39,7 @@ describe("Known Models Integration", () => {
       const modelId = model.providerModelId;
       // xAI models are prefixed with "xai/" in models.json
       const lookupKey = model.provider === "xai" ? `xai/${modelId}` : modelId;
-      const modelData =
-        (modelsJson[lookupKey as keyof typeof modelsJson] as Record<string, unknown>) ??
-        (modelsExtra[modelId] as Record<string, unknown>);
+      const modelData = modelsJson[lookupKey as keyof typeof modelsJson] ?? modelsExtra[modelId];
 
       expect(modelData).toBeDefined();
       // Check that basic metadata fields exist (not all models have all fields)