Skip to content

Commit fddf0f2

Browse files
committed
🤖 perf: skip code signing in build.yml to enable parallel builds
The macOS build workflow was taking 24+ minutes because code signing was enabled for merge_group events. This forced sequential x64+arm64 builds to avoid keychain race conditions. Since build.yml is only for PRs/merge queue (releases use release.yml triggered by tag publish), we can remove code signing entirely and let both architectures build in parallel. Generated with mux
1 parent 35ad55b commit fddf0f2

File tree

1 file changed

+2
-24
lines changed

1 file changed

+2
-24
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -18,30 +18,8 @@ jobs:
1818

1919
- uses: ./.github/actions/setup-mux
2020

21-
# Skip signing setup for PRs - electron-builder skips signing anyway,
22-
# but setting CSC_LINK forces our Makefile to build sequentially.
23-
# Without CSC_LINK, x64 and arm64 build in parallel (~90s savings).
24-
- name: Setup code signing
25-
if: github.event_name != 'pull_request'
26-
run: ./scripts/setup-macos-signing.sh
27-
env:
28-
MACOS_CERTIFICATE: ${{ secrets.MACOS_CERTIFICATE }}
29-
MACOS_CERTIFICATE_PWD: ${{ secrets.MACOS_CERTIFICATE_PWD }}
30-
AC_APIKEY_P8_BASE64: ${{ secrets.AC_APIKEY_P8_BASE64 }}
31-
AC_APIKEY_ID: ${{ secrets.AC_APIKEY_ID }}
32-
AC_APIKEY_ISSUER_ID: ${{ secrets.AC_APIKEY_ISSUER_ID }}
33-
34-
- name: Verify signing setup
35-
if: github.event_name != 'pull_request'
36-
run: |
37-
if [ -n "${CSC_LINK:-}" ]; then
38-
echo "✅ Code signing enabled"
39-
security list-keychains -d user
40-
security find-identity -v -p codesigning
41-
else
42-
echo "⚠️ Code signing NOT enabled"
43-
fi
44-
21+
# No code signing here - releases use release.yml (triggered by tag publish).
22+
# Without CSC_LINK, x64 and arm64 builds run in parallel (~12 min faster).
4523
- name: Package for macOS
4624
run: make dist-mac
4725

0 commit comments

Comments
 (0)