From 45634090e4c06f40badc9c99005e7046d5b4ad12 Mon Sep 17 00:00:00 2001
From: Michael Suchacz <203725896+ibetitsmike@users.noreply.github.com>
Date: Wed, 3 Dec 2025 12:58:50 +0000
Subject: [PATCH] =?UTF-8?q?=F0=9F=A4=96=20perf:=20remove=20code=20signing?=
 =?UTF-8?q?=20from=20build.yml=20for=20parallel=20macOS=20builds?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The macOS build was taking 24+ minutes because code signing forced
sequential x64+arm64 builds (to avoid keychain race conditions).

Removed signing entirely from build.yml since releases use release.yml
(triggered by tag publish). This lets both architectures build in parallel.

- Before: 24m40s (sequential with signing)
- After: ~4m (parallel, no signing)

Generated with mux
---
 .github/workflows/build.yml | 26 ++------------------------
 1 file changed, 2 insertions(+), 24 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index e07f45d1ab..6b3a3e33d7 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -18,30 +18,8 @@ jobs:
 
       - uses: ./.github/actions/setup-mux
 
-      # Skip signing setup for PRs - electron-builder skips signing anyway,
-      # but setting CSC_LINK forces our Makefile to build sequentially.
-      # Without CSC_LINK, x64 and arm64 build in parallel (~90s savings).
-      - name: Setup code signing
-        if: github.event_name != 'pull_request'
-        run: ./scripts/setup-macos-signing.sh
-        env:
-          MACOS_CERTIFICATE: ${{ secrets.MACOS_CERTIFICATE }}
-          MACOS_CERTIFICATE_PWD: ${{ secrets.MACOS_CERTIFICATE_PWD }}
-          AC_APIKEY_P8_BASE64: ${{ secrets.AC_APIKEY_P8_BASE64 }}
-          AC_APIKEY_ID: ${{ secrets.AC_APIKEY_ID }}
-          AC_APIKEY_ISSUER_ID: ${{ secrets.AC_APIKEY_ISSUER_ID }}
-
-      - name: Verify signing setup
-        if: github.event_name != 'pull_request'
-        run: |
-          if [ -n "${CSC_LINK:-}" ]; then
-            echo "✅ Code signing enabled"
-            security list-keychains -d user
-            security find-identity -v -p codesigning
-          else
-            echo "⚠️ Code signing NOT enabled"
-          fi
-
+      # No code signing - releases use release.yml (triggered by tag publish).
+      # Without CSC_LINK, x64 and arm64 builds run in parallel (~12 min faster).
       - name: Package for macOS
         run: make dist-mac