🤖 feat: add UI styling for background bash processes #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BashToolCall: show '⚡ background • display_name' for background spawns instead of timeout/duration; show output file paths in expanded view - BashBackgroundListToolCall: new component showing process list with status badges, exit codes, uptimes, scripts, and output file paths - BashBackgroundTerminateToolCall: new component showing terminated process with display_name from result - Wire up new components in ToolMessage.tsx _Generated with mux_
ethanndickson
force-pushed
the
bash-background-ui-styling
branch
from
aaaf93f to
0a76e44
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…aths, formatDuration) DRY up tool components by extracting common patterns: - ToolIcon: emoji + tooltip wrapper used in all tools - ErrorBox: danger-styled error display box - OutputPaths: stdout/stderr file path display - formatDuration: human-readable time formatting (ms/s/m/h) Net reduction of ~39 lines in new components while improving consistency.
ethanndickson
force-pushed
the
bash-background-ui-styling
branch
from
c26f91a to
1eade3f
Compare
Update FileReadToolCall, FileEditToolCall, WebFetchToolCall, StatusSetToolCall, and TodoToolCall to use ToolIcon and ErrorBox primitives instead of duplicated TooltipWrapper/Tooltip and manual error styling. Net removal of ~26 lines while ensuring consistent styling.
ethanndickson
force-pushed
the
bash-background-ui-styling
branch
from
9ddd37c to
d8dc85b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
Adds custom UI components for background bash tools:
⚡ background • display_namefor background spawns instead of timeout/duration; shows output file paths in expanded viewGenerated with mux