From 838eeca767b44079aa55659318737b831c00f2c6 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Thu, 3 Jul 2025 09:27:56 +0500 Subject: [PATCH] Revert "chore: update RDP modules display names, icon and docs (#169)" This reverts commit 6537aebb1fa74c76272069274ce82c02b89a5a37. --- .icons/rdp.svg | 35 ------------------- MAINTAINER.md | 10 ++++-- .../coder/modules/local-windows-rdp/README.md | 14 ++++---- registry/coder/modules/windows-rdp/README.md | 14 +++++--- 4 files changed, 23 insertions(+), 50 deletions(-) delete mode 100644 .icons/rdp.svg diff --git a/.icons/rdp.svg b/.icons/rdp.svg deleted file mode 100644 index a47bfe7e4..000000000 --- a/.icons/rdp.svg +++ /dev/null @@ -1,35 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/MAINTAINER.md b/MAINTAINER.md index 2011b5aa7..69d1a6576 100644 --- a/MAINTAINER.md +++ b/MAINTAINER.md @@ -14,7 +14,9 @@ brew install go sudo apt install golang-go ``` -## Reviewing a PR +## Daily Tasks + +### Review PRs Check that PRs have: @@ -24,7 +26,7 @@ Check that PRs have: - [ ] Formatted code (`bun run fmt`) - [ ] Avatar image for new namespaces (`avatar.png` or `avatar.svg` in `.images/`) -### Version Guidelines +#### Version Guidelines When reviewing PRs, ensure the version change follows semantic versioning: @@ -40,7 +42,7 @@ PRs should clearly indicate the version change (e.g., `v1.2.3 → v1.2.4`). go build ./cmd/readmevalidation && ./readmevalidation ``` -## Making a Release +## Releases ### Create Release Tags @@ -97,3 +99,5 @@ status: "community" # or "partner", "official" - **Tests fail**: Ensure Docker with `--network=host`, check Terraform syntax - **Wrong file structure**: Use `./scripts/new_module.sh` for new modules - **Missing namespace avatar**: Must be `avatar.png` or `avatar.svg` in `.images/` directory + +That's it. Keep it simple. diff --git a/registry/coder/modules/local-windows-rdp/README.md b/registry/coder/modules/local-windows-rdp/README.md index ff93a4386..4b447967f 100644 --- a/registry/coder/modules/local-windows-rdp/README.md +++ b/registry/coder/modules/local-windows-rdp/README.md @@ -1,24 +1,24 @@ --- -display_name: RDP Desktop +display_name: Windows RDP Desktop description: Enable RDP on Windows and add a one-click Coder Desktop button for seamless access -icon: ../../../../.icons/rdp.svg +icon: ../../../../.icons/desktop.svg maintainer_github: coder verified: true supported_os: [windows] -tags: [rdp, windows, desktop, local] +tags: [rdp, windows, desktop, remote] --- # Windows RDP Desktop This module enables Remote Desktop Protocol (RDP) on Windows workspaces and adds a one-click button to launch RDP sessions directly through [Coder Desktop](https://coder.com/docs/user-guides/desktop). It provides a complete, standalone solution for RDP access, eliminating the need for manual configuration or port forwarding through the Coder CLI. -> [!NOTE] > [Coder Desktop](https://coder.com/docs/user-guides/desktop) is required on client devices to use the Local Windows RDP access feature. +> **Note**: [Coder Desktop](https://coder.com/docs/user-guides/desktop) is required on client devices to use the Local Windows RDP access feature. ```tf module "rdp_desktop" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/local-windows-rdp/coder" - version = "1.0.1" + version = "1.0.0" agent_id = coder_agent.main.id agent_name = coder_agent.main.name } @@ -51,7 +51,7 @@ Uses default credentials (Username: `Administrator`, Password: `coderRDP!`): module "rdp_desktop" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/local-windows-rdp/coder" - version = "1.0.1" + version = "1.0.0" agent_id = coder_agent.main.id agent_name = coder_agent.main.name } @@ -65,7 +65,7 @@ Specify a custom display name for the `coder_app` button: module "rdp_desktop" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/local-windows-rdp/coder" - version = "1.0.1" + version = "1.0.0" agent_id = coder_agent.windows.id agent_name = "windows" display_name = "Windows Desktop" diff --git a/registry/coder/modules/windows-rdp/README.md b/registry/coder/modules/windows-rdp/README.md index f2944f908..0899a79ab 100644 --- a/registry/coder/modules/windows-rdp/README.md +++ b/registry/coder/modules/windows-rdp/README.md @@ -1,5 +1,5 @@ --- -display_name: RDP Web +display_name: Windows RDP description: RDP Server and Web Client, powered by Devolutions Gateway icon: ../../../../.icons/desktop.svg maintainer_github: coder @@ -16,7 +16,7 @@ Enable Remote Desktop + a web based client on Windows workspaces, powered by [de module "windows_rdp" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/windows-rdp/coder" - version = "1.2.2" + version = "1.2.1" agent_id = resource.coder_agent.main.id resource_id = resource.aws_instance.dev.id } @@ -34,7 +34,7 @@ module "windows_rdp" { module "windows_rdp" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/windows-rdp/coder" - version = "1.2.2" + version = "1.2.1" agent_id = resource.coder_agent.main.id resource_id = resource.aws_instance.dev.id } @@ -46,7 +46,7 @@ module "windows_rdp" { module "windows_rdp" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/windows-rdp/coder" - version = "1.2.2" + version = "1.2.1" agent_id = resource.coder_agent.main.id resource_id = resource.google_compute_instance.dev[0].id } @@ -58,9 +58,13 @@ module "windows_rdp" { module "windows_rdp" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/windows-rdp/coder" - version = "1.2.2" + version = "1.2.1" agent_id = resource.coder_agent.main.id resource_id = resource.aws_instance.dev.id devolutions_gateway_version = "2025.1.6" # Specify a specific version } ``` + +## Roadmap + +- [ ] Test on Microsoft Azure.