resolve remaining comments

Author: ix-56h

pyproject.toml

@@ -110,8 +110,3 @@ asyncio_mode = "auto"
 asyncio_default_fixture_loop_scope = "function"
 python_classes = "Test*"
 python_functions = "test_*"
-
-[dependency-groups]
-dev = [
-    "ruff>=0.12.1",
-]

src/server/routers/ingest.py

@@ -1,6 +1,6 @@
 """Ingest endpoint for the API."""
 
-from fastapi import APIRouter, Request
+from fastapi import APIRouter, Request, status
 from fastapi.responses import JSONResponse
 
 from server.form_types import IntForm, OptStrForm, StrForm
@@ -14,9 +14,9 @@
 @router.post(
     "/api/ingest",
     responses={
-        200: {"model": IngestSuccessResponse, "description": "Successful ingestion"},
-        400: {"model": IngestErrorResponse, "description": "Bad request or processing error"},
-        500: {"model": IngestErrorResponse, "description": "Internal server error"},
+        status.HTTP_200_OK: {"model": IngestSuccessResponse, "description": "Successful ingestion"},
+        status.HTTP_400_BAD_REQUEST: {"model": IngestErrorResponse, "description": "Bad request or processing error"},
+        status.HTTP_500_INTERNAL_SERVER_ERROR: {"model": IngestErrorResponse, "description": "Internal server error"},
     },
 )
 @limiter.limit("10/minute")
@@ -83,7 +83,7 @@ async def api_ingest(
                 token=token,
             )
             return JSONResponse(
-                status_code=400,
+                status_code=status.HTTP_400_BAD_REQUEST,
                 content=error_response.model_dump(),
             )
 
@@ -101,7 +101,7 @@ async def api_ingest(
             token=context.get("token"),
         )
         return JSONResponse(
-            status_code=200,
+            status_code=status.HTTP_200_OK,
             content=success_response.model_dump(),
         )
 
@@ -116,7 +116,7 @@ async def api_ingest(
             token=token,
         )
         return JSONResponse(
-            status_code=400,
+            status_code=status.HTTP_400_BAD_REQUEST,
             content=error_response.model_dump(),
         )
 
@@ -131,6 +131,6 @@ async def api_ingest(
             token=token,
         )
         return JSONResponse(
-            status_code=500,
+            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
             content=error_response.model_dump(),
         )

tests/test_flow_integration.py

@@ -62,7 +62,7 @@ async def test_remote_repository_analysis(request: pytest.FixtureRequest) -> Non
     # Check that response is JSON
     response_data = response.json()
     assert "result" in response_data
-    assert response_data["result"] is True
+    assert response_data["result"]
     assert "repo_url" in response_data
     assert "summary" in response_data
     assert "tree" in response_data
@@ -111,7 +111,7 @@ async def test_large_repository(request: pytest.FixtureRequest) -> None:
     response_data = response.json()
     if response.status_code == status.HTTP_200_OK:
         assert "result" in response_data
-        assert response_data["result"] is True
+        assert response_data["result"]
     else:
         assert "error" in response_data
 
@@ -136,7 +136,7 @@ def make_request() -> None:
         response_data = response.json()
         if response.status_code == status.HTTP_200_OK:
             assert "result" in response_data
-            assert response_data["result"] is True
+            assert response_data["result"]
         else:
             assert "error" in response_data
 
@@ -165,7 +165,7 @@ async def test_large_file_handling(request: pytest.FixtureRequest) -> None:
     response_data = response.json()
     if response.status_code == status.HTTP_200_OK:
         assert "result" in response_data
-        assert response_data["result"] is True
+        assert response_data["result"]
     else:
         assert "error" in response_data
 
@@ -189,7 +189,7 @@ async def test_repository_with_patterns(request: pytest.FixtureRequest) -> None:
     response_data = response.json()
     if response.status_code == status.HTTP_200_OK:
         assert "result" in response_data
-        assert response_data["result"] is True
+        assert response_data["result"]
         assert "pattern_type" in response_data
         assert response_data["pattern_type"] == "include"
         assert "pattern" in response_data