fix: remove result bool in Success response object since it's useless, remove sensitive data from the Success Response object, make the integration unit test compatible

Author: ix-56h

src/server/models.py

@@ -3,7 +3,7 @@
 from __future__ import annotations
 
 from enum import Enum
-from typing import Literal, Union
+from typing import Union
 
 from pydantic import BaseModel, Field, field_validator
 
@@ -63,8 +63,6 @@ class IngestSuccessResponse(BaseModel):
 
     Attributes
     ----------
-    result : Literal[True]
-        Always True for successful responses.
     repo_url : str
         The original repository URL that was processed.
     short_repo_url : str
@@ -81,12 +79,9 @@ class IngestSuccessResponse(BaseModel):
         The pattern type used for filtering.
     pattern : str
         The pattern used for filtering.
-    token : str | None
-        The token used (if any).
 
     """
 
-    result: Literal[True] = True
     repo_url: str = Field(..., description="Original repository URL")
     short_repo_url: str = Field(..., description="Short repository URL (user/repo)")
     summary: str = Field(..., description="Ingestion summary with token estimates")
@@ -95,7 +90,6 @@ class IngestSuccessResponse(BaseModel):
     default_file_size: int = Field(..., description="File size slider position used")
     pattern_type: str = Field(..., description="Pattern type used")
     pattern: str = Field(..., description="Pattern used")
-    token: str | None = Field(None, description="Token used (if any)")
 
 
 class IngestErrorResponse(BaseModel):
@@ -107,23 +101,11 @@ class IngestErrorResponse(BaseModel):
         Error message describing what went wrong.
     repo_url : str
         The repository URL that failed to process.
-    default_file_size : int
-        The file size slider position that was used.
-    pattern_type : str
-        The pattern type that was used.
-    pattern : str
-        The pattern that was used.
-    token : str | None
-        The token that was used (if any).
 
     """
 
     error: str = Field(..., description="Error message")
     repo_url: str = Field(..., description="Repository URL that failed")
-    default_file_size: int = Field(..., description="File size slider position used")
-    pattern_type: str = Field(..., description="Pattern type used")
-    pattern: str = Field(..., description="Pattern used")
-    token: str | None = Field(None, description="Token used (if any)")
 
 
 # Union type for API responses

src/server/query_processor.py

@@ -134,7 +134,6 @@ async def process_query(
 
     context.update(
         {
-            "result": True,
             "summary": summary,
             "tree": tree,
             "content": content,

src/server/routers/ingest.py

@@ -77,10 +77,6 @@ async def api_ingest(
             error_response = IngestErrorResponse(
                 error=context["error"],
                 repo_url=context.get("repo_url", input_text),
-                default_file_size=context.get("default_file_size", max_file_size),
-                pattern_type=context.get("pattern_type", pattern_type),
-                pattern=context.get("pattern", pattern),
-                token=token,
             )
             return JSONResponse(
                 status_code=status.HTTP_400_BAD_REQUEST,
@@ -89,7 +85,6 @@ async def api_ingest(
 
         # Return structured success response with 200 status code
         success_response = IngestSuccessResponse(
-            result=True,
             repo_url=context["repo_url"],
             short_repo_url=context["short_repo_url"],
             summary=context["summary"],
@@ -98,7 +93,6 @@ async def api_ingest(
             default_file_size=context["default_file_size"],
             pattern_type=context["pattern_type"],
             pattern=context["pattern"],
-            token=context.get("token"),
         )
         return JSONResponse(
             status_code=status.HTTP_200_OK,
@@ -110,10 +104,6 @@ async def api_ingest(
         error_response = IngestErrorResponse(
             error=f"Validation error: {ve!s}",
             repo_url=input_text,
-            default_file_size=max_file_size,
-            pattern_type=pattern_type,
-            pattern=pattern,
-            token=token,
         )
         return JSONResponse(
             status_code=status.HTTP_400_BAD_REQUEST,
@@ -125,10 +115,6 @@ async def api_ingest(
         error_response = IngestErrorResponse(
             error=f"Internal server error: {exc!s}",
             repo_url=input_text,
-            default_file_size=max_file_size,
-            pattern_type=pattern_type,
-            pattern=pattern,
-            token=token,
         )
         return JSONResponse(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,

tests/test_flow_integration.py

@@ -61,8 +61,8 @@ async def test_remote_repository_analysis(request: pytest.FixtureRequest) -> Non
 
     # Check that response is JSON
     response_data = response.json()
-    assert "result" in response_data
-    assert response_data["result"]
+    assert "content" in response_data
+    assert response_data["content"]
     assert "repo_url" in response_data
     assert "summary" in response_data
     assert "tree" in response_data
@@ -110,8 +110,8 @@ async def test_large_repository(request: pytest.FixtureRequest) -> None:
 
     response_data = response.json()
     if response.status_code == status.HTTP_200_OK:
-        assert "result" in response_data
-        assert response_data["result"]
+        assert "content" in response_data
+        assert response_data["content"]
     else:
         assert "error" in response_data
 
@@ -135,8 +135,8 @@ def make_request() -> None:
 
         response_data = response.json()
         if response.status_code == status.HTTP_200_OK:
-            assert "result" in response_data
-            assert response_data["result"]
+            assert "content" in response_data
+            assert response_data["content"]
         else:
             assert "error" in response_data
 
@@ -164,8 +164,8 @@ async def test_large_file_handling(request: pytest.FixtureRequest) -> None:
 
     response_data = response.json()
     if response.status_code == status.HTTP_200_OK:
-        assert "result" in response_data
-        assert response_data["result"]
+        assert "content" in response_data
+        assert response_data["content"]
     else:
         assert "error" in response_data
 
@@ -188,8 +188,7 @@ async def test_repository_with_patterns(request: pytest.FixtureRequest) -> None:
 
     response_data = response.json()
     if response.status_code == status.HTTP_200_OK:
-        assert "result" in response_data
-        assert response_data["result"]
+        assert "content" in response_data
         assert "pattern_type" in response_data
         assert response_data["pattern_type"] == "include"
         assert "pattern" in response_data