Change method name from exists? to exist? to match File#exist?

Author: kimihito

app/controllers/docs_controller.rb

@@ -15,7 +15,7 @@ def kata
 
   def show
     @doc = Document.new(params[:id])
-    redirect_to root_url unless @doc.exists?
+    redirect_to root_url unless @doc.exist?
 
     if @doc.content.include? "NUM_OF_"
       @doc.content.gsub! "{{ NUM_OF_JAPAN_DOJOS }}",   Dojo.active_dojos_count.to_s

app/models/document.rb

@@ -55,21 +55,21 @@ def url
     "#{URL_PATH}/#{self.filename}"
   end
 
-  def exists?
+  def exist?
     return false if path.include? "\u0000"
     Document.all.map(&:filename).include?(filename)
   end
 
   def title
-    return '' unless self.exists?
+    return '' unless self.exist?
     @title ||=
       ActionController::Base.helpers.strip_tags(
         Kramdown::Document.new(self.get_first_paragraph, input: 'GFM').to_html
       ).strip
   end
 
   def description
-    return '' unless self.exists?
+    return '' unless self.exist?
     @desc ||=
       ActionController::Base.helpers.strip_tags(
         Kramdown::Document.new(self.get_second_paragraph, input: 'GFM').to_html
@@ -80,7 +80,7 @@ def description=(text)
   end
 
   def content
-    @content ||= self.exists? ? File.read(self.path) : ''
+    @content ||= self.exist? ? File.read(self.path) : ''
   end
 
   private

app/models/podcast.rb

@@ -18,7 +18,7 @@ def path
     "#{DIR_PATH}/#{id}.md"
   end
 
-  def exists?(offset: 0)
+  def exist?(offset: 0)
     return false if self.path.include?("\u0000")
     return false if (self.id + offset).zero?
     File.exist?("#{DIR_PATH}/#{id + offset}.md")
@@ -30,6 +30,6 @@ def cover
   end
 
   def content
-    exists? ? File.read(path) : ''
+    exist? ? File.read(path) : ''
   end
 end

app/views/podcasts/_navigation.html.erb

@@ -1,6 +1,6 @@
 <div style="display: table; font-weight: bolder; width: 100%; padding: 10px 10px; background-color:#3870c4;">
   <p class="nav prev">
-    <% if @episode.exists?(offset: -1) %>
+    <% if @episode.exist?(offset: -1) %>
       <%= link_to podcast_path(@episode.id - 1), title: '前のエピソードを見る' do %>
 	&laquo; prev
       <% end %>
@@ -12,7 +12,7 @@
     <%= link_to '目次に戻る'.html_safe, podcasts_path %>
   </p>
   <p class="nav next">
-    <% if @episode.exists?(offset: +1) %>
+    <% if @episode.exist?(offset: +1) %>
       <%= link_to podcast_path(@episode.id + 1), title: '次のエピソードを見る' do %>
 	next &raquo;
       <% end %>

spec/features/podcasts_spec.rb

@@ -9,8 +9,8 @@
 
     scenario 'Charter should be exist' do
       @podcast = create(:podcast)
-      allow(@podcast).to receive(:exists?) { true }
-      allow(@podcast).to receive(:exists?).with(offset: -1) { false }
+      allow(@podcast).to receive(:exist?) { true }
+      allow(@podcast).to receive(:exist?).with(offset: -1) { false }
       allow(@podcast).to receive(:content) { "title\n収録日: 2019/05/10\n..." }
       allow(Podcast).to  receive(:find_by).with(id: @podcast.id.to_s) { @podcast }
 
@@ -25,7 +25,7 @@
 
     scenario 'Load doc file with absolute path' do
       @podcast = create(:podcast)
-      allow(@podcast).to receive(:exists?) { true }
+      allow(@podcast).to receive(:exist?) { true }
       allow(@podcast).to receive(:content) { "title\n収録日: 2019/05/10\n..." }
       allow(Podcast).to  receive(:find_by).with(id: @podcast.id.to_s) { @podcast }
 

spec/models/podcast_spec.rb

@@ -10,11 +10,11 @@
     expect(@podcast.path).to eq("public/podcasts/#{@podcast.id}.md")
   end
 
-  describe 'exists?(offset: 0)' do
+  describe 'exist?(offset: 0)' do
     it '\u0000 を含む ⇒ false' do
       allow(@podcast).to receive(:path) { "public/podcasts/\u0000" }
 
-      expect(@podcast.exists?).to eq(false)
+      expect(@podcast.exist?).to eq(false)
     end
 
     context 'offset 省略' do
@@ -25,11 +25,11 @@
       it 'ファイルあり ⇒ true' do
         allow(File).to receive(:exist?).with("public/podcasts/#{@podcast.id}.md") { true }
 
-        expect(@podcast.exists?).to eq(true)
+        expect(@podcast.exist?).to eq(true)
       end
 
       it 'ファイルなし ⇒ false' do
-        expect(@podcast.exists?).to eq(false)
+        expect(@podcast.exist?).to eq(false)
       end
     end
 
@@ -41,11 +41,11 @@
       it 'ファイルあり ⇒ true' do
         allow(File).to receive(:exist?).with("public/podcasts/#{@podcast.id + 1}.md") { true }
 
-        expect(@podcast.exists?(offset: 1)).to eq(true)
+        expect(@podcast.exist?(offset: 1)).to eq(true)
       end
 
       it 'ファイルなし ⇒ false' do
-        expect(@podcast.exists?(offset: 1)).to eq(false)
+        expect(@podcast.exist?(offset: 1)).to eq(false)
       end
     end
   end
@@ -57,13 +57,13 @@
     end
 
     it 'ファイル存在 ⇒ ファイルから読み込み' do
-      allow(@podcast).to receive(:exists?) { true }
+      allow(@podcast).to receive(:exist?) { true }
 
       expect(@podcast.content).to eq(@content_body)
     end
 
     it 'ファイルなし ⇒ 空文字列' do
-      allow(@podcast).to receive(:exists?) { false }
+      allow(@podcast).to receive(:exist?) { false }
 
       expect(@podcast.content).to eq('')
     end