kernel: Prettify logs

Author: coditva

kernel/boot/multiboot.c

@@ -4,30 +4,34 @@
 
 static inline void multiboot_dump_mmap(multiboot_info_t *info)
 {
+#ifdef DEBUG
   if (info->flags & MULTIBOOT_FLAG_MEM_MAP) {
     klog(LOG_DEBUG, "mem map len     : 0x%x\n", info->mmap_len);
     klog(LOG_DEBUG, "mem map addr    : 0x%x\n", info->mmap_addr);
 
     int i = 0;
+    klog(LOG_DEBUG, LOG_HRULE);
     klog(LOG_DEBUG, "   | size       | base                | length              | type\n");
-    klog(LOG_DEBUG, "------------------------------------------------------------------\n");
+    klog(LOG_DEBUG, LOG_HRULE);
     FOREACH_MEMORY_MAP(mmap, info) {
       klog(LOG_DEBUG, " %d | 0x%x | 0x%x %x | 0x%x %x | %d\n",
           i, mmap->size, mmap->base_addr_high, mmap->base_addr_low,
           mmap->len_high, mmap->len_low, mmap->type);
       i++;
     }
+    klog(LOG_DEBUG, LOG_HRULE);
   } else {
     klog(LOG_WARN, "memory map not set\n");
   }
+#endif
 }
 
-void multiboot_dump_info(multiboot_info_t *info)
+inline void multiboot_dump_info(multiboot_info_t *info)
 {
-#ifndef DEBUG
-  return;
-#endif
-  klog(LOG_DEBUG, "------------ MULTIBOOT DUMP ------------\n");
+#ifdef DEBUG
+  klog(LOG_DEBUG, LOG_HRULE);
+  klog(LOG_DEBUG, "MULTIBOOT DUMP START\n");
+  klog(LOG_DEBUG, LOG_HRULE);
   klog(LOG_DEBUG, "multiboot header: 0x%x\n", info);
   klog(LOG_DEBUG, "flags           : 0x%x\n", info->flags);
   klog(LOG_DEBUG, "mem lower       : 0x%x\n", info->mem_lower);
@@ -39,5 +43,9 @@ void multiboot_dump_info(multiboot_info_t *info)
   multiboot_dump_mmap(info);
   klog(LOG_DEBUG, "config table    : 0x%x\n", info->config_table);
   klog(LOG_DEBUG, "bootloader name : %s\n",   info->bootloader_name);
-  klog(LOG_DEBUG, "----------------------------------------\n");
+  klog(LOG_DEBUG, LOG_HRULE);
+  klog(LOG_DEBUG, "MULTIBOOT DUMP END\n");
+  klog(LOG_DEBUG, LOG_HRULE);
+  klog(LOG_DEBUG, "\n");
+#endif
 }

kernel/include/logger.h

@@ -8,6 +8,9 @@
 # define LOG_INFO   2
 # define LOG_DEBUG  3
 
+# define LOG_HRULE \
+    "------------------------------------------------------------------------\n"
+
 # ifdef DEBUG
 #  include<kio.h>
 #  define klog(LOG_LEVEL, FORMAT, ...) \

kernel/mm/page_frame.c

@@ -68,10 +68,6 @@ int page_frame_init(multiboot_info_t *multiboot_info)
   num_frames_bitset_frames =
       NUM_OF_A_PER_B(num_frames_bitset_lines, BITSET_LINES_PER_FRAME);
 
-  klog(LOG_DEBUG, "Number of frames: %d\n", num_frames);
-  klog(LOG_DEBUG, "Number of bitset lines: %d\nNumber of bitset pages: %d\n",
-      num_frames_bitset_lines, num_frames_bitset_frames);
-
   /* mark all free pages */
   FOREACH_MEMORY_MAP(mmap, multiboot_info) {
     if (mmap->type == MULTIBOOT_MEM_TYPE_FREE) {
@@ -96,7 +92,13 @@ void page_frame_dump_map(void)
 {
 #ifdef DEBUG
   uint32_t *frame = frames_bitset;
-  klog(LOG_DEBUG, "frames_bitset addr: 0x%x\n", frame);
+  klog(LOG_DEBUG, LOG_HRULE);
+  klog(LOG_DEBUG, "PAGE FRAMES MEMORY DUMP START\n");
+  klog(LOG_DEBUG, LOG_HRULE);
+  klog(LOG_DEBUG, "Number of frames: %d\n", num_frames);
+  klog(LOG_DEBUG, "Number of bitset lines: %d\n", num_frames_bitset_lines);
+  klog(LOG_DEBUG, "Number of bitset pages: %d\n", num_frames_bitset_frames);
+  klog(LOG_DEBUG, "Frames bitmap at 0x%x\n", frame);
   for (int j = 0; j < num_frames_bitset_lines; j++) {
     klog(LOG_DEBUG, "\n%x: ", FRAME_NUM_TO_PAGE_ADDR(j * FRAMES_PER_BITSET));
     for (int k = 0; k < FRAMES_PER_BITSET; k++) {
@@ -108,6 +110,9 @@ void page_frame_dump_map(void)
     }
   }
   klog(LOG_DEBUG, "\n");
+  klog(LOG_DEBUG, LOG_HRULE);
+  klog(LOG_DEBUG, "PAGE FRAMES MEMORY DUMP END\n");
+  klog(LOG_DEBUG, LOG_HRULE);
 #endif
 }