feat(migrate): replace lodash.isnil

Author: phofmann

packages/sync-actions/package.json

@@ -26,7 +26,6 @@
     "fast-equals": "^2.0.0",
     "jsondiffpatch": "^0.4.0",
     "lodash.intersection": "^4.4.0",
-    "lodash.isnil": "^4.0.0",
     "lodash.shuffle": "^4.2.0",
     "lodash.sortby": "^4.7.0",
     "lodash.uniqwith": "^4.5.0",

packages/sync-actions/src/customer-actions.ts

@@ -1,5 +1,4 @@
-import isNil from 'lodash.isnil'
-import clone from './utils/clone'
+import clone, { notEmpty } from './utils/clone'
 import {
   buildBaseAttributesActions,
   buildReferenceActions,
@@ -214,5 +213,5 @@ function buildAuthenticationModeActions({ actions, diff, oldObj, newObj }) {
         [value]: newObj.password,
       }
     })
-    .filter((action) => !isNil(action))
+    .filter(notEmpty)
 }

packages/sync-actions/src/inventories.ts

@@ -4,12 +4,12 @@ import type {
   SyncActionConfig,
   UpdateAction,
 } from '@commercetools/sdk-client-v2'
+import { actionsMapBase, actionsMapReferences } from './inventory-actions'
 import { SyncAction } from './types/update-actions'
 import actionsMapCustom from './utils/action-map-custom'
 import createBuildActions from './utils/create-build-actions'
 import createMapActionGroup from './utils/create-map-action-group'
 import { diff } from './utils/diffpatcher'
-import { actionsMapBase, actionsMapReferences } from './inventory-actions'
 
 export const actionGroups = ['base', 'references']
 

packages/sync-actions/src/types-actions.ts

@@ -1,3 +1,4 @@
+import { deepEqual } from 'fast-equals'
 import sortBy from 'lodash.sortby'
 import { buildBaseAttributesActions } from './utils/common-actions'
 import createBuildArrayActions, {
@@ -6,7 +7,6 @@ import createBuildArrayActions, {
 } from './utils/create-build-array-actions'
 import { getDeltaValue } from './utils/diffpatcher'
 import extractMatchingPairs from './utils/extract-matching-pairs'
-import { deepEqual } from 'fast-equals'
 
 const REGEX_NUMBER = new RegExp(/^\d+$/)
 const REGEX_UNDERSCORE_NUMBER = new RegExp(/^_\d+$/)

packages/sync-actions/src/utils/clone.ts

@@ -1,3 +1,9 @@
 export default function clone(obj) {
   return JSON.parse(JSON.stringify(obj))
 }
+
+export function notEmpty<TValue>(
+  value: TValue | null | undefined
+): value is TValue {
+  return value !== null && value !== undefined
+}

packages/sync-actions/src/utils/common-actions.ts

@@ -1,5 +1,4 @@
-import isNil from 'lodash.isnil'
-import clone from './clone'
+import clone, { notEmpty } from './clone'
 import { getDeltaValue, patch } from './diffpatcher'
 
 const normalizeValue = (value) =>
@@ -64,7 +63,7 @@ export function buildBaseAttributesActions({
       const patched = patch(clone(before), delta)
       return { action: item.action, [actionKey]: patched }
     })
-    .filter((action) => !isNil(action))
+    .filter(notEmpty)
 }
 
 /**

packages/sync-actions/src/utils/copy-empty-array-props.ts

@@ -1,5 +1,3 @@
-import isNil from 'lodash.isnil'
-
 const CUSTOM = 'custom'
 
 /**
@@ -11,7 +9,7 @@ const CUSTOM = 'custom'
  * @returns {Array} Ordered Array [oldObj, newObj]
  */
 export default function copyEmptyArrayProps(oldObj = {}, newObj = {}) {
-  if (!isNil(oldObj) && !isNil(newObj)) {
+  if (oldObj && newObj) {
     const nextObjectWithEmptyArray = Object.entries(oldObj).reduce(
       (merged, [key, value]) => {
         // Ignore CUSTOM key as this object is dynamic and its up to the user to dynamically change it
@@ -26,13 +24,13 @@ export default function copyEmptyArrayProps(oldObj = {}, newObj = {}) {
           }, {})
           for (let i = 0; i < newObj[key].length; i++) {
             if (
-              !isNil(newObj[key][i]) &&
+              newObj[key][i] &&
               typeof newObj[key][i] === 'object' &&
-              !isNil(newObj[key][i].id)
+              newObj[key][i].id
             ) {
               // Since its unordered array elements then check if the element on `oldObj` exists by id
               const foundObject = hashMapValue[newObj[key][i].id]
-              if (!isNil(foundObject)) {
+              if (foundObject) {
                 const [, nestedObject] = copyEmptyArrayProps(
                   foundObject,
                   newObj[key][i]
@@ -50,11 +48,11 @@ export default function copyEmptyArrayProps(oldObj = {}, newObj = {}) {
           return merged
         }
         if (Array.isArray(value)) {
-          merged[key] = isNil(newObj[key]) ? [] : newObj[key]
+          merged[key] = newObj[key] ? newObj[key] : []
           return merged
         }
         if (
-          !isNil(newObj[key]) &&
+          newObj[key] &&
           typeof value === 'object' &&
           // Ignore Date as this will create invalid object since typeof date === 'object' return true
           // ex: {date: new Date()} will result {date: {}}

packages/sync-actions/src/utils/create-build-actions.ts

@@ -1,4 +1,3 @@
-import isNil from 'lodash.isnil'
 import { deepEqual } from 'fast-equals'
 
 function applyOnBeforeDiff(before, now, fn?: (before, now) => Array<any>) {
@@ -35,10 +34,9 @@ function injectMissingPriceIds(nextVariants, previousVariants) {
     if (!prices) return restOfVariant
     const oldVariant = previousVariants.find(
       (previousVariant) =>
-        (!isNil(previousVariant.id) && previousVariant.id === newVariant.id) ||
-        (!isNil(previousVariant.key) &&
-          previousVariant.key === newVariant.key) ||
-        (!isNil(previousVariant.sku) && previousVariant.sku === newVariant.sku)
+        (previousVariant.id && previousVariant.id === newVariant.id) ||
+        (previousVariant.key && previousVariant.key === newVariant.key) ||
+        (previousVariant.sku && previousVariant.sku === newVariant.sku)
     )
 
     return {
@@ -49,13 +47,17 @@ function injectMissingPriceIds(nextVariants, previousVariants) {
 
         if (oldPrice) {
           // copy ID if not provided
-          if (!newPrice.id) newPrice.id = oldPrice.id
+          if (!newPrice.id) {
+            newPrice.id = oldPrice.id
+          }
 
-          if (isNil(newPrice.value.type))
+          if (!newPrice.value.type) {
             newPrice.value.type = oldPrice.value.type
+          }
 
-          if (isNil(newPrice.value.fractionDigits))
+          if (!newPrice.value.fractionDigits) {
             newPrice.value.fractionDigits = oldPrice.value.fractionDigits
+          }
         }
 
         return newPrice

yarn.lock

@@ -6886,11 +6886,6 @@ lodash.isfunction@^3.0.9:
   resolved "https://registry.yarnpkg.com/lodash.isfunction/-/lodash.isfunction-3.0.9.tgz#06de25df4db327ac931981d1bdb067e5af68d051"
   integrity sha512-AirXNj15uRIMMPihnkInB4i3NHeb4iBtNg9WRWuK2o31S+ePwwNmDPaTL3o7dTJ+VXNZim7rFs4rxN4YU1oUJw==
 
-lodash.isnil@^4.0.0:
-  version "4.0.0"
-  resolved "https://registry.yarnpkg.com/lodash.isnil/-/lodash.isnil-4.0.0.tgz#49e28cd559013458c814c5479d3c663a21bfaa6c"
-  integrity sha512-up2Mzq3545mwVnMhTDMdfoG1OurpA/s5t88JmQX809eH3C8491iu2sfKhTfhQtKY78oPNhiaHJUpT/dUDAAtng==
-
 lodash.isplainobject@^4.0.6:
   version "4.0.6"
   resolved "https://registry.yarnpkg.com/lodash.isplainobject/-/lodash.isplainobject-4.0.6.tgz#7c526a52d89b45c45cc690b88163be0497f550cb"