feat(migrate): remove lodash.flatten

phofmann · phofmann · commit 9b976f2266a8 · 2023-11-07T11:44:42.000+01:00
diff --git a/packages/sync-actions/package.json b/packages/sync-actions/package.json
@@ -25,7 +25,6 @@
   "dependencies": {
     "fast-equals": "^2.0.0",
     "jsondiffpatch": "^0.4.0",
-    "lodash.flatten": "^4.4.0",
     "lodash.foreach": "^4.5.0",
     "lodash.intersection": "^4.4.0",
     "lodash.isequal": "^4.5.0",
diff --git a/packages/sync-actions/src/attribute-groups.ts b/packages/sync-actions/src/attribute-groups.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import type {
   SyncAction,
   ActionGroup,
@@ -36,15 +35,13 @@ function createAttributeGroupsMapActions(
       )
     )
     allActions.push(
-      flatten(
-        mapActionGroup(
-          'attributes',
-          (): Array<UpdateAction> =>
-            attributeGroupsActions.actionsMapAttributes(diff, oldObj, newObj)
-        )
-      )
+      mapActionGroup(
+        'attributes',
+        (): Array<UpdateAction> =>
+          attributeGroupsActions.actionsMapAttributes(diff, oldObj, newObj)
+      ).flat()
     )
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/cart-discounts.ts b/packages/sync-actions/src/cart-discounts.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import createBuildActions from './utils/create-build-actions'
 import createMapActionGroup from './utils/create-map-action-group'
 import actionsMapCustom from './utils/action-map-custom'
@@ -23,7 +22,7 @@ function createCartDiscountsMapActions(mapActionGroup, syncActionConfig) {
       mapActionGroup('custom', () => actionsMapCustom(diff, newObj, oldObj))
     )
 
-    return combineValidityActions(flatten(allActions))
+    return combineValidityActions(allActions.flat())
   }
 }
 
diff --git a/packages/sync-actions/src/categories.ts b/packages/sync-actions/src/categories.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import type {
   SyncAction,
   SyncActionConfig,
@@ -64,7 +63,7 @@ function createCategoryMapActions(
       )
     )
 
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/channels.ts b/packages/sync-actions/src/channels.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import createBuildActions from './utils/create-build-actions'
 import createMapActionGroup from './utils/create-map-action-group'
 import actionsMapCustom from './utils/action-map-custom'
@@ -22,7 +21,7 @@ function createChannelsMapActions(mapActionGroup, syncActionConfig) {
       mapActionGroup('custom', () => actionsMapCustom(diff, newObj, oldObj))
     )
 
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/customer-group.ts b/packages/sync-actions/src/customer-group.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import createBuildActions from './utils/create-build-actions'
 import createMapActionGroup from './utils/create-map-action-group'
 import actionsMapCustom from './utils/action-map-custom'
@@ -22,7 +21,7 @@ function createCustomerGroupMapActions(mapActionGroup, syncActionConfig) {
       mapActionGroup('custom', () => actionsMapCustom(diff, newObj, oldObj))
     )
 
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/customers.ts b/packages/sync-actions/src/customers.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import type {
   SyncAction,
   SyncActionConfig,
@@ -99,7 +98,7 @@ function createCustomerMapActions(
       )
     )
 
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/discount-codes.ts b/packages/sync-actions/src/discount-codes.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import createBuildActions from './utils/create-build-actions'
 import createMapActionGroup from './utils/create-map-action-group'
 import actionsMapCustom from './utils/action-map-custom'
@@ -20,7 +19,7 @@ function createDiscountCodesMapActions(mapActionGroup, syncActionConfig) {
     allActions.push(
       mapActionGroup('custom', () => actionsMapCustom(diff, newObj, oldObj))
     )
-    return combineValidityActions(flatten(allActions))
+    return combineValidityActions(allActions.flat())
   }
 }
 
diff --git a/packages/sync-actions/src/inventories.ts b/packages/sync-actions/src/inventories.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import type {
   SyncAction,
   SyncActionConfig,
@@ -48,7 +47,7 @@ function createInventoryMapActions(
         (): Array<UpdateAction> => actionsMapCustom(diff, newObj, oldObj)
       )
     )
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/orders.ts b/packages/sync-actions/src/orders.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import type {
   SyncAction,
   SyncActionConfig,
@@ -72,20 +71,18 @@ function createOrderMapActions(
     )
 
     allActions.push(
-      flatten(
-        mapActionGroup(
-          'returnInfo',
-          (): Array<UpdateAction> =>
-            orderActions.actionsMapReturnsInfo(diff, oldObj, newObj)
-        )
-      )
+      mapActionGroup(
+        'returnInfo',
+        (): Array<UpdateAction> =>
+          orderActions.actionsMapReturnsInfo(diff, oldObj, newObj)
+      ).flat()
     )
 
     allActions.push(
       mapActionGroup('custom', () => actionsMapCustom(diff, newObj, oldObj))
     )
 
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/product-discounts.ts b/packages/sync-actions/src/product-discounts.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import createBuildActions from './utils/create-build-actions'
 import createMapActionGroup from './utils/create-map-action-group'
 import { actionsMapBase } from './product-discounts-actions'
@@ -17,7 +16,7 @@ function createProductDiscountsMapActions(mapActionGroup, syncActionConfig) {
         actionsMapBase(diff, oldObj, newObj, syncActionConfig)
       )
     )
-    return combineValidityActions(flatten(allActions))
+    return combineValidityActions(allActions.flat())
   }
 }
 
diff --git a/packages/sync-actions/src/product-selections.ts b/packages/sync-actions/src/product-selections.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import type {
   SyncAction,
   UpdateAction,
@@ -38,7 +37,7 @@ function createProductSelectionsMapActions(
       )
     )
 
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/product-types-actions.ts b/packages/sync-actions/src/product-types-actions.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import { deepEqual } from 'fast-equals'
 import {
   createIsEmptyValue,
@@ -135,8 +134,8 @@ const generateUpdateActionsForAttributeDefinitions = (
       action: 'removeAttributeDefinition',
       name: attributeDef.previous.name,
     })),
-    ...flatten(
-      updatedAttributeDefinitions.map((updatedAttributeDefinition) =>
+    ...updatedAttributeDefinitions
+      .map((updatedAttributeDefinition) =>
         generateBaseFieldsUpdateActions(
           updatedAttributeDefinition.previous,
           updatedAttributeDefinition.next,
@@ -164,7 +163,7 @@ const generateUpdateActionsForAttributeDefinitions = (
           }
         )
       )
-    ),
+      .flat(),
     ...addedAttributeDefinitions.map((attributeDef) => ({
       action: 'addAttributeDefinition',
       attribute: attributeDef.next,
@@ -213,8 +212,8 @@ const generateUpdateActionsForAttributeEnumValues = (
         {}
       )
     ),
-    ...flatten(
-      updatedAttributeEnumValues.map((updatedAttributeEnumValue) => {
+    ...updatedAttributeEnumValues
+      .map((updatedAttributeEnumValue) => {
         const updateActions = generateBaseFieldsUpdateActions(
           updatedAttributeEnumValue.previous,
           updatedAttributeEnumValue.next,
@@ -252,7 +251,7 @@ const generateUpdateActionsForAttributeEnumValues = (
         }
         return updateActions
       })
-    ),
+      .flat(),
     ...addedAttributeEnumValues.map((addedAttributeEnumValue) => ({
       action: addedAttributeEnumValue.hint.isLocalized
         ? 'addLocalizedEnumValue'
diff --git a/packages/sync-actions/src/product-types.ts b/packages/sync-actions/src/product-types.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import type {
   SyncAction,
   UpdateAction,
@@ -27,7 +26,7 @@ function createProductTypeMapActions(
     previous: any,
     options: any
   ): Array<UpdateAction> {
-    return flatten([
+    return [
       // we support only base fields for the product type,
       // for attributes, applying hints would be recommended
       mapActionGroup(
@@ -45,7 +44,7 @@ function createProductTypeMapActions(
         previous,
         next
       ),
-    ])
+    ].flat()
   }
 }
 
diff --git a/packages/sync-actions/src/products.ts b/packages/sync-actions/src/products.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import type {
   SyncAction,
   SyncActionConfig,
@@ -160,9 +159,9 @@ function createProductMapActions(
     )
 
     if (publish === true || staged === false)
-      return flatten(allActions).map((action) => ({ ...action, staged: false }))
+      return allActions.flat().map((action) => ({ ...action, staged: false }))
 
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/projects.ts b/packages/sync-actions/src/projects.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import createBuildActions from './utils/create-build-actions'
 import createMapActionGroup from './utils/create-map-action-group'
 import { actionsMapBase } from './projects-actions'
@@ -16,7 +15,7 @@ function createChannelsMapActions(mapActionGroup, syncActionConfig) {
       )
     )
 
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/quote-requests.ts b/packages/sync-actions/src/quote-requests.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import type {
   SyncAction,
   SyncActionConfig,
@@ -44,7 +43,7 @@ function createQuoteRequestsMapActions(
       )
     )
 
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/quotes.ts b/packages/sync-actions/src/quotes.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import type {
   SyncAction,
   SyncActionConfig,
@@ -39,7 +38,7 @@ function createQuotesMapActions(
       )
     )
 
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/shipping-methods-actions.ts b/packages/sync-actions/src/shipping-methods-actions.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import createBuildArrayActions, {
   ADD_ACTIONS,
   REMOVE_ACTIONS,
@@ -104,7 +103,7 @@ export function actionsMapZoneRates(diff, oldObj, newObj) {
         []
       )
 
-      return flatten(
+      return (
         hasZoneActions
           ? [
               ...shippingRateActions,
@@ -120,7 +119,7 @@ export function actionsMapZoneRates(diff, oldObj, newObj) {
               ],
             ]
           : shippingRateActions
-      )
+      ).flat()
     },
   })
 
diff --git a/packages/sync-actions/src/shipping-methods.ts b/packages/sync-actions/src/shipping-methods.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import type {
   SyncAction,
   SyncActionConfig,
@@ -36,21 +35,19 @@ function createShippingMethodsMapActions(
       )
     )
     allActions.push(
-      flatten(
-        mapActionGroup(
-          'zoneRates',
-          (): Array<UpdateAction> =>
-            shippingMethodsActions.actionsMapZoneRates(diff, oldObj, newObj)
-        )
-      )
+      mapActionGroup(
+        'zoneRates',
+        (): Array<UpdateAction> =>
+          shippingMethodsActions.actionsMapZoneRates(diff, oldObj, newObj)
+      ).flat()
     )
     allActions.push(
       mapActionGroup(
         'custom',
         (): Array<UpdateAction> => actionsMapCustom(diff, newObj, oldObj)
       )
     )
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/staged-quotes.ts b/packages/sync-actions/src/staged-quotes.ts
@@ -1,4 +1,3 @@
-import flatten from 'lodash.flatten'
 import type {
   SyncAction,
   SyncActionConfig,
@@ -44,7 +43,7 @@ function createStagedQuotesMapActions(
       )
     )
 
-    return flatten(allActions)
+    return allActions.flat()
   }
 }
 
diff --git a/packages/sync-actions/src/states.ts b/packages/sync-actions/src/states.ts
diff --git a/packages/sync-actions/src/stores.ts b/packages/sync-actions/src/stores.ts
diff --git a/packages/sync-actions/src/tax-categories.ts b/packages/sync-actions/src/tax-categories.ts
diff --git a/packages/sync-actions/src/types-actions.ts b/packages/sync-actions/src/types-actions.ts
diff --git a/packages/sync-actions/src/types.ts b/packages/sync-actions/src/types.ts
diff --git a/packages/sync-actions/src/zones.ts b/packages/sync-actions/src/zones.ts
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-import flatten from 'lodash.flatten'`
`2`	`1`	`import type {`
`3`	`2`	`SyncAction,`
`4`	`3`	`ActionGroup,`
`@@ -36,15 +35,13 @@ function createAttributeGroupsMapActions(`
`36`	`35`	`)`
`37`	`36`	`)`
`38`	`37`	`allActions.push(`
`39`		`- flatten(`
`40`		`- mapActionGroup(`
`41`		`- 'attributes',`
`42`		`- (): Array<UpdateAction> =>`
`43`		`- attributeGroupsActions.actionsMapAttributes(diff, oldObj, newObj)`
`44`		`- )`
`45`		`- )`
	`38`	`+ mapActionGroup(`
	`39`	`+ 'attributes',`
	`40`	`+ (): Array<UpdateAction> =>`
	`41`	`+ attributeGroupsActions.actionsMapAttributes(diff, oldObj, newObj)`
	`42`	`+ ).flat()`
`46`	`43`	`)`
`47`		`- return flatten(allActions)`
	`44`	`+ return allActions.flat()`
`48`	`45`	`}`
`49`	`46`	`}`
`50`	`47`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-import flatten from 'lodash.flatten'`
`2`	`1`	`import createBuildActions from './utils/create-build-actions'`
`3`	`2`	`import createMapActionGroup from './utils/create-map-action-group'`
`4`	`3`	`import actionsMapCustom from './utils/action-map-custom'`
`@@ -23,7 +22,7 @@ function createCartDiscountsMapActions(mapActionGroup, syncActionConfig) {`
`23`	`22`	`mapActionGroup('custom', () => actionsMapCustom(diff, newObj, oldObj))`
`24`	`23`	`)`
`25`	`24`
`26`		`- return combineValidityActions(flatten(allActions))`
	`25`	`+ return combineValidityActions(allActions.flat())`
`27`	`26`	`}`
`28`	`27`	`}`
`29`	`28`