NginxProxyManager broken again for v2.13.5

[sammyke007]

✅ Have you read and understood the above guidelines?

yes

🔎 Did you run the script with verbose mode enabled?

Yes, verbose mode was enabled and the output is included below

📜 What is the name of the script you are using?

NginxProxyManager

📂 What was the exact command used to execute the script?

bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/nginxproxymanager.sh)"

⚙️ What settings are you using?

• Default Settings
• Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 13

📈 Which Proxmox version are you on?

pve-manager/9.0.17/c41e48ed2e1aa74a (running kernel: 6.17.2-1-pve)

📝 Provide a clear and concise description of the issue.

yarn seems to be failing on the newly added languages...
Log output:

    _   __      _               ____                           __  ___                                 
   / | / /___ _(_)___  _  __   / __ \_________  _  ____  __   /  |/  /___ _____  ____ _____ ____  _____
  /  |/ / __ `/ / __ \| |/_/  / /_/ / ___/ __ \| |/_/ / / /  / /|_/ / __ `/ __ \/ __ `/ __ `/ _ \/ ___/
 / /|  / /_/ / / / / />  <   / ____/ /  / /_/ />  </ /_/ /  / /  / / /_/ / / / / /_/ / /_/ /  __/ /    
/_/ |_/\__, /_/_/ /_/_/|_|  /_/   /_/   \____/_/|_|\__, /  /_/  /_/\__,_/_/ /_/\__,_/\__, /\___/_/     
      /____/                                      /____/                            /____/             

Hit:1 http://deb.debian.org/debian trixie InRelease
Hit:2 http://security.debian.org trixie-security InRelease                                      
Hit:3 http://openresty.org/package/debian bookworm InRelease                                    
Hit:4 http://deb.debian.org/debian trixie-updates InRelease         
Hit:5 https://deb.nodesource.com/node_22.x nodistro InRelease
24 packages can be upgraded. Run 'apt list --upgradable' to see them.
Warning: http://openresty.org/package/debian/dists/bookworm/InRelease: Policy will reject signature within a year, see --audit for details
Warning: https://deb.nodesource.com/node_22.x/dists/nodistro/InRelease: Policy will reject signature within a year, see --audit for details

changed 13 packages in 2s

28 packages are looking for funding
  run `npm fund` for details
  ✔️   Update Node.js 22
  ⏳   Updating yarn to latest version
changed 1 package in 708ms
  ✔️   Installed Node.js modules: yarn
  ✔️   nginxproxymanager is already up-to-date (v2.13.5)
  ✔️   Stopped Services
  ✔️   Cleaned old files
  ✔️   Set up Environment
yarn install v1.22.22
[1/4] Resolving packages...
success Already up-to-date.
Done in 0.21s.
yarn run v1.22.22
$ tsc && vite build
src/locale/IntlProvider.tsx:5:20 - error TS2307: Cannot find module './lang/it.json' or its corresponding type declarations.

5 import langIt from "./lang/it.json";
                     ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:8:20 - error TS2307: Cannot find module './lang/nl.json' or its corresponding type declarations.

8 import langNl from "./lang/nl.json";
                     ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:12:20 - error TS2307: Cannot find module './lang/vi.json' or its corresponding type declarations.

12 import langVi from "./lang/vi.json";
                      ~~~~~~~~~~~~~~~~


Found 3 errors in the same file, starting at: src/locale/IntlProvider.tsx:5

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[ERROR] in line 128: exit code 0: while executing command $STD yarn build

root@nginxproxymanager:~# 

🔄 Steps to reproduce the issue.

Try to update from v2.13.4 with:
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/nginxproxymanager.sh)"

❌ Paste the full error output (if available).

See above

🖼️ Additional context (optional).

No response

[MickLesk]

Report it at npm repo, "src/locale/IntlProvider.tsx:5:20 - error TS2307: Cannot find module './lang/it.json' or its corresponding type declarations." say all.

[sammyke007]

Report it at npm repo, "src/locale/IntlProvider.tsx:5:20 - error TS2307: Cannot find module './lang/it.json' or its corresponding type declarations." say all.

Done!
NginxProxyManager/nginx-proxy-manager#4957

[MickLesk]

The strange is, the file exist in tarball.

Can you enter to /opt/ng*/frontend/src/locale and do an ls -la?
and can you share the output of IntlProvider.tsx ?

[sammyke007]

I "fixed" it manually by executing this first:

cp /opt/nginxproxymanager/frontend/src/locale/src/{nl,it,vi}.json \
   /opt/nginxproxymanager/frontend/src/locale/lang/

ls -la /opt/ng*/frontend/src/locale:

root@nginxproxymanager:/opt/nginxproxymanager/frontend/src/locale# ls -la /opt/ng*/frontend/src/locale 
/opt/nginx-proxy-manager-2.13.1/frontend/src/locale:
total 36
drwxrwxr-x  5 root root 4096 Nov  5 06:40 .
drwxrwxr-x 11 root root 4096 Nov  5 06:40 ..
-rw-rw-r--  1 root root  313 Nov  5 06:40 DateTimeFormat.ts
-rw-rw-r--  1 root root 2045 Nov  5 06:40 IntlProvider.tsx
-rw-rw-r--  1 root root 1326 Nov  5 06:40 README.md
-rw-rw-r--  1 root root   66 Nov  5 06:40 index.ts
drwxrwxr-x  2 root root 4096 Nov  5 06:40 lang
drwxrwxr-x  2 root root 4096 Nov  5 06:40 scripts
drwxrwxr-x  3 root root 4096 Nov  5 06:40 src

/opt/nginxproxymanager/frontend/src/locale:
total 44
drwxr-xr-x  5 root root 4096 Nov  9 16:28 .
drwxr-xr-x 11 root root 4096 Nov  5 11:22 ..
-rw-r--r--  1 root root  313 Nov  5 11:22 DateTimeFormat.ts
-rw-r--r--  1 root root 3291 Nov 18 13:48 IntlProvider.tsx
-rw-r--r--  1 root root 1366 Nov 18 13:48 README.md
-rw-r--r--  1 root root 2045 Nov 18 13:48 Utils.test.tsx
-rw-r--r--  1 root root 1223 Nov 18 13:48 Utils.ts
-rw-r--r--  1 root root   57 Nov 18 13:48 index.ts
drwxr-xr-x  2 root root 4096 Nov 18 14:09 lang
drwxr-xr-x  2 root root 4096 Nov  5 11:22 scripts
drwxr-xr-x  3 root root 4096 Nov 18 13:48 src
root@nginxproxymanager:/opt/nginxproxymanager/frontend/src/locale# 

cat IntlProvider.tsx

root@nginxproxymanager:/opt/nginxproxymanager/frontend/src/locale# cat IntlProvider.tsx 
import { createIntl, createIntlCache } from "react-intl";
import langDe from "./lang/de.json";
import langEn from "./lang/en.json";
import langEs from "./lang/es.json";
import langIt from "./lang/it.json";
import langJa from "./lang/ja.json";
import langList from "./lang/lang-list.json";
import langNl from "./lang/nl.json";
import langPl from "./lang/pl.json";
import langRu from "./lang/ru.json";
import langSk from "./lang/sk.json";
import langVi from "./lang/vi.json";
import langZh from "./lang/zh.json";

// first item of each array should be the language code,
// not the country code
// Remember when adding to this list, also update check-locales.js script
const localeOptions = [
        ["en", "en-US", langEn],
        ["de", "de-DE", langDe],
        ["es", "es-ES", langEs],
        ["ja", "ja-JP", langJa],
        ["it", "it-IT", langIt],
        ["nl", "nl-NL", langNl],
        ["pl", "pl-PL", langPl],
        ["ru", "ru-RU", langRu],
        ["sk", "sk-SK", langSk],
        ["vi", "vi-VN", langVi],
        ["zh", "zh-CN", langZh],
];

const loadMessages = (locale?: string): typeof langList & typeof langEn => {
        const thisLocale = (locale || "en").slice(0, 2);

        // ensure this lang exists in localeOptions above, otherwise fallback to en
        if (thisLocale === "en" || !localeOptions.some(([code]) => code === thisLocale)) {
                return Object.assign({}, langList, langEn);
        }

        return Object.assign({}, langList, langEn, localeOptions.find(([code]) => code === thisLocale)?.[2]);
};

const getFlagCodeForLocale = (locale?: string) => {
        const thisLocale = (locale || "en").slice(0, 2);

        // only add to this if your flag is different from the locale code
        const specialCases: Record<string, string> = {
                ja: "jp", // Japan
                zh: "cn", // China
        };

        if (specialCases[thisLocale]) {
                return specialCases[thisLocale].toUpperCase();
        }
        return thisLocale.toUpperCase();
};

const getLocale = (short = false) => {
        let loc = window.localStorage.getItem("locale");
        if (!loc) {
                loc = document.documentElement.lang;
        }
        if (short) {
                return loc.slice(0, 2);
        }
        // finally, fallback
        if (!loc) {
                loc = "en";
        }
        return loc;
};

const cache = createIntlCache();

const initialMessages = loadMessages(getLocale());
let intl = createIntl({ locale: getLocale(), messages: initialMessages }, cache);

const changeLocale = (locale: string): void => {
        const messages = loadMessages(locale);
        intl = createIntl({ locale, messages }, cache);
        window.localStorage.setItem("locale", locale);
        document.documentElement.lang = locale;
};

// This is a translation component that wraps the translation in a span with a data
// attribute so devs can inspect the element to see the translation ID
const T = ({
        id,
        data,
        tData,
}: {
        id: string;
        data?: Record<string, string | number | undefined>;
        tData?: Record<string, string>;
}) => {
        const translatedData: Record<string, string> = {};
        if (tData) {
                // iterate over tData and translate each value
                Object.entries(tData).forEach(([key, value]) => {
                        translatedData[key] = intl.formatMessage({ id: value });
                });
        }
        return (
                <span data-translation-id={id}>
                        {intl.formatMessage(
                                { id },
                                {
                                        ...data,
                                        ...translatedData,
                                },
                        )}
                </span>
        );
};

console.log("L:", localeOptions);

export { localeOptions, getFlagCodeForLocale, getLocale, createIntl, changeLocale, intl, T };
root@nginxproxymanager:/opt/nginxproxymanager/frontend/src/locale# 

[MickLesk]

can you test following?

change /root/.nginx* to another version
run update again,

check if the frontend work fine / all data exist?

[sammyke007]

Change it back to eg 2.13.4 and update?

[MickLesk]

yeah, all possible, you can enter x.x.x.x 😄 same effect

[sammyke007]

Failed with output:

    _   __      _               ____                           __  ___
   / | / /___ _(_)___  _  __   / __ \_________  _  ____  __   /  |/  /___ _____  ____ _____ ____  _____
  /  |/ / __ `/ / __ \| |/_/  / /_/ / ___/ __ \| |/_/ / / /  / /|_/ / __ `/ __ \/ __ `/ __ `/ _ \/ ___/
 / /|  / /_/ / / / / />  <   / ____/ /  / /_/ />  </ /_/ /  / /  / / /_/ / / / / /_/ / /_/ /  __/ /
/_/ |_/\__, /_/_/ /_/_/|_|  /_/   /_/   \____/_/|_|\__, /  /_/  /_/\__,_/_/ /_/\__,_/\__, /\___/_/
      /____/                                      /____/                            /____/

Hit:1 http://deb.debian.org/debian trixie InRelease
Hit:2 http://security.debian.org trixie-security InRelease
Hit:3 http://deb.debian.org/debian trixie-updates InRelease
Ign:4 https://deb.nodesource.com/node_22.x nodistro InRelease
Hit:5 http://openresty.org/package/debian bookworm InRelease
Ign:4 https://deb.nodesource.com/node_22.x nodistro InRelease
Ign:4 https://deb.nodesource.com/node_22.x nodistro InRelease
Err:4 https://deb.nodesource.com/node_22.x nodistro InRelease
  500  Internal Server Error [IP: 172.66.150.169 443]
24 packages can be upgraded. Run 'apt list --upgradable' to see them.
Warning: http://openresty.org/package/debian/dists/bookworm/InRelease: Policy will reject signature within a year, see --audit for details
Warning: Failed to fetch https://deb.nodesource.com/node_22.x/dists/nodistro/InRelease  500  Internal Server Error [IP: 172.66.150.169 443]
Warning: Some index files failed to download. They have been ignored, or old ones used instead.

changed 13 packages in 2s

28 packages are looking for funding
  run `npm fund` for details
  ✔️   Update Node.js 22
  ⏳   Updating yarn to latest version
changed 1 package in 668ms
  ✔️   Installed Node.js modules: yarn
  ✔️   Deployed: nginxproxymanager (2.13.5)
  ✔️   Stopped Services
  ✔️   Cleaned old files
  ✔️   Set up Environment
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @uiw/react-textarea-code-editor@3.1.1" has unmet peer dependency "@babel/runtime@>=7.10.0".
[4/4] Building fresh packages...
Done in 9.55s.
yarn run v1.22.22
$ tsc && vite build
src/locale/IntlProvider.tsx:2:20 - error TS2307: Cannot find module './lang/de.json' or its corresponding type declarations.

2 import langDe from "./lang/de.json";
                     ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:3:20 - error TS2307: Cannot find module './lang/en.json' or its corresponding type declarations.

3 import langEn from "./lang/en.json";
                     ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:4:20 - error TS2307: Cannot find module './lang/es.json' or its corresponding type declarations.

4 import langEs from "./lang/es.json";
                     ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:5:20 - error TS2307: Cannot find module './lang/it.json' or its corresponding type declarations.

5 import langIt from "./lang/it.json";
                     ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:6:20 - error TS2307: Cannot find module './lang/ja.json' or its corresponding type declarations.

6 import langJa from "./lang/ja.json";
                     ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:7:22 - error TS2307: Cannot find module './lang/lang-list.json' or its corresponding type declarations.

7 import langList from "./lang/lang-list.json";
                       ~~~~~~~~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:8:20 - error TS2307: Cannot find module './lang/nl.json' or its corresponding type declarations.

8 import langNl from "./lang/nl.json";
                     ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:9:20 - error TS2307: Cannot find module './lang/pl.json' or its corresponding type declarations.

9 import langPl from "./lang/pl.json";
                     ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:10:20 - error TS2307: Cannot find module './lang/ru.json' or its corresponding type declarations.

10 import langRu from "./lang/ru.json";
                      ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:11:20 - error TS2307: Cannot find module './lang/sk.json' or its corresponding type declarations.

11 import langSk from "./lang/sk.json";
                      ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:12:20 - error TS2307: Cannot find module './lang/vi.json' or its corresponding type declarations.

12 import langVi from "./lang/vi.json";
                      ~~~~~~~~~~~~~~~~

src/locale/IntlProvider.tsx:13:20 - error TS2307: Cannot find module './lang/zh.json' or its corresponding type declarations.

13 import langZh from "./lang/zh.json";
                      ~~~~~~~~~~~~~~~~


Found 12 errors in the same file, starting at: src/locale/IntlProvider.tsx:2

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[ERROR] in line 128: exit code 0: while executing command $STD yarn build

root@nginxproxymanager:/opt#

[MickLesk]

Okay same. Then its realy an "upstream" issue, because ive added an clean_install var, that remove the whole folder and deploy an new tarball

[sammyke007]

Ok, I'll try to get mine back up again now :-D

[MickLesk]

Thx 4 Help! So now we wait for feedback in npm-repo

[CrazyUs3r]

I find Next error after Re rename src to lang

✔️ Stopped Services
✔️ Cleaned old files
✔️ Set up Environment
yarn install v1.22.22 [1/4] Resolving packages...
success Already up-to-date. Done in 0.18s.
yarn run v1.22.22
$ tsc && vite build
src/locale/IntlProvider.tsx:76:46 - error TS2322: Type '{ "locale-en-US": { defaultMessage: string; }; "locale-es-ES": { defaultMessage: string; }; "locale-de-DE": { defaultMessage: string; }; "locale-ja-JP": { defaultMessage: string; }; "locale-ru-RU": { defaultMessage: string; }; ... 5 more ...; "locale-nl-NL": { ...; }; } & { ...; }' is not assignable to type 'Record<string, string> | Record<string, MessageFormatElement[]> | undefined'.
Type '{ "locale-en-US": { defaultMessage: string; }; "locale-es-ES": { defaultMessage: string; }; "locale-de-DE": { defaultMessage: string; }; "locale-ja-JP": { defaultMessage: string; }; "locale-ru-RU": { defaultMessage: string; }; ... 5 more ...; "locale-nl-NL": { ...; }; } & { ...; }' is not assignable to type 'Record<string, MessageFormatElement[]>'.
Property '"locale-en-US"' is incompatible with index signature.
Type '{ defaultMessage: string; }' is missing the following properties from type 'MessageFormatElement[]': length, pop, push, concat, and 29 more.

76 let intl = createIntl({ locale: getLocale(), messages: initialMessages }, cache);
~~~~~~~~

node_modules/@formatjs/intl/src/types.d.ts:38:5
38 messages: Record<MessageIds, string> | Record<MessageIds, MessageFormatElement[]>;
~~~~~~~~
The expected type comes from property 'messages' which is declared here on type 'IntlConfig'

src/locale/IntlProvider.tsx:80:30 - error TS2322: Type '{ "locale-en-US": { defaultMessage: string; }; "locale-es-ES": { defaultMessage: string; }; "locale-de-DE": { defaultMessage: string; }; "locale-ja-JP": { defaultMessage: string; }; "locale-ru-RU": { defaultMessage: string; }; ... 5 more ...; "locale-nl-NL": { ...; }; } & { ...; }' is not assignable to type 'Record<string, string> | Record<string, MessageFormatElement[]> | undefined'.
Type '{ "locale-en-US": { defaultMessage: string; }; "locale-es-ES": { defaultMessage: string; }; "locale-de-DE": { defaultMessage: string; }; "locale-ja-JP": { defaultMessage: string; }; "locale-ru-RU": { defaultMessage: string; }; ... 5 more ...; "locale-nl-NL": { ...; }; } & { ...; }' is not assignable to type 'Record<string, MessageFormatElement[]>'.
Property '"locale-en-US"' is incompatible with index signature.
Type '{ defaultMessage: string; }' is missing the following properties from type 'MessageFormatElement[]': length, pop, push, concat, and 29 more.

80 intl = createIntl({ locale, messages }, cache);
~~~~~~~~

node_modules/@formatjs/intl/src/types.d.ts:38:5
38 messages: Record<MessageIds, string> | Record<MessageIds, MessageFormatElement[]>;
~~~~~~~~
The expected type comes from property 'messages' which is declared here on type 'IntlConfig'

src/modals/HelpModal.tsx:8:29 - error TS2307: Cannot find module 'src/locale/src/HelpDoc' or its corresponding type declarations.

8 import { getHelpFile } from "src/locale/src/HelpDoc";
~~~~~~~~~~~~~~~~~~~~~~~~

Found 3 errors in 2 files.

Errors Files
2 src/locale/IntlProvider.tsx:76
1 src/modals/HelpModal.tsx:8
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[ERROR] in line 128: exit code 0: while executing command $STD yarn build

[peterchs]

Yes same error here after similar attempt to fix with an ln -s src to the missing lang dir.

Any way to easily rollback to 2.13.4? I dont have a snapshot :(