In unit tests now using localhost instead of empty string for host. Slight tweak to shutdown of tcp_io.hpp, shutdown incoming reads instead of both reads and writes.

Author: cliffg-softwarelibre

include/net_ip/detail/tcp_io.hpp

@@ -174,7 +174,7 @@ class tcp_io : public std::enable_shared_from_this<tcp_io> {
     }
     m_io_common.clear();
     std::error_code ec;
-    m_socket.shutdown(asio::ip::tcp::socket::shutdown_both, ec);
+    m_socket.shutdown(asio::ip::tcp::socket::shutdown_receive, ec);
     m_socket.close(ec); 
     // notify the acceptor or connector that this tcp_io object is closed
     m_notifier_cb(err, shared_from_this());
@@ -298,7 +298,7 @@ inline void tcp_io::start_write(const chops::const_shared_buffer& buf) {
 inline void tcp_io::handle_write(const std::error_code& err, std::size_t /* num_bytes */) {
   if (err) {
     // read pops first, so usually no error is needed in write handlers
-    // m_notifier_cb(err, shared_from_this());
+    close(err);
     return;
   }
   m_io_common.write_next_elem([this] (const chops::const_shared_buffer& buf) {

test/net_ip/detail/tcp_acceptor_test.cpp

@@ -60,7 +60,7 @@
 using namespace chops::test;
 
 const char* test_port = "30434";
-const char* test_host = "";
+const char* test_host = "localhost";
 constexpr int num_msgs = 50;
 
 

test/net_ip/detail/tcp_connector_test.cpp

@@ -60,7 +60,7 @@ using namespace chops::test;
 
 const char* test_port_var = "30777";
 const char* test_port_fixed = "30778";
-const char* test_host = "";
+const char* test_host = "localhost";
 constexpr int num_msgs = 50;
 constexpr std::chrono::milliseconds tout { 800 };
 

test/net_ip/detail/tcp_io_test.cpp

@@ -47,7 +47,7 @@
 using namespace chops::test;
 
 const char*   test_port = "30434";
-const char*   test_addr = "";
+const char*   test_addr = "localhost";
 constexpr int num_msgs = 50;
 
 // Catch test framework is not thread-safe, therefore all REQUIRE clauses must be in a single 
@@ -153,6 +153,7 @@ void perform_test (const vec_buf& var_msg_vec, const vec_buf& fixed_msg_vec,
   auto res = 
       chops::net::endpoints_resolver<asio::ip::tcp>(ioc).make_endpoints(true, test_addr, test_port);
   REQUIRE(res);
+
   asio::ip::tcp::acceptor acc(ioc, *(res->cbegin()));
 
   {

test/net_ip/net_ip_test.cpp

@@ -46,7 +46,7 @@
 using namespace chops::test;
 
 const char* tcp_test_port = "30465";
-const char* tcp_test_host = "";
+const char* tcp_test_host = "localhost";
 constexpr int num_msgs = 50;
 
 const char*   udp_test_addr = "127.0.0.1";