Fix #13356: FP resourceLeak with greater-than comparison (danmar#7047)

Author: ludviggunne

lib/checkleakautovar.cpp

@@ -57,7 +57,7 @@ static constexpr int NEW_ARRAY = -2;
 static constexpr int NEW = -1;
 
 static const std::array<std::pair<std::string, std::string>, 4> alloc_failed_conds {{{"==", "0"}, {"<", "0"}, {"==", "-1"}, {"<=", "-1"}}};
-static const std::array<std::pair<std::string, std::string>, 4> alloc_success_conds {{{"!=", "0"}, {">", "0"}, {"!=", "-1"}, {">=", "0"}}};
+static const std::array<std::pair<std::string, std::string>, 5> alloc_success_conds {{{"!=", "0"}, {">", "0"}, {"!=", "-1"}, {">=", "0"}, {">", "-1"}}};
 
 static bool isAutoDeallocType(const Type* type) {
     if (!type || !type->classScope)

test/testleakautovar.cpp

@@ -3425,6 +3425,7 @@ class TestLeakAutoVarPosix : public TestFixture {
         TEST_CASE(memleak_getline);
         TEST_CASE(deallocuse_fdopen);
         TEST_CASE(doublefree_fdopen); // #12781
+        TEST_CASE(memleak_open); // #13356
     }
 
     void memleak_getline() {
@@ -3466,6 +3467,17 @@ class TestLeakAutoVarPosix : public TestFixture {
               "}\n");
         ASSERT_EQUALS("", errout_str());
     }
+
+    void memleak_open() { // #13356
+        check("int f() {\n"
+              "    int fd = open(\"abc \", O_RDONLY);\n"
+              "    if (fd > -1) {\n"
+              "        return fd;\n"
+              "    }\n"
+              "    return -1;\n"
+              "}\n");
+        ASSERT_EQUALS("", errout_str());
+    }
 };
 
 REGISTER_TEST(TestLeakAutoVarPosix)