Partial fix for #12046 FN: containerOutOfBounds (temporary string passed to subfunction) (danmar#8083)

Co-authored-by: chrchr-github <noreply@github.com>

Author: chrchr-github

lib/valueflow.cpp

@@ -6706,13 +6706,15 @@ static void valueFlowContainerSize(const TokenList& tokenlist,
                 for (const ValueFlow::Value& value : values)
                     setTokenValue(tok, value, settings);
             }
-            else if (Token::Match(tok->previous(), ",|( {")) {
+            else if (Token::Match(tok->previous(), ",|( {|%str%")) {
                 int nArg{};
                 if (const Token* funcTok = getTokenArgumentFunction(tok, nArg)) {
                     if (const Function* func = funcTok->function()) {
                         if (const Variable* var = func->getArgumentVar(nArg)) {
                             if (var->valueType() && var->valueType()->container && var->valueType()->container->size_templateArgNo < 0) {
-                                std::vector<ValueFlow::Value> values = getInitListSize(tok, var->valueType(), settings, true);
+                                auto values = tok->tokType() == Token::Type::eString
+                                   ? std::vector<ValueFlow::Value>{makeContainerSizeValue(Token::getStrLength(tok))}
+                                   : getInitListSize(tok, var->valueType(), settings, true);
                                 ValueFlow::Value tokValue;
                                 tokValue.valueType = ValueFlow::Value::ValueType::TOK;
                                 tokValue.tokvalue = tok;

test/teststl.cpp

@@ -967,6 +967,11 @@ class TestStl : public TestFixture {
                     "}\n");
         ASSERT_EQUALS("[test.cpp:2:17]: error: Out of bounds access in expression 'v[0]' because 'v' is empty. [containerOutOfBounds]\n",
                       errout_str());
+
+        checkNormal("bool f(const std::string_view s) { return s[500] == 'x'; }\n" // #12046
+                    "bool g() { return f(\" \"); }\n");
+        ASSERT_EQUALS("[test.cpp:1:44]: error: Out of bounds access in 's[500]', if 's' size is 1 and '500' is 500 [containerOutOfBounds]\n",
+                      errout_str());
     }
 
     void outOfBoundsSymbolic()