Fix #13642 FP functionConst with reinterpret_cast of member address (danmar#7308)

Author: chrchr-github

lib/checkclass.cpp

@@ -2400,6 +2400,8 @@ bool CheckClass::checkConstFunc(const Scope *scope, const Function *func, Member
                                 !(argVar->valueType() && argVar->valueType()->isConst(argVar->valueType()->pointer)))) { // argument might be modified
                     const Token* arg = args[argIndex];
                     // Member variable given as parameter
+                    while (Token::simpleMatch(arg, "(") && arg->astOperand2())
+                        arg = arg->astOperand2();
                     const Token* varTok = previousBeforeAstLeftmostLeaf(arg);
                     if (!varTok)
                         return false;

test/testclass.cpp

@@ -190,6 +190,7 @@ class TestClass : public TestFixture {
         TEST_CASE(const95); // #13320 - do not warn about r-value ref method
         TEST_CASE(const96);
         TEST_CASE(const97);
+        TEST_CASE(const98);
 
         TEST_CASE(const_handleDefaultParameters);
         TEST_CASE(const_passThisToMemberOfOtherClass);
@@ -6786,6 +6787,56 @@ class TestClass : public TestFixture {
                       errout_str());
     }
 
+    void const98() { // #13642
+        checkConst("enum E {\n"
+                   "    E0,\n"
+                   "    E1\n"
+                   "};\n"
+                   "void set(int* p) {\n"
+                   "    *p = 1;\n"
+                   "}\n"
+                   "struct S {\n"
+                   "    E e;\n"
+                   "    void f() {\n"
+                   "        set(reinterpret_cast<int*>(&e));\n"
+                   "    }\n"
+                   "    void g() {\n"
+                   "        set(reinterpret_cast<int*>(reinterpret_cast<void*>(&e)));\n"
+                   "    }\n"
+                   "    void h() {\n"
+                   "        set((int*)(&e));\n"
+                   "    }\n"
+                   "};\n");
+        ASSERT_EQUALS("", errout_str());
+
+        checkConst("enum E {\n"
+                   "    E0,\n"
+                   "    E1\n"
+                   "};\n"
+                   "void set1(int i, int* p) {\n"
+                   "    *p = i;\n"
+                   "}\n"
+                   "void set2(int* p, int i) {\n"
+                   "    *p = i;\n"
+                   "}\n"
+                   "struct S {\n"
+                   "    E e;\n"
+                   "    void f1() {\n"
+                   "        set1(1, reinterpret_cast<int*>(&e));\n"
+                   "    }\n"
+                   "    void f2() {\n"
+                   "        set2(reinterpret_cast<int*>(&e), 1);\n"
+                   "    }\n"
+                   "    void g1() {\n"
+                   "        set1(1, reinterpret_cast<int*>(reinterpret_cast<void*>(&e)));\n"
+                   "    }\n"
+                   "    void g2() {\n"
+                   "        set2(reinterpret_cast<int*>(reinterpret_cast<void*>(&e)), 1);\n"
+                   "    }\n"
+                   "};\n");
+        ASSERT_EQUALS("", errout_str());
+    }
+
     void const_handleDefaultParameters() {
         checkConst("struct Foo {\n"
                    "    void foo1(int i, int j = 0) {\n"