Fixes issue #54. Always use the main (UI) thread to show the console.

Author: kwin

com.googlecode.cppcheclipse.ui/src/com/googlecode/cppcheclipse/ui/Builder.java

@@ -185,7 +185,7 @@ public void run() {
 					// errors, therefore throw them as CoreExceptions
 					IStatus status = new Status(IStatus.ERROR,
 							CppcheclipsePlugin.getId(),
-							"Could not initialize cppcheck", e2); //$NON-NLS-1$
+							"Could not initialize cppcheck for project "+ currentProject.getName(), e2); //$NON-NLS-1$
 					throw new CoreException(status);
 				}
 			}

com.googlecode.cppcheclipse.ui/src/com/googlecode/cppcheclipse/ui/Console.java

@@ -3,9 +3,13 @@
 import java.io.IOException;
 import java.io.OutputStream;
 
+import org.eclipse.jface.dialogs.MessageDialog;
+import org.eclipse.jface.preference.PreferenceDialog;
 import org.eclipse.swt.SWT;
 import org.eclipse.swt.widgets.Display;
+import org.eclipse.swt.widgets.Shell;
 import org.eclipse.ui.IWorkbenchPage;
+import org.eclipse.ui.IWorkbenchWindow;
 import org.eclipse.ui.PartInitException;
 import org.eclipse.ui.PlatformUI;
 import org.eclipse.ui.console.ConsolePlugin;
@@ -15,6 +19,10 @@
 import org.eclipse.ui.console.IConsoleView;
 import org.eclipse.ui.console.MessageConsole;
 import org.eclipse.ui.console.MessageConsoleStream;
+import org.eclipse.ui.dialogs.PreferencesUtil;
+
+import com.googlecode.cppcheclipse.core.CppcheclipsePlugin;
+import com.googlecode.cppcheclipse.ui.preferences.BinaryPathPreferencePage;
 
 /**
  * Wrapper around a console window, which can output an existing InputSteam.
@@ -111,11 +119,30 @@ public void println(String line) throws IOException {
 	 * 
 	 * @see com.googlecode.cppcheclipse.command.IConsole#show()
 	 */
-	public void show() throws PartInitException {
-		IWorkbenchPage page = PlatformUI.getWorkbench()
-				.getActiveWorkbenchWindow().getActivePage();
-		String id = IConsoleConstants.ID_CONSOLE_VIEW;
-		IConsoleView view = (IConsoleView) page.showView(id);
-		view.display(messageConsole);
+	public void show() {
+		
+		Runnable runnable = new Runnable() {
+			public void run() {
+				// this should only be called from GUI thread
+				IWorkbenchWindow window = PlatformUI.getWorkbench().getActiveWorkbenchWindow();
+				if (window == null) {
+					CppcheclipsePlugin.logError("Could not show console because there is no active workbench window");
+					return;
+				}
+				IWorkbenchPage page = window.getActivePage();
+				if (page == null) {
+					CppcheclipsePlugin.logError("Could not show console because there is no active page");
+					return;
+				}
+				try {
+					IConsoleView view = (IConsoleView) page.showView(IConsoleConstants.ID_CONSOLE_VIEW);
+					view.display(messageConsole);
+				} catch (PartInitException e) {
+					CppcheclipsePlugin.logError("Could not show console", e);
+				}
+				
+			}
+		};
+		Display.getDefault().asyncExec(runnable);
 	}
 }

com.googlecode.cppcheclipse.ui/src/com/googlecode/cppcheclipse/ui/commands/RunCodeAnalysis.java

@@ -29,12 +29,8 @@ protected void runResource(IResource resource,
 					CppcheclipsePlugin.showError(Messages.bind(
 							Messages.RunCodeAnalysis_Error, resource.getName()),
 							e1);
-					try {
-						// show console in case of exceptions
-						Console.getInstance().show();
-					} catch (PartInitException e) {
-						CppcheclipsePlugin.showError("Could not show console", e);
-					}
+					// show console in case of exceptions
+					Console.getInstance().show();
 				}
 			}
 		}