Fixes issue #57. Pass filenames to cppcheck via stdin rather than via arguments to circumvent the process argument limitation

Author: kwin

com.googlecode.cppcheclipse.core/src/com/googlecode/cppcheclipse/core/command/AbstractCppcheckCommand.java

@@ -6,6 +6,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
+import java.io.OutputStream;
 import java.io.StringReader;
 import java.io.UnsupportedEncodingException;
 import java.text.SimpleDateFormat;
@@ -48,6 +49,7 @@ public abstract class AbstractCppcheckCommand {
 
 	protected final LineFilterOutputStream processStdOut;
 	protected final LineFilterOutputStream processStdErr;
+	protected InputStream processStdIn;
 
 	public AbstractCppcheckCommand(IConsole console, String[] defaultArguments,
 			long timeout, String binaryPath) {
@@ -71,8 +73,7 @@ public AbstractCppcheckCommand(IConsole console, String[] defaultArguments,
 				console.getConsoleOutputStream(false)), DEFAULT_CHARSET);
 		processStdErr = new LineFilterOutputStream(new TeeOutputStream(err,
 				console.getConsoleOutputStream(true)), DEFAULT_CHARSET);
-		executor.setStreamHandler(new PumpStreamHandler(processStdOut,
-				processStdErr));
+		
 	}
 
 	public AbstractCppcheckCommand(IConsole console, String[] defaultArguments, String binaryPath) {
@@ -89,6 +90,10 @@ public AbstractCppcheckCommand(IConsole console, String[] defaultArguments, Stri
 	public BufferedReader getErrorReader() throws UnsupportedEncodingException {
 		return new BufferedReader(new StringReader(getError()));
 	}
+	
+	public void setProcessInputStream(InputStream inputStream) {
+		processStdIn = inputStream;
+	}
 
 	/**
 	 * The type is confusing but this gives the standard output of the process
@@ -212,6 +217,8 @@ protected CppcheckProcessResultHandler runInternal(
 		if (singleArgumentsAfter != null) {
 			cmdLine.addArguments(singleArgumentsAfter, false);
 		}
+		
+		executor.setStreamHandler(new PumpStreamHandler(processStdOut, processStdErr, processStdIn));
 
 		CppcheckProcessResultHandler resultHandler = new CppcheckProcessResultHandler();
 

com.googlecode.cppcheclipse.core/src/com/googlecode/cppcheclipse/core/command/CppcheckCommand.java

@@ -1,6 +1,7 @@
 package com.googlecode.cppcheclipse.core.command;
 
 import java.io.BufferedReader;
+import java.io.ByteArrayInputStream;
 import java.io.File;
 import java.io.IOException;
 import java.net.URISyntaxException;
@@ -221,11 +222,16 @@ public void run(Checker checker, IProgressReporter progressReporter,
 			filenames.add(FileUtils.relativizeFile(projectFolder, absoluteFile)
 					.toString());
 		}
-
+		
+		// read filenames from stdin (separated by "\n")
+		String input = Joiner.on("\n").join(filenames);
+		setProcessInputStream(new ByteArrayInputStream(input.getBytes(DEFAULT_CHARSET)));
+		arguments.add("--file-list=-");
+		
 		setWorkingDirectory(projectFolder);
 		CppcheckProcessResultHandler resultHandler = runInternal(
 				arguments.toArray(new String[0]), advancedArguments,
-				filenames.toArray(new String[0]));
+				null);
 
 		List<Problem> problems = new LinkedList<Problem>();
 		try {