Changed InsertionOrderSet to not reverse the passed in List, matching what its name should do.

Author: cheeseng

scalatest-test/src/test/scala/org/scalatest/InsertionOrderSetSpec.scala

@@ -30,13 +30,11 @@ class InsertionOrderSetSpec extends FunSpec with Matchers {
       InsertionOrderSet(List(1, 2, 3)) + 4 shouldBe InsertionOrderSet(List(1, 2, 3, 4))
     }
     it("should return Iterator that iterates elements in the order they were inserted") {
-      pendingUntilFixed {
-        val set = InsertionOrderSet(List(2, 1, 3))
-        val itr = set.iterator
-        itr.next shouldBe 2
-        itr.next shouldBe 1
-        itr.next shouldBe 3
-      }
+      val set = InsertionOrderSet(List(2, 1, 3))
+      val itr = set.iterator
+      itr.next shouldBe 2
+      itr.next shouldBe 1
+      itr.next shouldBe 3
     }
     it("should return true when contains is called with element it contains") {
       val set = InsertionOrderSet(List(2, 1, 3))

scalatest/src/main/scala/org/scalatest/AsyncEngine.scala

@@ -751,7 +751,7 @@ private[scalatest] sealed abstract class AsyncSuperEngine[T](concurrentBundleMod
 
     val testLeaf = TestLeaf(currentBranch, testName, testText, testFun, testLocation, Some(pos), duration)
     testsMap += (testName -> testLeaf)
-    testNamesList ::= testName
+    testNamesList = testNamesList :+ testName
     currentBranch.subNodes ::= testLeaf
 
     val tagNames = Set[String]() ++ testTags.map(_.name)

scalatest/src/main/scala/org/scalatest/Engine.scala

@@ -673,7 +673,7 @@ private[scalatest] sealed abstract class SuperEngine[T](concurrentBundleModMessa
 
     val testLeaf = TestLeaf(currentBranch, testName, testText, testFun, testLocation, pos, duration, informer)
     testsMap += (testName -> testLeaf)
-    testNamesList ::= testName
+    testNamesList = testNamesList :+ testName
     currentBranch.subNodes ::= testLeaf
 
     val tagNames = Set[String]() ++ testTags.map(_.name)

scalatest/src/main/scala/org/scalatest/InsertionOrderSet.scala

@@ -17,7 +17,7 @@ package org.scalatest
 
 private[scalatest] class InsertionOrderSet[A](elements: List[A]) extends Set[A] {
 
-  val list = elements.distinct.reverse
+  val list = elements.distinct
 
   def contains(key: A): Boolean = list.contains(key)
   def iterator: Iterator[A] = list.iterator