From f2241b823d8a9738fac9746ebb7ae78953fa2bb6 Mon Sep 17 00:00:00 2001
From: Brian Ojeda <9335829+sgtoj@users.noreply.github.com>
Date: Tue, 2 Dec 2025 12:29:03 -0500
Subject: [PATCH] feat: create bucket by default when bucket is enabled

---
 examples/complete/main.tf      | 1 -
 examples/complete/variables.tf | 5 -----
 variables.tf                   | 2 +-
 3 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/examples/complete/main.tf b/examples/complete/main.tf
index 92eb831..b97ff14 100644
--- a/examples/complete/main.tf
+++ b/examples/complete/main.tf
@@ -41,7 +41,6 @@ module "securityhub_bot" {
   rules_s3_bucket = {
     enabled = true
     create  = true
-    name    = var.rules_s3_bucket
     prefix  = "securityhub-rules/"
   }
 
diff --git a/examples/complete/variables.tf b/examples/complete/variables.tf
index 18186b8..ab765ab 100644
--- a/examples/complete/variables.tf
+++ b/examples/complete/variables.tf
@@ -16,11 +16,6 @@ variable "stage" {
   default     = ""
 }
 
-variable "rules_s3_bucket" {
-  description = "S3 bucket containing automation rules"
-  type        = string
-}
-
 variable "slack_bot_token" {
   description = "Slack bot token (requires chat:write scope)"
   type        = string
diff --git a/variables.tf b/variables.tf
index 814b053..e2c054c 100644
--- a/variables.tf
+++ b/variables.tf
@@ -98,7 +98,7 @@ variable "rules_s3_bucket" {
   description = "S3 bucket configuration for storing automation rules. Set create=true to create a new bucket, or provide an existing bucket name."
   type = object({
     enabled = optional(bool, false)
-    create  = optional(bool, false)
+    create  = optional(bool, true)
     name    = optional(string)
     prefix  = optional(string, "rules/")
   })