Fixed release not reseting the pointer to null

cschreib · cschreib · commit 06e809a9aa71 · 2021-11-04T19:23:03.000Z
diff --git a/include/oup/observable_unique_ptr.hpp b/include/oup/observable_unique_ptr.hpp
@@ -302,11 +302,14 @@ class observable_unique_ptr {
     /** \return A pointer to the un-managed object
     */
     T* release() noexcept {
+        T* old_ptr = pointer;
         if (pointer) {
             pop_ref_();
+            block = nullptr;
+            pointer = nullptr;
         }
 
-        return pointer;
+        return old_ptr;
     }
 
     /// Get a non-owning raw pointer to the pointed object, or nullptr if deleted.

Original file line number	Diff line number	Diff line change
`@@ -302,11 +302,14 @@ class observable_unique_ptr {`
`302`	`302`	`/** \return A pointer to the un-managed object`
`303`	`303`	`*/`
`304`	`304`	`T* release() noexcept {`
	`305`	`+ T* old_ptr = pointer;`
`305`	`306`	`if (pointer) {`
`306`	`307`	`pop_ref_();`
	`308`	`+ block = nullptr;`
	`309`	`+ pointer = nullptr;`
`307`	`310`	`}`
`308`	`311`
`309`		`- return pointer;`
	`312`	`+ return old_ptr;`
`310`	`313`	`}`
`311`	`314`
`312`	`315`	`/// Get a non-owning raw pointer to the pointed object, or nullptr if deleted.`