controller: watch for VAs silently to optimize lookups

This patch adds a silent watch on VolumeAttachment objects
to avoid unexpected memory consumption due to `List` calls.

It is okay to setup a watch in two places as the Informer is shared
and managed by the Manager.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>

Author: black-dragon74

internal/controller/csiaddons/encryptionkeyrotationjob_controller.go

@@ -24,6 +24,7 @@ import (
 
 	csiaddonsv1alpha1 "github.com/csi-addons/kubernetes-csi-addons/api/csiaddons/v1alpha1"
 	"github.com/csi-addons/kubernetes-csi-addons/internal/connection"
+	"github.com/csi-addons/kubernetes-csi-addons/internal/controller/utils"
 	"github.com/csi-addons/kubernetes-csi-addons/internal/proto"
 	"github.com/csi-addons/kubernetes-csi-addons/internal/util"
 	"github.com/csi-addons/spec/lib/go/identity"
@@ -38,8 +39,10 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/types"
 	ctrl "sigs.k8s.io/controller-runtime"
+	"sigs.k8s.io/controller-runtime/pkg/builder"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/controller"
+	"sigs.k8s.io/controller-runtime/pkg/handler"
 	"sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/controller-runtime/pkg/predicate"
 )
@@ -333,6 +336,12 @@ func (r *EncryptionKeyRotationJobReconciler) SetupWithManager(mgr ctrl.Manager,
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&csiaddonsv1alpha1.EncryptionKeyRotationJob{}).
 		WithEventFilter(predicate.GenerationChangedPredicate{}).
+		// This is to avoid "stop-the-world" events and wait for cache sync when we list VA
+		Watches(
+			&scv1.VolumeAttachment{},
+			&handler.EnqueueRequestForObject{},
+			builder.WithPredicates(utils.SilentPredicate()),
+		).
 		WithOptions(ctrlOptions).
 		Complete(r)
 }

internal/controller/csiaddons/reclaimspacejob_controller.go

@@ -25,6 +25,7 @@ import (
 
 	csiaddonsv1alpha1 "github.com/csi-addons/kubernetes-csi-addons/api/csiaddons/v1alpha1"
 	"github.com/csi-addons/kubernetes-csi-addons/internal/connection"
+	"github.com/csi-addons/kubernetes-csi-addons/internal/controller/utils"
 	"github.com/csi-addons/kubernetes-csi-addons/internal/proto"
 	"github.com/csi-addons/kubernetes-csi-addons/internal/util"
 
@@ -40,8 +41,10 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/types"
 	ctrl "sigs.k8s.io/controller-runtime"
+	"sigs.k8s.io/controller-runtime/pkg/builder"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/controller"
+	"sigs.k8s.io/controller-runtime/pkg/handler"
 	"sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/controller-runtime/pkg/predicate"
 )
@@ -164,6 +167,12 @@ func (r *ReclaimSpaceJobReconciler) SetupWithManager(mgr ctrl.Manager, ctrlOptio
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&csiaddonsv1alpha1.ReclaimSpaceJob{}).
 		WithEventFilter(predicate.GenerationChangedPredicate{}).
+		// This is to avoid "stop-the-world" events and wait for cache sync when we list VA
+		Watches(
+			&scv1.VolumeAttachment{},
+			&handler.EnqueueRequestForObject{},
+			builder.WithPredicates(utils.SilentPredicate()),
+		).
 		WithOptions(ctrlOptions).
 		Complete(r)
 }