Merge pull request #50 from cybercog/refactor/remove-helper-mutator-methods

Remove attribute mutator helper methods

Author: antonkomarev

CHANGELOG.md

@@ -18,6 +18,7 @@ All notable changes to `laravel-eloquent-flag` will be documented in this file.
 
 - Dropped PHP 5.6, 7.0 support
 - Dropped Laravel 5.2, 5.3, 5.4, 5.5, 5.6, 5.7 support
+- Removed attribute mutator `set*` & `unset*` methods from all helper classes
 
 ## [4.0.0] - 2018-09-09
 

src/Traits/Classic/HasAcceptedAtHelpers.php

@@ -22,30 +22,6 @@ public function initializeHasAcceptedAtHelpers(): void
         $this->dates[] = 'accepted_at';
     }
 
-    /**
-     * Set accepted flag.
-     *
-     * @return static
-     */
-    public function setAcceptedFlag()
-    {
-        $this->setAttribute('accepted_at', Date::now());
-
-        return $this;
-    }
-
-    /**
-     * Unset accepted flag.
-     *
-     * @return static
-     */
-    public function unsetAcceptedFlag()
-    {
-        $this->setAttribute('accepted_at', null);
-
-        return $this;
-    }
-
     /**
      * If entity is accepted.
      *
@@ -73,7 +49,8 @@ public function isRejected(): bool
      */
     public function accept(): void
     {
-        $this->setAcceptedFlag()->save();
+        $this->setAttribute('accepted_at', Date::now());
+        $this->save();
 
         $this->fireModelEvent('accepted', false);
     }
@@ -85,7 +62,8 @@ public function accept(): void
      */
     public function reject(): void
     {
-        $this->unsetAcceptedFlag()->save();
+        $this->setAttribute('accepted_at', null);
+        $this->save();
 
         $this->fireModelEvent('rejected', false);
     }

src/Traits/Classic/HasAcceptedFlagHelpers.php

@@ -20,30 +20,6 @@ public function initializeHasAcceptedFlagHelpers(): void
         $this->casts['is_accepted'] = 'boolean';
     }
 
-    /**
-     * Set accepted flag.
-     *
-     * @return static
-     */
-    public function setAcceptedFlag()
-    {
-        $this->setAttribute('is_accepted', true);
-
-        return $this;
-    }
-
-    /**
-     * Unset accepted flag.
-     *
-     * @return static
-     */
-    public function unsetAcceptedFlag()
-    {
-        $this->setAttribute('is_accepted', false);
-
-        return $this;
-    }
-
     /**
      * If entity is accepted.
      *
@@ -71,7 +47,8 @@ public function isRejected(): bool
      */
     public function accept(): void
     {
-        $this->setAcceptedFlag()->save();
+        $this->setAttribute('is_accepted', true);
+        $this->save();
 
         $this->fireModelEvent('accepted', false);
     }
@@ -83,7 +60,8 @@ public function accept(): void
      */
     public function reject(): void
     {
-        $this->unsetAcceptedFlag()->save();
+        $this->setAttribute('is_accepted', false);
+        $this->save();
 
         $this->fireModelEvent('rejected', false);
     }

src/Traits/Classic/HasActiveFlagHelpers.php

@@ -20,30 +20,6 @@ public function initializeHasActiveFlagHelpers(): void
         $this->casts['is_active'] = 'boolean';
     }
 
-    /**
-     * Set active flag.
-     *
-     * @return static
-     */
-    public function setActivatedFlag()
-    {
-        $this->setAttribute('is_active', true);
-
-        return $this;
-    }
-
-    /**
-     * Unset active flag.
-     *
-     * @return static
-     */
-    public function unsetActivatedFlag()
-    {
-        $this->setAttribute('is_active', false);
-
-        return $this;
-    }
-
     /**
      * If entity is activated.
      *
@@ -71,7 +47,8 @@ public function isDeactivated(): bool
      */
     public function activate(): void
     {
-        $this->setActivatedFlag()->save();
+        $this->setAttribute('is_active', true);
+        $this->save();
 
         $this->fireModelEvent('activated', false);
     }
@@ -83,7 +60,8 @@ public function activate(): void
      */
     public function deactivate(): void
     {
-        $this->unsetActivatedFlag()->save();
+        $this->save();
+        $this->setAttribute('is_active', false);
 
         $this->fireModelEvent('deactivated', false);
     }

src/Traits/Classic/HasApprovedAtHelpers.php

@@ -22,30 +22,6 @@ public function initializeHasApprovedAtHelpers(): void
         $this->dates[] = 'approved_at';
     }
 
-    /**
-     * Set approved flag.
-     *
-     * @return static
-     */
-    public function setApprovedFlag()
-    {
-        $this->setAttribute('approved_at', Date::now());
-
-        return $this;
-    }
-
-    /**
-     * Unset approved flag.
-     *
-     * @return static
-     */
-    public function unsetApprovedFlag()
-    {
-        $this->setAttribute('approved_at', null);
-
-        return $this;
-    }
-
     /**
      * If entity is approved.
      *
@@ -73,7 +49,8 @@ public function isDisapproved(): bool
      */
     public function approve(): void
     {
-        $this->setApprovedFlag()->save();
+        $this->setAttribute('approved_at', Date::now());
+        $this->save();
 
         $this->fireModelEvent('approved', false);
     }
@@ -85,7 +62,8 @@ public function approve(): void
      */
     public function disapprove(): void
     {
-        $this->unsetApprovedFlag()->save();
+        $this->setAttribute('approved_at', null);
+        $this->save();
 
         $this->fireModelEvent('disapproved', false);
     }

src/Traits/Classic/HasApprovedFlagHelpers.php

@@ -20,30 +20,6 @@ public function initializeHasApprovedFlagHelpers(): void
         $this->casts['is_approved'] = 'boolean';
     }
 
-    /**
-     * Set approved flag.
-     *
-     * @return static
-     */
-    public function setApprovedFlag()
-    {
-        $this->setAttribute('is_approved', true);
-
-        return $this;
-    }
-
-    /**
-     * Unset approved flag.
-     *
-     * @return static
-     */
-    public function unsetApprovedFlag()
-    {
-        $this->setAttribute('is_approved', false);
-
-        return $this;
-    }
-
     /**
      * If entity is approved.
      *
@@ -71,7 +47,8 @@ public function isDisapproved(): bool
      */
     public function approve(): void
     {
-        $this->setApprovedFlag()->save();
+        $this->setAttribute('is_approved', true);
+        $this->save();
 
         $this->fireModelEvent('approved', false);
     }
@@ -83,7 +60,8 @@ public function approve(): void
      */
     public function disapprove(): void
     {
-        $this->unsetApprovedFlag()->save();
+        $this->setAttribute('is_approved', false);
+        $this->save();
 
         $this->fireModelEvent('disapproved', false);
     }

src/Traits/Classic/HasInvitedAtHelpers.php

@@ -22,30 +22,6 @@ public function initializeHasInvitedAtHelpers(): void
         $this->dates[] = 'invited_at';
     }
 
-    /**
-     * Set invited flag.
-     *
-     * @return static
-     */
-    public function setInvitedFlag()
-    {
-        $this->setAttribute('invited_at', Date::now());
-
-        return $this;
-    }
-
-    /**
-     * Unset invited flag.
-     *
-     * @return static
-     */
-    public function unsetInvitedFlag()
-    {
-        $this->setAttribute('invited_at', null);
-
-        return $this;
-    }
-
     /**
      * If entity is invited.
      *
@@ -73,7 +49,8 @@ public function isUninvited(): bool
      */
     public function invite(): void
     {
-        $this->setInvitedFlag()->save();
+        $this->setAttribute('invited_at', Date::now());
+        $this->save();
 
         $this->fireModelEvent('invited', false);
     }
@@ -85,7 +62,8 @@ public function invite(): void
      */
     public function uninvite(): void
     {
-        $this->unsetInvitedFlag()->save();
+        $this->setAttribute('invited_at', null);
+        $this->save();
 
         $this->fireModelEvent('uninvited', false);
     }

src/Traits/Classic/HasInvitedFlagHelpers.php

@@ -20,30 +20,6 @@ public function initializeHasInvitedFlagHelpers(): void
         $this->casts['is_invited'] = 'boolean';
     }
 
-    /**
-     * Set invited flag.
-     *
-     * @return static
-     */
-    public function setInvitedFlag()
-    {
-        $this->setAttribute('is_invited', true);
-
-        return $this;
-    }
-
-    /**
-     * Unset invited flag.
-     *
-     * @return static
-     */
-    public function unsetInvitedFlag()
-    {
-        $this->setAttribute('is_invited', false);
-
-        return $this;
-    }
-
     /**
      * If entity is invited.
      *
@@ -71,7 +47,8 @@ public function isUninvited(): bool
      */
     public function invite(): void
     {
-        $this->setInvitedFlag()->save();
+        $this->setAttribute('is_invited', true);
+        $this->save();
 
         $this->fireModelEvent('invited', false);
     }
@@ -83,7 +60,8 @@ public function invite(): void
      */
     public function uninvite(): void
     {
-        $this->unsetInvitedFlag()->save();
+        $this->setAttribute('is_invited', false);
+        $this->save();
 
         $this->fireModelEvent('uninvited', false);
     }