Avoid shadowing of an existing variable.

Antonin Houska · Antonin Houska · commit b50e1846ec81 · 2024-06-26T16:51:01.000+02:00
diff --git a/pg_squeeze.c b/pg_squeeze.c
@@ -2191,14 +2191,13 @@ perform_initial_load(Relation rel_src, RangeVar *cluster_idx_rv,
 			{
 				HeapTuple	tup_orig = tup_in;
 				TupleDesc	tup_desc = RelationGetDescr(rel_src);
-				int			i;
 
 				heap_deform_tuple(tup_in, tup_desc, values, isnull);
 
-				for (i = 0; i < tup_desc->natts; i++)
+				for (int j = 0; j < tup_desc->natts; j++)
 				{
-					if (TupleDescAttr(tup_desc, i)->attisdropped)
-						isnull[i] = true;
+					if (TupleDescAttr(tup_desc, j)->attisdropped)
+						isnull[j] = true;
 				}
 
 				tup_in = heap_form_tuple(tup_desc, values, isnull);

Original file line number	Diff line number	Diff line change
`@@ -2191,14 +2191,13 @@ perform_initial_load(Relation rel_src, RangeVar *cluster_idx_rv,`
`2191`	`2191`	`{`
`2192`	`2192`	`HeapTuple tup_orig = tup_in;`
`2193`	`2193`	`TupleDesc tup_desc = RelationGetDescr(rel_src);`
`2194`		`- int i;`
`2195`	`2194`
`2196`	`2195`	`heap_deform_tuple(tup_in, tup_desc, values, isnull);`
`2197`	`2196`
`2198`		`- for (i = 0; i < tup_desc->natts; i++)`
	`2197`	`+ for (int j = 0; j < tup_desc->natts; j++)`
`2199`	`2198`	`{`
`2200`		`- if (TupleDescAttr(tup_desc, i)->attisdropped)`
`2201`		`- isnull[i] = true;`
	`2199`	`+ if (TupleDescAttr(tup_desc, j)->attisdropped)`
	`2200`	`+ isnull[j] = true;`
`2202`	`2201`	`}`
`2203`	`2202`
`2204`	`2203`	`tup_in = heap_form_tuple(tup_desc, values, isnull);`