-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore(config): replace Bluebird usage with native Promises (#33032) #33041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
chore(config): replace Bluebird usage with native Promises (#33032) #33041
Conversation
|
|
Hi @jennifer-shehane , This is my first ever PR in open source, and I’ve been working on this issue. The ESLint issues are fixed, and Bluebird has been replaced with native Promises/async-await in packages/config/src/project/utils.ts. CI is running the remaining checks. Please guide me if I’ve done anything incorrectly — I’m happy to learn and improve. Thanks a lot! |
|
@tanu9979 I'll help get the tests running so we can see what's impacted. Right now there is a lint error. |
|
I’ve pushed the fixes for the two lint errors you pointed out — the required blank lines have been added and the file should now pass the padding-line-between-statements rule. Let me know if anything else needs adjustment. Thanks for the guidance! |
|
@tanu9979 There's still some linting errors. You should be able to see these errors by running |
|
@jennifer-shehane |
|
Hello |
97b879f to
d9a4d36
Compare
|
@tanu9979 I'm planning on reviewing, I had another change that I didn't want to conflict with this first. |
|
@jennifer-shehane |
|
@tanu9979 Nothing more needing on your side at the moment. |
jennifer-shehane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tanu9979 This looks good. Thanks!
- I added some extra test coverage and confirmed it all passes with the old code + refactored code.
- I also cleaned up the naming of a few things since the original code didn't have the best flow to follow to begin with.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Refactors support file resolution to native async/await, adds symlink correction logic, and updates tests accordingly.
setSupportFileAndFolderfrom Bluebird chains to native async/await with clearer debug output.require.resolveviacheckIfResolveChangedRootFolder.correctSymlinkedPathto switch back to original (symlinked) path and verify viafs.pathExists.MODULE_NOT_FOUNDwithdiscoverModuleFileand setsupportFolderaccordingly.fs-extra.pathExistsandresolveModule.correctSymlinkedPathand symlink resolution scenarios insetSupportFileAndFolder.Written by Cursor Bugbot for commit 0eb084b. This will update automatically on new commits. Configure here.