Skip to content

Conversation

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 2, 2025

Additional details

Surfaced via a knip check yarn health-check - went through and cleaned up deps from frontend packages.

Steps to test

How has the user experience changed?

PR Tasks


Note

Cleans up unused devDependencies across app/frontend-shared/launchpad, adds missing runtime deps, updates knip entries/ignores, bumps some versions, and tweaks CI branch filter and cache.

  • Frontend packages:
    • packages/app: Remove unused deps (e.g., Vite Vue plugins, classnames, engine.io-client, graphql-tag, etc.); add component-emitter; keep vue-tsc; adjust Vite optimizeDeps (drop javascript-time-ago).
    • packages/frontend-shared: Add runtime deps gravatar, javascript-time-ago; prune dev deps (e.g., axe-core, fuzzysort, graphql-relay, graphql-tag); add vite-plugin-package-config.
    • packages/launchpad: Prune unused deps/plugins (testing/Vite-related); add tailwindcss, vue-toastification.
    • packages/data-context: Update chokidar to 3.6.0, bump fs-extra to 9.1.0, remove duplicate devDeps.
    • cli: Minor devDeps cleanup (remove cross-env).
  • Tooling/config:
    • knip.json: Expand entry/project globs for app/frontend-shared/launchpad; add new ignores and ignoreDependencies entries; small path adjustments.
    • yarn.lock: Prune entries tied to removed deps; reflect new/updated packages.
  • CI:
    • .circleci: Bump cache version; change main workflow branch filter to remove-unused-dev-deps.

Written by Cursor Bugbot for commit f8a209b. This will update automatically on new commits. Configure here.

@jennifer-shehane jennifer-shehane self-assigned this Dec 2, 2025
@cypress
Copy link

cypress bot commented Dec 2, 2025

cypress    Run #67856

Run Properties:  status check failed Failed #67856  •  git commit f8a209b718: Merge branch 'develop' into remove-unused-dev-deps
Project cypress
Branch Review remove-unused-dev-deps
Run status status check failed Failed #67856
Run duration 23m 52s
Commit git commit f8a209b718: Merge branch 'develop' into remove-unused-dev-deps
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 6
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 27
Tests that did not run due to a failure in a mocha hook  Skipped 15
Tests that passed  Passing 777
View all changes introduced in this branch ↗︎
UI Coverage  62.34%
  Untested elements 27  
  Tested elements 48  
Accessibility  99.02%
  Failed rules  0 critical   3 serious   1 moderate   0 minor
  Failed elements 19  

Tests for review

Failed  cypress\e2e\runner\retries.experimentalRetries.mochaEvents.cy.ts • 2 failed tests • app-e2e

View Output

Test Artifacts
... > matches mocha snapshot Test Replay Screenshots
... > does not try to serialize error with err.actual as DOM node Test Replay Screenshots
Failed  cypress\e2e\runner\runner.ui.cy.ts • 3 failed tests • app-e2e

View Output

Test Artifacts
src/cypress/runner > tests finish with correct state > no tests Test Replay Screenshots
src/cypress/runner > other specs > file with empty suites only displays no tests found Test Replay Screenshots
src/cypress/runner > reporter interaction > user can stop test execution Test Replay Screenshots
Failed  cypress\e2e\cypress-origin-communicator.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
Cypress In Cypress Origin Communicator > primary origin memory leak prevention > cleans up the primaryOriginCommunicator events when navigating away from the /specs to /runs Test Replay Screenshots
Flakiness  cypress\e2e\cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
Cypress In Cypress Origin Communicator > primary origin memory leak prevention > cleans up the primaryOriginCommunicator events when navigating to run a different spec Test Replay Screenshots

@jennifer-shehane jennifer-shehane changed the title Remove unused dev deps Remove unused devDependencies from frontend packages (app/frontend-shared/launchpad) Dec 3, 2025
@jennifer-shehane jennifer-shehane changed the title Remove unused devDependencies from frontend packages (app/frontend-shared/launchpad) chore: Remove unused devDependencies from frontend packages (app/frontend-shared/launchpad) Dec 3, 2025
@jennifer-shehane jennifer-shehane changed the title chore: Remove unused devDependencies from frontend packages (app/frontend-shared/launchpad) chore: Remove unused devDependencies + add unlisted deps in frontend packages (app/frontend-shared/launchpad) Dec 3, 2025
Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct. If something was used transiently I guess we will find out about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants