feat(platform): remove platform version patching and state migration logic (#2961)

Author: QuantumExplorer

packages/rs-drive-abci/src/execution/engine/run_block_proposal/mod.rs

@@ -130,21 +130,6 @@ Your software version: {}, latest supported protocol version: {}."#,
             last_committed_platform_version
         };
 
-        // Patch platform version and run migrations if we have patches and/or
-        // migrations defined for this height.
-        // It modifies the protocol version to function version mapping to apply hotfixes
-        // Also it performs migrations to fix corrupted state or prepare it for new features
-        let block_platform_version = if let Some(patched_platform_version) = self
-            .apply_platform_version_patch_and_migrate_state_for_height(
-                block_proposal.height,
-                &mut block_platform_state,
-                transaction,
-            )? {
-            patched_platform_version
-        } else {
-            block_platform_version
-        };
-
         match block_platform_version
             .drive_abci
             .methods

packages/rs-drive-abci/src/execution/platform_events/block_start/migrate_state/mod.rs

@@ -1,6 +1,2 @@
 /// Clearing the drive cache should happen when a new block is going to be run
 pub(in crate::execution) mod clear_drive_block_cache;
-/// State migration
-mod migrate_state;
-/// Patch the platform version function mapping and migrate state based on the block height
-pub(in crate::execution) mod patch_platform;

packages/rs-drive-abci/src/execution/platform_events/block_start/mod.rs

@@ -232,25 +232,16 @@ impl<C> Platform<C> {
         drive: Drive,
         core_rpc: C,
         config: PlatformConfig,
-        mut platform_state: PlatformState,
+        platform_state: PlatformState,
         checkpoint_platform_states: BTreeMap<BlockHeight, Arc<PlatformState>>,
     ) -> Result<Platform<C>, Error>
     where
         C: CoreRPCLike,
     {
         let height = platform_state.last_committed_block_height();
-
-        // Set patched or original platform version as current
-        let platform_version = platform_state
-            .apply_all_patches_to_platform_version_up_to_height(height)
-            .transpose()
-            .unwrap_or_else(|| {
-                let platform_version =
-                    PlatformVersion::get(platform_state.current_protocol_version_in_consensus())
-                        .map_err(Error::from);
-
-                platform_version
-            })?;
+        let platform_version =
+            PlatformVersion::get(platform_state.current_protocol_version_in_consensus())
+                .map_err(Error::from)?;
 
         PlatformVersion::set_current(platform_version);
 

packages/rs-drive-abci/src/execution/platform_events/block_start/patch_platform.rs

@@ -18,12 +18,6 @@ use indexmap::IndexMap;
 use itertools::Itertools;
 use std::collections::BTreeMap;
 
-pub(super) trait PlatformStateV0PrivateMethods {
-    /// Set patched platform version. It's using to fix urgent bugs as not a part of normal upgrade process
-    /// The patched version returns from the public current_platform_version getter in case if present.
-    fn set_patched_platform_version(&mut self, version: Option<&'static PlatformVersion>);
-}
-
 /// Platform state methods introduced in version 0 of Platform State Struct
 pub trait PlatformStateV0Methods {
     /// The last block height or 0 for genesis
@@ -56,14 +50,9 @@ pub trait PlatformStateV0Methods {
     fn last_committed_block_info(&self) -> &Option<ExtendedBlockInfo>;
     /// Returns the current protocol version that is in consensus.
     fn current_protocol_version_in_consensus(&self) -> ProtocolVersion;
-    /// Patched platform version. Used to fix urgent bugs as not part of normal upgrade process.
-    /// The patched version returns from the public current_platform_version getter in case if present.
-    fn patched_platform_version(&self) -> Option<&'static PlatformVersion>;
-    /// Get the current platform version or patched if present
+    /// Get the current platform version
     fn current_platform_version(&self) -> Result<&'static PlatformVersion, Error> {
-        self.patched_platform_version().map(Ok).unwrap_or_else(|| {
-            PlatformVersion::get(self.current_protocol_version_in_consensus()).map_err(Error::from)
-        })
+        PlatformVersion::get(self.current_protocol_version_in_consensus()).map_err(Error::from)
     }
     /// Returns the upcoming protocol version for the next epoch.
     fn next_epoch_protocol_version(&self) -> ProtocolVersion;
@@ -211,14 +200,6 @@ pub trait PlatformStateV0Methods {
     fn hpmn_active_list_len(&self) -> usize;
 }
 
-impl PlatformStateV0PrivateMethods for PlatformState {
-    /// Set patched platform version. It's using to fix urgent bugs as not a part of normal upgrade process
-    /// The patched version returns from the public current_platform_version getter in case if present.
-    fn set_patched_platform_version(&mut self, version: Option<&'static PlatformVersion>) {
-        self.patched_platform_version = version;
-    }
-}
-
 impl PlatformStateV0Methods for PlatformState {
     /// The last block height or 0 for genesis
     fn last_committed_block_height(&self) -> u64 {
@@ -349,12 +330,6 @@ impl PlatformStateV0Methods for PlatformState {
         self.current_protocol_version_in_consensus
     }
 
-    /// Patched platform version. Used to fix urgent bugs as not part of normal upgrade process.
-    /// The patched version returns from the public current_platform_version getter in case if present.
-    fn patched_platform_version(&self) -> Option<&'static PlatformVersion> {
-        self.patched_platform_version
-    }
-
     /// Returns the upcoming protocol version for the next epoch.
     fn next_epoch_protocol_version(&self) -> ProtocolVersion {
         self.next_epoch_protocol_version

packages/rs-drive-abci/src/platform_types/platform/mod.rs

@@ -1,6 +1,5 @@
 mod accessors;
 mod masternode_list_changes;
-mod patch_platform_version;
 mod platform_state_for_saving;
 
 use crate::error::Error;
@@ -46,10 +45,6 @@ pub struct PlatformState {
     pub current_validator_set_quorum_hash: QuorumHash,
     /// next quorum
     pub next_validator_set_quorum_hash: Option<QuorumHash>,
-    /// This is a modified current platform version based on
-    /// `current_protocol_version_in_consensus` with some function versions
-    /// changed to fix an urgent bug that is not a part of normal upgrade process
-    pub patched_platform_version: Option<&'static PlatformVersion>,
     /// current validator set quorums
     /// The validator set quorums are a subset of the quorums, but they also contain the list of
     /// all members
@@ -109,7 +104,6 @@ impl Debug for PlatformState {
             )
             .field("full_masternode_list", &self.full_masternode_list)
             .field("hpmn_masternode_list", &self.hpmn_masternode_list)
-            .field("patched_platform_version", &self.patched_platform_version)
             .field("previous_fee_versions", &self.previous_fee_versions)
             .field(
                 "chain_lock_validating_quorums",
@@ -142,7 +136,6 @@ impl PlatformState {
             next_epoch_protocol_version,
             current_validator_set_quorum_hash: QuorumHash::all_zeros(),
             next_validator_set_quorum_hash: None,
-            patched_platform_version: None,
             validator_sets: Default::default(),
             chain_lock_validating_quorums: SignatureVerificationQuorumSet::new(
                 &config.chain_lock,

packages/rs-drive-abci/src/platform_types/platform_state/accessors.rs

@@ -65,7 +65,6 @@ impl From<PlatformStateForSavingV0> for PlatformState {
             next_validator_set_quorum_hash: value
                 .next_validator_set_quorum_hash
                 .map(|bytes| QuorumHash::from_byte_array(bytes.to_buffer())),
-            patched_platform_version: None,
             validator_sets: value
                 .validator_sets
                 .into_iter()

packages/rs-drive-abci/src/platform_types/platform_state/mod.rs

@@ -119,7 +119,6 @@ impl From<PlatformStateForSavingV1> for PlatformState {
             next_validator_set_quorum_hash: value
                 .next_validator_set_quorum_hash
                 .map(|bytes| QuorumHash::from_byte_array(bytes.to_buffer())),
-            patched_platform_version: None,
             validator_sets: value
                 .validator_sets
                 .into_iter()