updating stuff

Author: edwindj

NEWS.md

@@ -3,6 +3,13 @@
 * added a fix when categorical variables where used, without a rule that specified the domain. (issue #15) Thanks to
 Romina Filippini and Simona Toti for reporting. 
 
+* added a new function `detect_contradicting_if_rules`. (issue #16)
+  It detects all rules that are not satisfiable together with the if condition.
+  Thanks to Romina Filippini and Simona Toti for the suggestion.
+  
+* fix for `is_contradicted_by` and `detect_infeasible_rules` when the rules contained 
+if statements.
+  
 # validatetools 0.5.2
 
 * Added fix for change `is.atomic(NULL)==FALSE` in R 4.3.2

README.Rmd

@@ -67,6 +67,23 @@ make_feasible(rules)
 is_contradicted_by(rules, "rule1")
 ```
 
+### Finding contradicting if rules
+
+
+```{r}
+rules <- validator(
+  if (nace == "a") export == "y",
+  if (nace == "a")  export == "n"
+)
+
+conflicts <- detect_contradicting_if_rules(rules, verbose=TRUE)
+```
+
+
+```{r}
+print(conflicts)
+```
+
 ## Simplifying 
 
 The function `simplify_rules` combines most simplification methods of `validatetools` to simplify a rule set.

README.md

@@ -1,21 +1,22 @@
 
 <!-- README.md is generated from README.Rmd. Please edit that file -->
+
 <!-- badges: start -->
 
 [![R-CMD-check](https://github.com/data-cleaning/validatetools/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/data-cleaning/validatetools/actions/workflows/R-CMD-check.yaml)
 [![CRAN
 status](https://www.r-pkg.org/badges/version/validatetools)](https://CRAN.R-project.org/package=validatetools)
-[![codecov](https://codecov.io/github/data-cleaning/validatetools/graph/badge.svg?token=3tIe5HAUWm)](https://codecov.io/github/data-cleaning/validatetools)
-[![status](https://tinyverse.netlify.app/badge/validatetools)](https://CRAN.R-project.org/package=validatetools)
 [![Mentioned in Awesome Official
 Statistics](https://awesome.re/mentioned-badge.svg)](http://www.awesomeofficialstatistics.org)
+[![Codecov test
+coverage](https://codecov.io/gh/data-cleaning/validatetools/graph/badge.svg)](https://app.codecov.io/gh/data-cleaning/validatetools)
 <!-- badges: end -->
 
 # validatetools
 
 `validatetools` is a utility package for managing validation rule sets
 that are defined with `validate`. In production systems validation rule
-sets tend to grow organically and validatetools redundant or (partially)
+sets tend to grow organically and accumulate redundant or (partially)
 contradictory rules. `validatetools` helps to identify problems with
 large rule sets and includes simplification methods for resolving
 issues.
@@ -70,6 +71,27 @@ is_contradicted_by(rules, "rule1")
 #> [1] "rule2"
 ```
 
+### Finding contradicting if rules
+
+``` r
+rules <- validator(
+  if (nace == "a") export == "y",
+  if (nace == "a")  export == "n"
+)
+
+conflicts <- detect_contradicting_if_rules(rules, verbose=TRUE)
+#> 1 contradiction(s) with if clauses found:
+#> When nace == "a":
+#>   V1: if (nace == "a") export == "y"
+#>   V2: if (nace == "a") export == "n"
+```
+
+``` r
+print(conflicts)
+#> $`nace == "a"`
+#> [1] "V1" "V2"
+```
+
 ## Simplifying
 
 The function `simplify_rules` combines most simplification methods of

examples/detect_contradicting_if_rules.R

@@ -3,4 +3,8 @@ rules <- validator(
   if (nace == "a")  export == "n"
 )
 
-detect_contradicting_if_rules(rules)
+conflicts <- detect_contradicting_if_rules(rules)
+
+print(conflicts)
+
+