chore: remove format! in heavy IO loop (#19077)

* save

* refactor: reduce overhead when log level is not DEBUG

* fmt

* refactor: ThreadTrackerFilter with report_issues mode

* refactor: ThreadTrackerFilter with report_issues mode

* refactor: ThreadTrackerFilter with report_issues mode

* refactor: ThreadTrackerFilter with report_issues mode

* Revert "refactor: ThreadTrackerFilter with report_issues mode"

This reverts commit 4358828.

* Revert "refactor: ThreadTrackerFilter with report_issues mode"

This reverts commit c3df019.

* Revert "refactor: ThreadTrackerFilter with report_issues mode"

This reverts commit 13a2296.

* Revert "refactor: ThreadTrackerFilter with report_issues mode"

This reverts commit 93ea2ab.

* Revert "fmt"

This reverts commit 5755f28.

* Revert "refactor: reduce overhead when log level is not DEBUG"

This reverts commit e3bc664.

* Revert "save"

This reverts commit ef5100a.

* fix: pre-assemble spawn task name, to avoid calling format! in heavy read loop

Author: dqhl76

src/common/storage/src/runtime_layer.rs

@@ -17,6 +17,7 @@ use std::fmt::Formatter;
 use std::sync::Arc;
 
 use databend_common_base::runtime::Runtime;
+use databend_common_base::runtime::ThreadTracker;
 use databend_common_base::runtime::TrySpawn;
 use opendal::raw::oio;
 use opendal::raw::Access;
@@ -183,13 +184,23 @@ impl<A: Access> LayeredAccess for RuntimeAccessor<A> {
 pub struct RuntimeIO<R: 'static> {
     inner: Option<R>,
     runtime: Arc<Runtime>,
+    spawn_task_name: String,
 }
 
 impl<R> RuntimeIO<R> {
     fn new(inner: R, runtime: Arc<Runtime>) -> Self {
+        // pre-assemble spawn task name, to avoid calling format! in heavy read loop
+        let query_id = ThreadTracker::query_id();
+        let spawn_task_name = if let Some(id) = query_id {
+            format!("Running query {} IO task", id)
+        } else {
+            String::from("Running IO task")
+        };
+
         Self {
             inner: Some(inner),
             runtime,
+            spawn_task_name,
         }
     }
 }
@@ -200,10 +211,14 @@ impl<R: oio::Read> oio::Read for RuntimeIO<R> {
         let runtime = self.runtime.clone();
 
         let (r, res) = runtime
-            .spawn(async move {
-                let res = r.read().await;
-                (r, res)
-            })
+            .try_spawn(
+                async move {
+                    let res = r.read().await;
+                    (r, res)
+                },
+                Some(self.spawn_task_name.clone()),
+            )
+            .expect("spawn must success")
             .await
             .expect("join must success");
         self.inner = Some(r);
@@ -217,10 +232,14 @@ impl<R: oio::Write> oio::Write for RuntimeIO<R> {
         let runtime = self.runtime.clone();
 
         let (r, res) = runtime
-            .spawn(async move {
-                let res = r.write(bs).await;
-                (r, res)
-            })
+            .try_spawn(
+                async move {
+                    let res = r.write(bs).await;
+                    (r, res)
+                },
+                Some(self.spawn_task_name.clone()),
+            )
+            .expect("spawn must success")
             .await
             .expect("join must success");
         self.inner = Some(r);
@@ -232,10 +251,14 @@ impl<R: oio::Write> oio::Write for RuntimeIO<R> {
         let runtime = self.runtime.clone();
 
         let (r, res) = runtime
-            .spawn(async move {
-                let res = r.close().await;
-                (r, res)
-            })
+            .try_spawn(
+                async move {
+                    let res = r.close().await;
+                    (r, res)
+                },
+                Some(self.spawn_task_name.clone()),
+            )
+            .expect("spawn must success")
             .await
             .expect("join must success");
         self.inner = Some(r);
@@ -247,10 +270,14 @@ impl<R: oio::Write> oio::Write for RuntimeIO<R> {
         let runtime = self.runtime.clone();
 
         let (r, res) = runtime
-            .spawn(async move {
-                let res = r.abort().await;
-                (r, res)
-            })
+            .try_spawn(
+                async move {
+                    let res = r.abort().await;
+                    (r, res)
+                },
+                Some(self.spawn_task_name.clone()),
+            )
+            .expect("spawn must success")
             .await
             .expect("join must success");
         self.inner = Some(r);
@@ -264,10 +291,14 @@ impl<R: oio::List> oio::List for RuntimeIO<R> {
         let runtime = self.runtime.clone();
 
         let (r, res) = runtime
-            .spawn(async move {
-                let res = r.next().await;
-                (r, res)
-            })
+            .try_spawn(
+                async move {
+                    let res = r.next().await;
+                    (r, res)
+                },
+                Some(self.spawn_task_name.clone()),
+            )
+            .expect("spawn must success")
             .await
             .expect("join must success");
         self.inner = Some(r);
@@ -285,10 +316,14 @@ impl<R: oio::Delete> oio::Delete for RuntimeIO<R> {
         let runtime = self.runtime.clone();
 
         let (r, res) = runtime
-            .spawn(async move {
-                let res = r.flush().await;
-                (r, res)
-            })
+            .try_spawn(
+                async move {
+                    let res = r.flush().await;
+                    (r, res)
+                },
+                Some(self.spawn_task_name.clone()),
+            )
+            .expect("spawn must success")
             .await
             .expect("join must success");
         self.inner = Some(r);