MOD: Update C++ to support datetime dataset range

Author: threecgreen

CHANGELOG.md

@@ -1,11 +1,17 @@
 # Changelog
 
-## 0.18.2 - TBD
+## 0.19.0 - TBD
 
 ### Enhancements
 - Added new `UncrossingPrice` `StatType` variant
 - Added new publisher values for `XNAS.BASIC`
 
+### Breaking changes
+- Removed `start_date` and `end_date` fields from `DatasetRange` struct
+  in favor of `start` and `end`
+- Removed live `Subscribe` method overloads with `use_snapshot`
+  parameter in favor of separate `SubscribeWithSnapshot` method
+
 ### Bug fixes
 - Fixed overloading of live `Subscribe` methods
 - Fixed live subscribing with default-constructed `UnixNanos`

include/databento/metadata.hpp

@@ -32,8 +32,8 @@ struct DatasetConditionDetail {
 };
 
 struct DatasetRange {
-  std::string start_date;
-  std::string end_date;
+  std::string start;
+  std::string end;
 };
 
 inline bool operator==(const PublisherDetail& lhs, const PublisherDetail& rhs) {
@@ -71,7 +71,7 @@ inline bool operator!=(const DatasetConditionDetail& lhs,
 }
 
 inline bool operator==(const DatasetRange& lhs, const DatasetRange& rhs) {
-  return lhs.start_date == rhs.start_date && lhs.end_date == rhs.end_date;
+  return lhs.start == rhs.start && lhs.end == rhs.end;
 }
 inline bool operator!=(const DatasetRange& lhs, const DatasetRange& rhs) {
   return !(lhs == rhs);

src/historical.cpp

@@ -559,9 +559,8 @@ databento::DatasetRange Historical::MetadataGetDatasetRange(
   if (!json.is_object()) {
     throw JsonResponseError::TypeMismatch(kEndpoint, "object", json);
   }
-  return DatasetRange{
-      detail::ParseAt<std::string>(kEndpoint, json, "start_date"),
-      detail::ParseAt<std::string>(kEndpoint, json, "end_date")};
+  return DatasetRange{detail::ParseAt<std::string>(kEndpoint, json, "start"),
+                      detail::ParseAt<std::string>(kEndpoint, json, "end")};
 }
 
 static const std::string kMetadataGetRecordCountEndpoint =

src/metadata.cpp

@@ -59,8 +59,8 @@ std::ostream& operator<<(std::ostream& stream,
       .SetSpacer(" ")
       .SetTypeName("DatasetRange")
       .Build()
-      .AddField("start_date", dataset_range.start_date)
-      .AddField("end_date", dataset_range.end_date)
+      .AddField("start", dataset_range.start)
+      .AddField("end", dataset_range.end)
       .Finish();
 }
 }  // namespace databento

test/src/historical_tests.cpp

@@ -447,17 +447,17 @@ TEST_F(HistoricalTests, TestMetadataListUnitPrices) {
 }
 
 TEST_F(HistoricalTests, TestMetadataGetDatasetRange) {
-  const nlohmann::json kResp = {{"start_date", "2017-05-21"},
-                                {"end_date", "2022-12-01"}};
+  const nlohmann::json kResp = {{"start", "2017-05-21T00:00:00.000000000Z"},
+                                {"end", "2022-12-01T00:00:00.000000000Z"}};
   mock_server_.MockGetJson("/v0/metadata.get_dataset_range",
                            {{"dataset", dataset::kXnasItch}}, kResp);
   const auto port = mock_server_.ListenOnThread();
 
   databento::Historical target{logger_.get(), kApiKey, "localhost",
                                static_cast<std::uint16_t>(port)};
   const auto res = target.MetadataGetDatasetRange(dataset::kXnasItch);
-  EXPECT_EQ(res.start_date, "2017-05-21");
-  EXPECT_EQ(res.end_date, "2022-12-01");
+  EXPECT_EQ(res.start, "2017-05-21T00:00:00.000000000Z");
+  EXPECT_EQ(res.end, "2022-12-01T00:00:00.000000000Z");
 }
 
 TEST_F(HistoricalTests, TestMetadataGetRecordCount) {

test/src/metadata_tests.cpp

@@ -14,10 +14,11 @@ TEST(MetadataTests, TestDatasetConditionDetailToString) {
 }
 
 TEST(MetadataTests, TestDatasetRangeToString) {
-  const DatasetRange target{"2022-05-17", "2023-01-07"};
+  const DatasetRange target{"2022-05-17T00:00:00.000000000Z",
+                            "2023-01-07T00:00:00.000000000Z"};
   ASSERT_EQ(
       ToString(target),
-      R"(DatasetRange { start_date = "2022-05-17", end_date = "2023-01-07" })");
+      R"(DatasetRange { start = "2022-05-17T00:00:00.000000000Z", end = "2023-01-07T00:00:00.000000000Z" })");
 }
 }  // namespace test
 }  // namespace databento