FIX: Fix MSVC build with path string conversion

Author: threecgreen

.gitignore

@@ -2,4 +2,5 @@ build
 CMakeSettings.json
 vcpkg_installed
 .vs
+.cache
 !*.zst

src/detail/buffer.cpp

@@ -73,8 +73,8 @@ void Buffer::Shift() {
   write_pos_ = read_pos_ + unread_bytes;
 }
 
-std::ostream& databento::detail::operator<<(std::ostream& stream,
-                                            const Buffer& buffer) {
+namespace databento::detail {
+std::ostream& operator<<(std::ostream& stream, const Buffer& buffer) {
   return StreamOpBuilder{stream}
       .SetTypeName("Buffer")
       .SetSpacer(" ")
@@ -87,3 +87,4 @@ std::ostream& databento::detail::operator<<(std::ostream& stream,
       .AddField("WriteCapacity", buffer.WriteCapacity())
       .Finish();
 }
+}  // namespace databento::detail

tests/include/temp_file.hpp

@@ -4,6 +4,7 @@
 
 #include <cassert>  // assert
 #include <cstdio>   // remove
+#include <filesystem>
 #include <fstream>  // ifstream
 #include <string>
 #include <utility>  // move
@@ -15,6 +16,8 @@ namespace databento {
 // goes out of scope.
 class TempFile {
  public:
+  explicit TempFile(const std::filesystem::path& path)
+      : TempFile{path.string()} {}
   explicit TempFile(std::string path) : path_{std::move(path)} {
     std::ifstream f{path_};
     if (Exists()) {

tests/src/historical_tests.cpp

@@ -245,14 +245,26 @@ TEST_F(HistoricalTests, TestBatchDownloadAll) {
   ASSERT_FALSE(temp_metadata_file.Exists());
   ASSERT_FALSE(temp_dbn_file.Exists());
   const std::vector<std::string> paths =
-      target.BatchDownload(tmp_path_, kJobId);
+      target.BatchDownload(tmp_path_.string(), kJobId);
   EXPECT_TRUE(temp_metadata_file.Exists());
   EXPECT_TRUE(temp_dbn_file.Exists());
   ASSERT_EQ(paths.size(), 2);
-  EXPECT_NE(std::find(paths.begin(), paths.end(), temp_metadata_file.Path()),
-            paths.end());
-  EXPECT_NE(std::find(paths.begin(), paths.end(), temp_dbn_file.Path()),
-            paths.end());
+  EXPECT_NE(
+      std::find_if(paths.begin(), paths.end(),
+                   [&temp_metadata_file](const auto& path) {
+                     return std::filesystem::path{path}.lexically_normal() ==
+                            std::filesystem::path{temp_metadata_file.Path()}
+                                .lexically_normal();
+                   }),
+      paths.end());
+  EXPECT_NE(
+      std::find_if(paths.begin(), paths.end(),
+                   [&temp_dbn_file](const auto& path) {
+                     return std::filesystem::path{path}.lexically_normal() ==
+                            std::filesystem::path{temp_dbn_file.Path()}
+                                .lexically_normal();
+                   }),
+      paths.end());
 }
 
 TEST_F(HistoricalTests, TestBatchDownloadSingle) {
@@ -267,9 +279,11 @@ TEST_F(HistoricalTests, TestBatchDownloadSingle) {
                                static_cast<std::uint16_t>(port)};
   ASSERT_FALSE(temp_metadata_file.Exists());
   const std::string path =
-      target.BatchDownload(tmp_path_, kJobId, "test_metadata.json");
+      target.BatchDownload(tmp_path_.string(), kJobId, "test_metadata.json");
   EXPECT_TRUE(temp_metadata_file.Exists());
-  EXPECT_EQ(path, temp_metadata_file.Path());
+  EXPECT_EQ(
+      std::filesystem::path{path}.lexically_normal(),
+      std::filesystem::path{temp_metadata_file.Path()}.lexically_normal());
 }
 
 TEST_F(HistoricalTests, TestBatchDownloadSingleInvalidFile) {
@@ -280,8 +294,9 @@ TEST_F(HistoricalTests, TestBatchDownloadSingleInvalidFile) {
 
   databento::Historical target{logger_.get(), kApiKey, "localhost",
                                static_cast<std::uint16_t>(port)};
-  ASSERT_THROW(target.BatchDownload(tmp_path_, kJobId, "test_metadata.js"),
-               InvalidArgumentError);
+  ASSERT_THROW(
+      target.BatchDownload(tmp_path_.string(), kJobId, "test_metadata.js"),
+      InvalidArgumentError);
 }
 
 TEST_F(HistoricalTests, TestMetadataListPublishers) {