ADD: Add Publisher method to C++

Author: threecgreen

include/databento/publishers.hpp

@@ -220,10 +220,10 @@ enum class Publisher : std::uint16_t {
 };
 
 // Get a Publisher's Venue.
-constexpr Venue PublisherVenue(Publisher publisher);
+Venue PublisherVenue(Publisher publisher);
 
 // Get a Publisher's Dataset.
-constexpr Dataset PublisherDataset(Publisher publisher);
+Dataset PublisherDataset(Publisher publisher);
 
 template <typename T>
 T FromString(const std::string& str);
@@ -241,5 +241,4 @@ const char* ToString(Publisher publisher);
 std::ostream& operator<<(std::ostream& out, Publisher publisher);
 template <>
 Publisher FromString(const std::string& str);
-
 }  // namespace databento

include/databento/record.hpp

@@ -10,7 +10,8 @@
 
 #include "databento/datetime.hpp"  // UnixNanos
 #include "databento/enums.hpp"
-#include "databento/flag_set.hpp"  // FlagSet
+#include "databento/flag_set.hpp"    // FlagSet
+#include "databento/publishers.hpp"  // Publisher
 
 namespace databento {
 // Common data for all Databento Records.
@@ -30,6 +31,10 @@ struct RecordHeader {
   UnixNanos ts_event;
 
   std::size_t Size() const;
+  // Retrieve the publisher based on the publisher ID.
+  enum Publisher Publisher() const {
+    return static_cast<enum Publisher>(publisher_id);
+  }
 };
 
 class Record {
@@ -38,6 +43,7 @@ class Record {
 
   const RecordHeader& Header() const { return *record_; }
   ::databento::RType RType() const { return record_->rtype; }
+  enum Publisher Publisher() const { return Header().Publisher(); }
 
   template <typename T>
   bool Holds() const {

src/publishers.cpp

@@ -6,8 +6,8 @@
 
 #include "databento/exceptions.hpp"  // InvalidArgumentError
 
-// NOLINTBEGIN(bugprone-branch-clone)
 namespace databento {
+// NOLINTBEGIN(bugprone-branch-clone)
 
 const char* ToString(Venue venue) {
   switch (venue) {
@@ -401,7 +401,7 @@ Dataset FromString(const std::string& str) {
                              "unknown value '" + str + '\''};
 }
 
-constexpr Venue PublisherVenue(Publisher publisher) {
+Venue PublisherVenue(Publisher publisher) {
   switch (publisher) {
     case Publisher::GlbxMdp3Glbx: {
       return Venue::Glbx;
@@ -529,9 +529,15 @@ constexpr Venue PublisherVenue(Publisher publisher) {
     case Publisher::DbeqBasicEprl: {
       return Venue::Eprl;
     }
+    default: {
+      throw InvalidArgumentError{
+          "PublisherVenue", "publisher",
+          "unknown conversion for " +
+              std::to_string(static_cast<std::uint16_t>(publisher))};
+    }
   }
 }
-constexpr Dataset PublisherDataset(Publisher publisher) {
+Dataset PublisherDataset(Publisher publisher) {
   switch (publisher) {
     case Publisher::GlbxMdp3Glbx: {
       return Dataset::GlbxMdp3;
@@ -659,6 +665,12 @@ constexpr Dataset PublisherDataset(Publisher publisher) {
     case Publisher::DbeqBasicEprl: {
       return Dataset::DbeqBasic;
     }
+    default: {
+      throw InvalidArgumentError{
+          "PublisherDataset", "publisher",
+          "unknown conversion for " +
+              std::to_string(static_cast<std::uint16_t>(publisher))};
+    }
   }
 }
 
@@ -932,6 +944,5 @@ Publisher FromString(const std::string& str) {
   throw InvalidArgumentError{"FromString<Publisher>", "str",
                              "unknown value '" + str + '\''};
 }
-
-}  // namespace databento
 // NOLINTEND(bugprone-branch-clone)
+}  // namespace databento

test/src/record_tests.cpp

@@ -2,14 +2,36 @@
 
 #include <chrono>
 #include <cstddef>
+#include <cstdint>
 
 #include "databento/constants.hpp"
 #include "databento/datetime.hpp"  // TimeDeltaNanos, UnixNanos
 #include "databento/enums.hpp"
+#include "databento/publishers.hpp"
 #include "databento/record.hpp"
 
 namespace databento {
 namespace test {
+TEST(RecordTests, TestPublisher) {
+  const TradeMsg target{
+      RecordHeader{sizeof(TradeMsg) / RecordHeader::kLengthMultiplier,
+                   RType::Mbp0,
+                   static_cast<std::uint16_t>(Publisher::OpraPillarEdgo),
+                   1,
+                   {}},
+      55000000000,
+      500,
+      Action::Add,
+      Side::Bid,
+      {},
+      0,
+      {},
+      {},
+      126239};
+  EXPECT_EQ(target.hd.Publisher(), Publisher::OpraPillarEdgo);
+  EXPECT_EQ(PublisherVenue(target.hd.Publisher()), Venue::Edgo);
+  EXPECT_EQ(PublisherDataset(target.hd.Publisher()), Dataset::OpraPillar);
+}
 TEST(RecordTests, TestMbp10MsgToString) {
   Mbp10Msg target{
       RecordHeader{sizeof(Mbp10Msg) / RecordHeader::kLengthMultiplier,