Skip to content

Commit 8efbf0f

Browse files
committed
FIX: Fix nlohmann_json install
1 parent 894b679 commit 8efbf0f

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
## 0.10.1 - TBD
4+
5+
#### Bug fixes
6+
- Fixed installation of `nlohmann_json` when using bundled version
7+
38
## 0.10.0 - 2023-07-20
49

510
#### Enhancements

CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,8 @@ if(${PROJECT_NAME_UPPERCASE}_USE_EXTERNAL_JSON)
122122
find_package(nlohmann_json REQUIRED)
123123
else()
124124
set(json_version 3.11.2)
125+
# Required to correctly install nlohmann_json
126+
set(JSON_Install ON)
125127
if(CMAKE_VERSION VERSION_LESS 3.24)
126128
FetchContent_Declare(
127129
json

README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,15 @@ target_link_libraries(example PRIVATE databento::databento)
3636

3737
Alternatively, you can clone the source code from GitHub [here](https://github.com/databento/databento-cpp).
3838

39-
To install the library at the system level, build and install it with the following:
39+
To install the library to `/usr`, build and install it with the following:
4040

4141
```sh
4242
git clone https://github.com/databento/databento-cpp
4343
cd databento-cpp
4444
cmake -S . -B build \
4545
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
46-
-DCMAKE_INSTALL_PREFIX='/usr' \
47-
-DDATABENTO_USE_EXTERNAL_JSON=ON \
48-
-DDATABENTO_USE_EXTERNAL_HTTPLIB=ON
49-
cmake --build build --target databento
46+
-DCMAKE_INSTALL_PREFIX='/usr'
47+
cmake --build build --target databento --parallel 8
5048
cmake --install build
5149
```
5250

0 commit comments

Comments
 (0)