FIX: Fix macOS build

Author: threecgreen

include/databento/flag_set.hpp

@@ -11,19 +11,19 @@ class FlagSet {
   using Repr = std::uint8_t;
   // Indicates it's the last message in the packet from the venue for a given
   // `instrument_id`.
-  static inline constexpr Repr kLast = 1 << 7;
+  static constexpr Repr kLast = 1 << 7;
   // Indicates a top-of-book message, not an individual order.
-  static inline constexpr Repr kTob = 1 << 6;
+  static constexpr Repr kTob = 1 << 6;
   // Indicates the message was sourced from a replay, such as a snapshot
   // server.
-  static inline constexpr Repr kSnapshot = 1 << 5;
+  static constexpr Repr kSnapshot = 1 << 5;
   // Indicates an aggregated price level message, not an individual order.
-  static inline constexpr Repr kMbp = 1 << 4;
+  static constexpr Repr kMbp = 1 << 4;
   // Indicates the `ts_recv` value is inaccurate due to clock issues or packet
   // reordering.
-  static inline constexpr Repr kBadTsRecv = 1 << 3;
+  static constexpr Repr kBadTsRecv = 1 << 3;
   // Indicates an unrecoverable gap was detected in the channel.
-  static inline constexpr Repr kMaybeBadBook = 1 << 2;
+  static constexpr Repr kMaybeBadBook = 1 << 2;
 
   friend std::ostream& operator<<(std::ostream&, FlagSet);
 

src/compat.cpp

@@ -110,10 +110,12 @@ SymbolMappingMsgV2 SymbolMappingMsgV1::ToV2() const {
       RecordHeader{sizeof(SymbolMappingMsgV2) / RecordHeader::kLengthMultiplier,
                    RType::SymbolMapping, hd.publisher_id, hd.instrument_id,
                    hd.ts_event},
-      // invalid
+      // Intentionally invalid
+      // NOLINTNEXTLINE(clang-analyzer-optin.core.EnumCastOutOfRange)
       static_cast<SType>(std::numeric_limits<std::uint8_t>::max()),
       {},
-      // invalid
+      // Intentionally invalid
+      // NOLINTNEXTLINE(clang-analyzer-optin.core.EnumCastOutOfRange)
       static_cast<SType>(std::numeric_limits<std::uint8_t>::max()),
       {},
       start_ts,

src/flag_set.cpp

@@ -5,8 +5,15 @@
 #include "stream_op_helper.hpp"
 
 namespace databento {
+constexpr FlagSet::Repr FlagSet::kLast;
+constexpr FlagSet::Repr FlagSet::kTob;
+constexpr FlagSet::Repr FlagSet::kSnapshot;
+constexpr FlagSet::Repr FlagSet::kMbp;
+constexpr FlagSet::Repr FlagSet::kBadTsRecv;
+constexpr FlagSet::Repr FlagSet::kMaybeBadBook;
+
 std::ostream& operator<<(std::ostream& stream, FlagSet flag_set) {
-  constexpr std::array<std::pair<bool (FlagSet::*)() const, const char*>, 6>
+  const std::array<std::pair<bool (FlagSet::*)() const, const char*>, 6>
       kFlagsAndNames = {{
           {&FlagSet::IsLast, "LAST"},
           {&FlagSet::IsTob, "TOB"},

test/src/dbn_decoder_tests.cpp

@@ -6,6 +6,7 @@
 #include <cstring>
 #include <fstream>  // ifstream
 #include <ios>      // streamsize, ios::binary, ios::ate
+#include <limits>
 #include <memory>
 
 #include "databento/compat.hpp"
@@ -164,6 +165,10 @@ TEST_F(DbnDecoderTests, TestUpgradeSymbolMappingWithTsOut) {
   EXPECT_EQ(orig.ts_out, upgraded.ts_out);
   EXPECT_STREQ(orig.rec.STypeInSymbol(), upgraded.rec.STypeInSymbol());
   EXPECT_STREQ(orig.rec.STypeOutSymbol(), upgraded.rec.STypeOutSymbol());
+  EXPECT_EQ(static_cast<std::uint8_t>(upgraded.rec.stype_in),
+            std::numeric_limits<std::uint8_t>::max());
+  EXPECT_EQ(static_cast<std::uint8_t>(upgraded.rec.stype_out),
+            std::numeric_limits<std::uint8_t>::max());
   // `length` properly set
   EXPECT_EQ(upgraded.rec.hd.Size(), sizeof(upgraded));
   // used compat buffer