FIX: Fix GCC shadowing warning

Author: threecgreen

cmake/StandardSettings.cmake

@@ -82,8 +82,11 @@ if(${PROJECT_NAME_UPPERCASE}_ENABLE_LTO)
 endif()
 
 option(${PROJECT_NAME_UPPERCASE}_ENABLE_CCACHE "Enable the usage of Ccache, in order to speed up rebuild times." ON)
-find_program(CCACHE_FOUND ccache)
-if(CCACHE_FOUND)
-  set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ccache)
-  set_property(GLOBAL PROPERTY RULE_LAUNCH_LINK ccache)
+if(${PROJECT_NAME_UPPERCASE}_ENABLE_CCACHE)
+  find_program(CCACHE_FOUND ccache)
+  if(CCACHE_FOUND)
+    message(STATUS "Found and enabled ccache")
+    set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ccache)
+    set_property(GLOBAL PROPERTY RULE_LAUNCH_LINK ccache)
+  endif()
 endif()

cmake/StaticAnalyzers.cmake

@@ -5,7 +5,7 @@ if(${PROJECT_NAME_UPPERCASE}_ENABLE_CLANG_TIDY)
       CMAKE_CXX_CLANG_TIDY ${CLANGTIDY}
       -extra-arg=-Wno-unknown-warning-option
     )
-    message("Clang-Tidy finished setting up.")
+    message(STATUS "Clang-Tidy finished setting up.")
   else()
     message(SEND_ERROR "Clang-Tidy requested but executable not found.")
   endif()
@@ -31,7 +31,7 @@ if(${PROJECT_NAME_UPPERCASE}_ENABLE_CPPCHECK)
       # Ignore third-party dependencies
       -i${CMAKE_BINARY_DIR}
     )
-    message("Cppcheck finished setting up.")
+    message(STATUS "Cppcheck finished setting up.")
   else()
     message(SEND_ERROR "Cppcheck requested but executable not found.")
   endif()

include/databento/datetime.hpp

@@ -20,9 +20,10 @@ std::string DateFromIso8601Int(std::uint32_t date_int);
 
 template <typename T>
 struct DateTimeRange {
-  explicit DateTimeRange(T start) : DateTimeRange{std::move(start), {}} {}
-  DateTimeRange(T start, T end)
-      : start{std::move(start)}, end{std::move(end)} {}
+  explicit DateTimeRange(T start_) : DateTimeRange{std::move(start_), {}} {}
+  // underscore to prevent shadowing
+  DateTimeRange(T start_, T end_)
+      : start{std::move(start_)}, end{std::move(end_)} {}
 
   T start;
   T end;