Skip to content

Commit c8abee7

Browse files
committed
DEL: Remove unused delivery variants
1 parent d71c6ae commit c8abee7

File tree

3 files changed

+1
-14
lines changed

3 files changed

+1
-14
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
- Added missing `IndexTs()` method to `v1::InstrumentDefMsg`, `v2::InstrumentDefMsg`,
1717
and `v1::SymbolMappingMsg`
1818
- Fixed error in templated overload of `DbnDecoder::EncodeRecord()`
19+
- Removed unused `Disk` and `S3` variants from `Delivery` enum
1920

2021
## 0.39.1 - 2025-07-22
2122

include/databento/enums.hpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ enum class SplitDuration : std::uint8_t {
3030
// Represents how a batch job will be delivered.
3131
enum class Delivery : std::uint8_t {
3232
Download,
33-
S3,
34-
Disk,
3533
};
3634

3735
// The current state of a batch job.

src/enums.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,6 @@ const char* ToString(Delivery delivery) {
6262
case Delivery::Download: {
6363
return "download";
6464
}
65-
case Delivery::S3: {
66-
return "s3";
67-
}
68-
case Delivery::Disk: {
69-
return "disk";
70-
}
7165
default: {
7266
return "unknown";
7367
}
@@ -957,12 +951,6 @@ Delivery FromString(const std::string& str) {
957951
if (str == "download") {
958952
return Delivery::Download;
959953
}
960-
if (str == "s3") {
961-
return Delivery::S3;
962-
}
963-
if (str == "disk") {
964-
return Delivery::Disk;
965-
}
966954
throw InvalidArgumentError{"FromString<Delivery>", "str",
967955
"unknown value '" + str + '\''};
968956
}

0 commit comments

Comments
 (0)