Skip to content

Commit dc4b428

Browse files
FIX: Fix TRF publishers to point to source
1 parent ed9864a commit dc4b428

File tree

3 files changed

+33
-26
lines changed

3 files changed

+33
-26
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,13 @@
1515
- Added new enum values for `Schema` and `RType` corresponding to new schemas
1616
`cbbo`, `cbbo-1s`, `cbbo-1m`, `tcbbo`, `bbo-1s`, `bbo-1m`
1717

18+
### Breaking changes
19+
- Renamed publishers from deprecated datasets to their respective sources (`XNAS.NLS`
20+
and `XNYS.TRADES` respectively)
21+
22+
### Deprecations
23+
- Deprecated dataset values `FINN.NLS` and `FINY.TRADES`
24+
1825
### Bug fixes
1926
- Fixed out-of-order initialization in `DbnDecoder` (credit: @Hailios)
2027
- Renamed `MatchAlgorithm::EurodollarOptions` to `MatchAlgorithm::EurodollarFutures`

include/databento/publishers.hpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,9 @@ enum class Dataset : std::uint16_t {
127127
MemxMemoir = 15,
128128
// MIAX Pearl Depth
129129
EprlDom = 16,
130-
// FINRA/Nasdaq TRF
130+
// FINRA/Nasdaq TRF (DEPRECATED)
131131
FinnNls = 17,
132-
// FINRA/NYSE TRF
132+
// FINRA/NYSE TRF (DEPRECATED)
133133
FinyTrades = 18,
134134
// OPRA Binary
135135
OpraPillar = 19,
@@ -192,11 +192,11 @@ enum class Publisher : std::uint16_t {
192192
// MIAX Pearl Depth
193193
EprlDomEprl = 16,
194194
// FINRA/Nasdaq TRF Carteret
195-
FinnNlsFinn = 17,
195+
XnasNlsFinn = 17,
196196
// FINRA/Nasdaq TRF Chicago
197-
FinnNlsFinc = 18,
197+
XnasNlsFinc = 18,
198198
// FINRA/NYSE TRF
199-
FinyTradesFiny = 19,
199+
XnysTradesFiny = 19,
200200
// OPRA - NYSE American
201201
OpraPillarAmxo = 20,
202202
// OPRA - Boston Options Exchange

src/publishers.cpp

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -529,13 +529,13 @@ Venue PublisherVenue(Publisher publisher) {
529529
case Publisher::EprlDomEprl: {
530530
return Venue::Eprl;
531531
}
532-
case Publisher::FinnNlsFinn: {
532+
case Publisher::XnasNlsFinn: {
533533
return Venue::Finn;
534534
}
535-
case Publisher::FinnNlsFinc: {
535+
case Publisher::XnasNlsFinc: {
536536
return Venue::Finc;
537537
}
538-
case Publisher::FinyTradesFiny: {
538+
case Publisher::XnysTradesFiny: {
539539
return Venue::Finy;
540540
}
541541
case Publisher::OpraPillarAmxo: {
@@ -779,14 +779,14 @@ Dataset PublisherDataset(Publisher publisher) {
779779
case Publisher::EprlDomEprl: {
780780
return Dataset::EprlDom;
781781
}
782-
case Publisher::FinnNlsFinn: {
783-
return Dataset::FinnNls;
782+
case Publisher::XnasNlsFinn: {
783+
return Dataset::XnasNls;
784784
}
785-
case Publisher::FinnNlsFinc: {
786-
return Dataset::FinnNls;
785+
case Publisher::XnasNlsFinc: {
786+
return Dataset::XnasNls;
787787
}
788-
case Publisher::FinyTradesFiny: {
789-
return Dataset::FinyTrades;
788+
case Publisher::XnysTradesFiny: {
789+
return Dataset::XnysTrades;
790790
}
791791
case Publisher::OpraPillarAmxo: {
792792
return Dataset::OpraPillar;
@@ -1030,14 +1030,14 @@ const char* ToString(Publisher publisher) {
10301030
case Publisher::EprlDomEprl: {
10311031
return "EPRL.DOM.EPRL";
10321032
}
1033-
case Publisher::FinnNlsFinn: {
1034-
return "FINN.NLS.FINN";
1033+
case Publisher::XnasNlsFinn: {
1034+
return "XNAS.NLS.FINN";
10351035
}
1036-
case Publisher::FinnNlsFinc: {
1037-
return "FINN.NLS.FINC";
1036+
case Publisher::XnasNlsFinc: {
1037+
return "XNAS.NLS.FINC";
10381038
}
1039-
case Publisher::FinyTradesFiny: {
1040-
return "FINY.TRADES.FINY";
1039+
case Publisher::XnysTradesFiny: {
1040+
return "XNYS.TRADES.FINY";
10411041
}
10421042
case Publisher::OpraPillarAmxo: {
10431043
return "OPRA.PILLAR.AMXO";
@@ -1283,14 +1283,14 @@ Publisher FromString(const std::string& str) {
12831283
if (str == "EPRL.DOM.EPRL") {
12841284
return Publisher::EprlDomEprl;
12851285
}
1286-
if (str == "FINN.NLS.FINN") {
1287-
return Publisher::FinnNlsFinn;
1286+
if (str == "XNAS.NLS.FINN") {
1287+
return Publisher::XnasNlsFinn;
12881288
}
1289-
if (str == "FINN.NLS.FINC") {
1290-
return Publisher::FinnNlsFinc;
1289+
if (str == "XNAS.NLS.FINC") {
1290+
return Publisher::XnasNlsFinc;
12911291
}
1292-
if (str == "FINY.TRADES.FINY") {
1293-
return Publisher::FinyTradesFiny;
1292+
if (str == "XNYS.TRADES.FINY") {
1293+
return Publisher::XnysTradesFiny;
12941294
}
12951295
if (str == "OPRA.PILLAR.AMXO") {
12961296
return Publisher::OpraPillarAmxo;

0 commit comments

Comments
 (0)