Simplify tests for path mutators (#2610)

## Changes
Simplify tests for path mutators

Author: kanterov

bundle/config/mutator/paths/app_paths_visitor_test.go

@@ -7,7 +7,6 @@ import (
 	"github.com/databricks/cli/bundle/config/resources"
 	"github.com/databricks/cli/libs/dyn"
 	assert "github.com/databricks/cli/libs/dyn/dynassert"
-	"github.com/stretchr/testify/require"
 )
 
 func TestAppPathsVisitor(t *testing.T) {
@@ -21,22 +20,10 @@ func TestAppPathsVisitor(t *testing.T) {
 		},
 	}
 
-	actual := visitAppPaths(t, root)
+	actual := collectVisitedPaths(t, root, VisitAppPaths)
 	expected := []dyn.Path{
 		dyn.MustPathFromString("resources.apps.app0.source_code_path"),
 	}
 
 	assert.ElementsMatch(t, expected, actual)
 }
-
-func visitAppPaths(t *testing.T, root config.Root) []dyn.Path {
-	var actual []dyn.Path
-	err := root.Mutate(func(value dyn.Value) (dyn.Value, error) {
-		return VisitAppPaths(value, func(p dyn.Path, mode TranslateMode, v dyn.Value) (dyn.Value, error) {
-			actual = append(actual, p)
-			return v, nil
-		})
-	})
-	require.NoError(t, err)
-	return actual
-}

bundle/config/mutator/paths/artifact_paths_visitor_test.go

@@ -6,7 +6,6 @@ import (
 	"github.com/databricks/cli/bundle/config"
 	"github.com/databricks/cli/libs/dyn"
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
 func TestArtifactPathsVisitor(t *testing.T) {
@@ -18,22 +17,10 @@ func TestArtifactPathsVisitor(t *testing.T) {
 		},
 	}
 
-	actual := visitArtifactPaths(t, root)
+	actual := collectVisitedPaths(t, root, VisitArtifactPaths)
 	expected := []dyn.Path{
 		dyn.MustPathFromString("artifacts.artifact0.path"),
 	}
 
 	assert.ElementsMatch(t, expected, actual)
 }
-
-func visitArtifactPaths(t *testing.T, root config.Root) []dyn.Path {
-	var actual []dyn.Path
-	err := root.Mutate(func(value dyn.Value) (dyn.Value, error) {
-		return VisitArtifactPaths(value, func(p dyn.Path, mode TranslateMode, v dyn.Value) (dyn.Value, error) {
-			actual = append(actual, p)
-			return v, nil
-		})
-	})
-	require.NoError(t, err)
-	return actual
-}

bundle/config/mutator/paths/dashboard_paths_visitor_test.go

@@ -7,7 +7,6 @@ import (
 	"github.com/databricks/cli/bundle/config/resources"
 	"github.com/databricks/cli/libs/dyn"
 	assert "github.com/databricks/cli/libs/dyn/dynassert"
-	"github.com/stretchr/testify/require"
 )
 
 func TestVisitDashboardPaths(t *testing.T) {
@@ -21,22 +20,10 @@ func TestVisitDashboardPaths(t *testing.T) {
 		},
 	}
 
-	actual := visitDashboardPaths(t, root)
+	actual := collectVisitedPaths(t, root, VisitDashboardPaths)
 	expected := []dyn.Path{
 		dyn.MustPathFromString("resources.dashboards.dashboard0.file_path"),
 	}
 
 	assert.ElementsMatch(t, expected, actual)
 }
-
-func visitDashboardPaths(t *testing.T, root config.Root) []dyn.Path {
-	var actual []dyn.Path
-	err := root.Mutate(func(value dyn.Value) (dyn.Value, error) {
-		return VisitDashboardPaths(value, func(p dyn.Path, mode TranslateMode, v dyn.Value) (dyn.Value, error) {
-			actual = append(actual, p)
-			return v, nil
-		})
-	})
-	require.NoError(t, err)
-	return actual
-}

bundle/config/mutator/paths/job_paths_visitor_test.go

@@ -9,7 +9,6 @@ import (
 	assert "github.com/databricks/cli/libs/dyn/dynassert"
 	"github.com/databricks/databricks-sdk-go/service/compute"
 	"github.com/databricks/databricks-sdk-go/service/jobs"
-	"github.com/stretchr/testify/require"
 )
 
 func TestVisitJobPaths(t *testing.T) {
@@ -73,7 +72,7 @@ func TestVisitJobPaths(t *testing.T) {
 		},
 	}
 
-	actual := visitJobPaths(t, root)
+	actual := collectVisitedPaths(t, root, VisitJobPaths)
 	expected := []dyn.Path{
 		dyn.MustPathFromString("resources.jobs.job0.tasks[0].notebook_task.notebook_path"),
 		dyn.MustPathFromString("resources.jobs.job0.tasks[1].spark_python_task.python_file"),
@@ -112,7 +111,7 @@ func TestVisitJobPaths_environments(t *testing.T) {
 		},
 	}
 
-	actual := visitJobPaths(t, root)
+	actual := collectVisitedPaths(t, root, VisitJobPaths)
 	expected := []dyn.Path{
 		dyn.MustPathFromString("resources.jobs.job0.environments[0].spec.dependencies[0]"),
 		dyn.MustPathFromString("resources.jobs.job0.environments[0].spec.dependencies[1]"),
@@ -147,22 +146,10 @@ func TestVisitJobPaths_foreach(t *testing.T) {
 		},
 	}
 
-	actual := visitJobPaths(t, root)
+	actual := collectVisitedPaths(t, root, VisitJobPaths)
 	expected := []dyn.Path{
 		dyn.MustPathFromString("resources.jobs.job0.tasks[0].for_each_task.task.notebook_task.notebook_path"),
 	}
 
 	assert.ElementsMatch(t, expected, actual)
 }
-
-func visitJobPaths(t *testing.T, root config.Root) []dyn.Path {
-	var actual []dyn.Path
-	err := root.Mutate(func(value dyn.Value) (dyn.Value, error) {
-		return VisitJobPaths(value, func(p dyn.Path, mode TranslateMode, v dyn.Value) (dyn.Value, error) {
-			actual = append(actual, p)
-			return v, nil
-		})
-	})
-	require.NoError(t, err)
-	return actual
-}

bundle/config/mutator/paths/pipeline_paths_visitor_test.go

@@ -8,7 +8,6 @@ import (
 	"github.com/databricks/cli/libs/dyn"
 	assert "github.com/databricks/cli/libs/dyn/dynassert"
 	"github.com/databricks/databricks-sdk-go/service/pipelines"
-	"github.com/stretchr/testify/require"
 )
 
 func TestVisitPipelinePaths(t *testing.T) {
@@ -35,23 +34,11 @@ func TestVisitPipelinePaths(t *testing.T) {
 		},
 	}
 
-	actual := visitPipelinePaths(t, root)
+	actual := collectVisitedPaths(t, root, VisitPipelinePaths)
 	expected := []dyn.Path{
 		dyn.MustPathFromString("resources.pipelines.pipeline0.libraries[0].file.path"),
 		dyn.MustPathFromString("resources.pipelines.pipeline0.libraries[1].notebook.path"),
 	}
 
 	assert.ElementsMatch(t, expected, actual)
 }
-
-func visitPipelinePaths(t *testing.T, root config.Root) []dyn.Path {
-	var actual []dyn.Path
-	err := root.Mutate(func(value dyn.Value) (dyn.Value, error) {
-		return VisitPipelinePaths(value, func(p dyn.Path, mode TranslateMode, v dyn.Value) (dyn.Value, error) {
-			actual = append(actual, p)
-			return v, nil
-		})
-	})
-	require.NoError(t, err)
-	return actual
-}

bundle/config/mutator/paths/visitor_test.go

@@ -0,0 +1,22 @@
+package paths
+
+import (
+	"testing"
+
+	"github.com/databricks/cli/bundle/config"
+	"github.com/databricks/cli/libs/dyn"
+	"github.com/stretchr/testify/require"
+)
+
+// collectVisitedPaths is a helper function that collects all visited paths for testing
+func collectVisitedPaths(t *testing.T, root config.Root, visitFn func(value dyn.Value, fn VisitFunc) (dyn.Value, error)) []dyn.Path {
+	var actual []dyn.Path
+	err := root.Mutate(func(value dyn.Value) (dyn.Value, error) {
+		return visitFn(value, func(p dyn.Path, mode TranslateMode, v dyn.Value) (dyn.Value, error) {
+			actual = append(actual, p)
+			return v, nil
+		})
+	})
+	require.NoError(t, err)
+	return actual
+}