Skip to content

Commit 43f3fc2

Browse files
authored
acc: Make sure correct Cloud setting in out.test.toml (#3434)
## Why When running "make test-update" locally, Cloud in out.test.toml is set to false for CloudSlow tests. This is not correct, as CloudSlow implies Cloud.
1 parent aadc695 commit 43f3fc2

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

acceptance/acceptance_test.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,11 @@ func getTests(t *testing.T) []string {
380380

381381
// Return a reason to skip the test. Empty string means "don't skip".
382382
func getSkipReason(config *internal.TestConfig, configPath string) string {
383+
// Apply default first, so that it's visible in out.test.toml
384+
if isTruePtr(config.CloudSlow) {
385+
config.Cloud = config.CloudSlow
386+
}
387+
383388
if SkipLocal && isTruePtr(config.Local) {
384389
return "Disabled via SkipLocal setting in " + configPath
385390
}
@@ -404,7 +409,6 @@ func getSkipReason(config *internal.TestConfig, configPath string) string {
404409
}
405410

406411
if isTruePtr(config.CloudSlow) {
407-
config.Cloud = config.CloudSlow
408412
if testing.Short() {
409413
return fmt.Sprintf("Disabled via CloudSlow setting in %s (CLOUD_ENV=%s, Short=%v)", configPath, cloudEnv, testing.Short())
410414
}

0 commit comments

Comments
 (0)