Skip to content

Commit 8069dc6

Browse files
authored
pipelines: added periods and edited template (#3268)
## Changes Added periods to Pipelines CLI auto-approve flag and Databricks install-pipelines-cli, making periods consistent. Removed channel PREVIEW from template Renamed databricks auth login to pipelines auth login in cli-pipelines template. ## Why Improves readability and template. ## Tests Acceptance tests updated
1 parent 2714127 commit 8069dc6

File tree

10 files changed

+6
-10
lines changed

10 files changed

+6
-10
lines changed

acceptance/pipelines/init/error-cases/output/my_project/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ The 'my_project' project was generated by using the CLI Pipelines template.
1313

1414
3. Authenticate to your Databricks workspace, if you have not done so already:
1515
```
16-
$ databricks auth login
16+
$ pipelines auth login
1717
```
1818
1919
4. Optionally, install developer tools such as the Databricks extension for Visual Studio Code from

acceptance/pipelines/init/error-cases/output/my_project/my_project_pipeline/my_project.pipeline.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ resources:
33
my_project_pipeline:
44
name: my_project_pipeline
55
serverless: true
6-
channel: "PREVIEW"
76
catalog: ${var.catalog}
87
schema: ${var.schema}
98
root_path: "."

acceptance/pipelines/init/python/output/my_python_project/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ The 'my_python_project' project was generated by using the CLI Pipelines templat
1313

1414
3. Authenticate to your Databricks workspace, if you have not done so already:
1515
```
16-
$ databricks auth login
16+
$ pipelines auth login
1717
```
1818
1919
4. Optionally, install developer tools such as the Databricks extension for Visual Studio Code from

acceptance/pipelines/init/python/output/my_python_project/my_python_project_pipeline/my_python_project.pipeline.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ resources:
33
my_python_project_pipeline:
44
name: my_python_project_pipeline
55
serverless: true
6-
channel: "PREVIEW"
76
catalog: ${var.catalog}
87
schema: ${var.schema}
98
root_path: "."

acceptance/pipelines/init/sql/output/my_sql_project/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ The 'my_sql_project' project was generated by using the CLI Pipelines template.
1313

1414
3. Authenticate to your Databricks workspace, if you have not done so already:
1515
```
16-
$ databricks auth login
16+
$ pipelines auth login
1717
```
1818
1919
4. Optionally, install developer tools such as the Databricks extension for Visual Studio Code from

acceptance/pipelines/init/sql/output/my_sql_project/my_sql_project_pipeline/my_sql_project.pipeline.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ resources:
33
my_sql_project_pipeline:
44
name: my_sql_project_pipeline
55
serverless: true
6-
channel: "PREVIEW"
76
catalog: ${var.catalog}
87
schema: ${var.schema}
98
root_path: "."

cmd/pipelines/destroy.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ func destroyCommand() *cobra.Command {
2929

3030
var autoApprove bool
3131
var forceDestroy bool
32-
cmd.Flags().BoolVar(&autoApprove, "auto-approve", false, "Skip interactive approvals for deleting pipelines")
32+
cmd.Flags().BoolVar(&autoApprove, "auto-approve", false, "Skip interactive approvals for deleting pipelines.")
3333
cmd.Flags().BoolVar(&forceDestroy, "force-lock", false, "Force acquisition of deployment lock.")
3434

3535
cmd.RunE = func(cmd *cobra.Command, args []string) error {

cmd/pipelines/install_pipelines_cli.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,6 @@ func InstallPipelinesCLI() *cobra.Command {
6161
return installPipelinesSymlink(cmd.Context(), directory)
6262
},
6363
}
64-
cmd.Flags().StringVarP(&directory, "directory", "d", "", "Directory in which to install pipelines CLI (defaults to databricks CLI's directory)")
64+
cmd.Flags().StringVarP(&directory, "directory", "d", "", "Directory in which to install Pipelines CLI (defaults to Databricks CLI's directory).")
6565
return cmd
6666
}

libs/template/templates/cli-pipelines/template/{{.project_name}}/README.md.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ The '{{.project_name}}' project was generated by using the CLI Pipelines templat
1313

1414
3. Authenticate to your Databricks workspace, if you have not done so already:
1515
```
16-
$ databricks auth login
16+
$ pipelines auth login
1717
```
1818

1919
4. Optionally, install developer tools such as the Databricks extension for Visual Studio Code from

libs/template/templates/cli-pipelines/template/{{.project_name}}/{{.project_name}}_pipeline/{{.project_name}}.pipeline.yml.tmpl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ resources:
33
{{template `pipeline_name` .}}:
44
name: {{template `pipeline_name` .}}
55
serverless: true
6-
channel: "PREVIEW"
76
catalog: ${var.catalog}
87
schema: ${var.schema}
98
root_path: "."

0 commit comments

Comments
 (0)