Skip to content

Commit cee8c18

Browse files
Disable unit test in daemon package (#2538)
This unit test is inherently flaky and will fail if the gap between process scheduling exceeds 10 seconds. I am hypothesizing that is what happened in the failure here (or some equivalent issue, the exact cause does not matter): https://github.com/databricks/cli/actions/runs/13957485937/job/39072078260 Since we do not use the daemon package anywhere, let's disable this unit test for now.
1 parent f52d8bd commit cee8c18

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

libs/daemon/daemon_test.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,16 @@ import (
1515
"github.com/stretchr/testify/require"
1616
)
1717

18-
func TestDaemon(t *testing.T) {
18+
// This test is inherently flaky because it relies on a timeout to wait for
19+
// the server process to start. While it's expected to be rare, we have evidence of
20+
// this triggering in CI (where this failure is more likely due to machine virtualization)
21+
// ref: https://github.com/databricks/cli/pull/2526#issuecomment-2739524677
22+
//
23+
// We can trigger this test back on once we actually start using the daemon package.
24+
// That may never happen in which case we can remove this entire package at some point
25+
// in the future.
26+
// Date this test was disabled: 20th March 2025.
27+
func DisabledTestDaemon(t *testing.T) {
1928
tmpDir := t.TempDir()
2029
cmd := exec.Command("go", "run", "internal/parent_process/main.go", tmpDir)
2130

0 commit comments

Comments
 (0)