Skip to content

Commit d86b288

Browse files
Do not download ARM binaries in testarchive (#3501)
## Why We do not need ARM binaries right now, so skip downloads for them. Builds on top of: #3500 ## Tests Modified unit tests.
1 parent bb79f95 commit d86b288

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

internal/testarchive/archive.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,14 @@ func createArchive(archiveDir, binDir, repoRoot string) error {
107107
// the CPU architecture to keep the door open for future optimizations.
108108
downloaders := []downloader{
109109
goDownloader{arch: "amd64", binDir: binDir},
110-
goDownloader{arch: "arm64", binDir: binDir},
111110
uvDownloader{arch: "amd64", binDir: binDir},
112-
uvDownloader{arch: "arm64", binDir: binDir},
113111
jqDownloader{arch: "amd64", binDir: binDir},
114-
jqDownloader{arch: "arm64", binDir: binDir},
112+
113+
// TODO: Serverless clusters do not support arm64 yet.
114+
// Enable ARM64 once serverless clusters support it.
115+
// goDownloader{arch: "arm64", binDir: binDir},
116+
// uvDownloader{arch: "arm64", binDir: binDir},
117+
// jqDownloader{arch: "arm64", binDir: binDir},
115118
}
116119

117120
for _, downloader := range downloaders {

internal/testarchive/archive_test.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,16 @@ func TestArchive(t *testing.T) {
2828

2929
// Go installation is a directory because it includes the
3030
// standard library source code along with the Go binary.
31-
assert.FileExists(t, filepath.Join(assertDir, "bin", "arm64", "go", "bin", "go"))
3231
assert.FileExists(t, filepath.Join(assertDir, "bin", "amd64", "go", "bin", "go"))
33-
assert.FileExists(t, filepath.Join(assertDir, "bin", "arm64", "uv"))
3432
assert.FileExists(t, filepath.Join(assertDir, "bin", "amd64", "uv"))
35-
assert.FileExists(t, filepath.Join(assertDir, "bin", "arm64", "jq"))
3633
assert.FileExists(t, filepath.Join(assertDir, "bin", "amd64", "jq"))
3734

35+
// TODO: Serverless clusters do not support arm64 yet.
36+
// Assert these files exist after we support arm64.
37+
assert.NoFileExists(t, filepath.Join(assertDir, "bin", "arm64", "go", "bin", "go"))
38+
assert.NoFileExists(t, filepath.Join(assertDir, "bin", "arm64", "uv"))
39+
assert.NoFileExists(t, filepath.Join(assertDir, "bin", "arm64", "jq"))
40+
3841
assert.FileExists(t, filepath.Join(assertDir, "cli", "go.mod"))
3942
assert.FileExists(t, filepath.Join(assertDir, "cli", "go.sum"))
4043
}

0 commit comments

Comments
 (0)