Render full diagnostics in bundle run (#2844)

## Why
`diags.Error()` only returns the`Details` in the diagnostic, and only
returns `Summary` if the details are empty. We should render both In
`bundle run` to be consistent with `bundle deploy`.

At the same time, this PR also renders all `warnings` and
`recommendations` if the user encounters an error. These warnings could
have helpful context on what they need to fix in their configuration.

## Tests
New acceptance test. Existing tests pass.

Author: shreyas-goenka

acceptance/bundle/run/diagnostics/databricks.yml

@@ -0,0 +1,5 @@
+bundle:
+  name: run diagnostics
+
+workspace:
+  file_path: /Volumes/test

acceptance/bundle/run/diagnostics/output.txt

@@ -0,0 +1,10 @@
+
+>>> [CLI] bundle run foo
+Error: workspace.file_path /Volumes/test starts with /Volumes. /Volumes can only be used with workspace.artifact_path.
+  at workspace.file_path
+  in databricks.yml:5:14
+
+For more information, see https://docs.databricks.com/aws/en/dev-tools/bundles/settings#workspace
+
+
+Exit code: 1

acceptance/bundle/run/diagnostics/script

@@ -0,0 +1 @@
+trace $CLI bundle run foo

acceptance/bundle/run/inline-script/no-bundle/output.txt

@@ -2,4 +2,5 @@
 >>> [CLI] bundle run -- echo hello
 Error: unable to locate bundle root: databricks.yml not found
 
+
 Exit code: 1

acceptance/bundle/run/inline-script/no-separator/output.txt

@@ -2,4 +2,5 @@
 >>> [CLI] bundle run echo hello
 Error: unable to locate bundle root: databricks.yml not found
 
+
 Exit code: 1

cmd/bundle/deploy.go

@@ -3,6 +3,7 @@ package bundle
 import (
 	"context"
 	"fmt"
+	"io"
 
 	"github.com/databricks/cli/bundle"
 	"github.com/databricks/cli/bundle/config/validate"
@@ -84,18 +85,21 @@ func newDeployCommand() *cobra.Command {
 			}
 		}
 
-		renderOpts := render.RenderOptions{RenderSummaryTable: false}
-		err := render.RenderDiagnostics(cmd.OutOrStdout(), b, diags, renderOpts)
-		if err != nil {
-			return fmt.Errorf("failed to render output: %w", err)
-		}
+		return renderDiagnostics(cmd.OutOrStdout(), b, diags)
+	}
+	return cmd
+}
 
-		if diags.HasError() {
-			return root.ErrAlreadyPrinted
-		}
+func renderDiagnostics(w io.Writer, b *bundle.Bundle, diags diag.Diagnostics) error {
+	renderOpts := render.RenderOptions{RenderSummaryTable: false}
+	err := render.RenderDiagnostics(w, b, diags, renderOpts)
+	if err != nil {
+		return fmt.Errorf("failed to render output: %w", err)
+	}
 
-		return nil
+	if diags.HasError() {
+		return root.ErrAlreadyPrinted
 	}
 
-	return cmd
+	return nil
 }

cmd/bundle/run.go

@@ -127,8 +127,8 @@ Example usage:
 	cmd.RunE = func(cmd *cobra.Command, args []string) error {
 		ctx := cmd.Context()
 		b, diags := utils.ConfigureBundleWithVariables(cmd)
-		if err := diags.Error(); err != nil {
-			return diags.Error()
+		if diags.HasError() {
+			return renderDiagnostics(cmd.OutOrStdout(), b, diags)
 		}
 
 		// If user runs the bundle run command as:
@@ -138,24 +138,24 @@ Example usage:
 			return executeInline(cmd, args, b)
 		}
 
-		diags = phases.Initialize(ctx, b)
-		if err := diags.Error(); err != nil {
-			return err
+		diags = diags.Extend(phases.Initialize(ctx, b))
+		if diags.HasError() {
+			return renderDiagnostics(cmd.OutOrStdout(), b, diags)
 		}
 
 		key, args, err := resolveRunArgument(ctx, b, args)
 		if err != nil {
 			return err
 		}
 
-		diags = bundle.ApplySeq(ctx, b,
+		diags = diags.Extend(bundle.ApplySeq(ctx, b,
 			terraform.Interpolate(),
 			terraform.Write(),
 			terraform.StatePull(),
 			terraform.Load(terraform.ErrorOnEmptyState),
-		)
-		if err := diags.Error(); err != nil {
-			return err
+		))
+		if diags.HasError() {
+			return renderDiagnostics(cmd.OutOrStdout(), b, diags)
 		}
 
 		runner, err := keyToRunner(b, key)