make Manifest mandatory

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>

Author: varun-edachali-dbx

src/databricks/sql/result_set.py

@@ -456,7 +456,7 @@ def __init__(
         execute_response: ExecuteResponse,
         sea_client: SeaDatabricksClient,
         result_data: ResultData,
-        manifest: Optional[ResultManifest] = None,
+        manifest: ResultManifest,
         buffer_size_bytes: int = 104857600,
         arraysize: int = 10000,
     ):

tests/unit/test_sea_result_set.py

@@ -6,11 +6,11 @@
 """
 
 import pytest
-from unittest.mock import patch, MagicMock, Mock
+from unittest.mock import Mock
 
 from databricks.sql.result_set import SeaResultSet, Row
 from databricks.sql.utils import JsonQueue
-from databricks.sql.backend.types import CommandId, CommandState, BackendType
+from databricks.sql.backend.types import CommandId, CommandState
 from databricks.sql.backend.sea.models.base import ResultData, ResultManifest
 
 
@@ -88,6 +88,18 @@ def json_queue(self, sample_data):
         """Create a JsonQueue with sample data."""
         return JsonQueue(sample_data)
 
+    def empty_manifest(self):
+        """Create an empty manifest."""
+        return ResultManifest(
+            format="JSON_ARRAY",
+            schema={},
+            total_row_count=0,
+            total_byte_count=0,
+            total_chunk_count=0,
+            truncated=False,
+            is_volume_operation=False,
+        )
+
     def test_init_with_execute_response(
         self, mock_connection, mock_sea_client, execute_response
     ):
@@ -97,6 +109,7 @@ def test_init_with_execute_response(
             execute_response=execute_response,
             sea_client=mock_sea_client,
             result_data=ResultData(data=[]),
+            manifest=self.empty_manifest(),
             buffer_size_bytes=1000,
             arraysize=100,
         )
@@ -117,6 +130,7 @@ def test_close(self, mock_connection, mock_sea_client, execute_response):
             execute_response=execute_response,
             sea_client=mock_sea_client,
             result_data=ResultData(data=[]),
+            manifest=self.empty_manifest(),
             buffer_size_bytes=1000,
             arraysize=100,
         )
@@ -138,6 +152,7 @@ def test_close_when_already_closed_server_side(
             execute_response=execute_response,
             sea_client=mock_sea_client,
             result_data=ResultData(data=[]),
+            manifest=self.empty_manifest(),
             buffer_size_bytes=1000,
             arraysize=100,
         )
@@ -161,6 +176,7 @@ def test_close_when_connection_closed(
             execute_response=execute_response,
             sea_client=mock_sea_client,
             result_data=ResultData(data=[]),
+            manifest=self.empty_manifest(),
             buffer_size_bytes=1000,
             arraysize=100,
         )
@@ -317,6 +333,7 @@ def test_fetchmany_arrow_not_implemented(
                 execute_response=execute_response,
                 sea_client=mock_sea_client,
                 result_data=ResultData(data=None, external_links=[]),
+                manifest=self.empty_manifest(),
                 buffer_size_bytes=1000,
                 arraysize=100,
             )
@@ -336,6 +353,7 @@ def test_fetchall_arrow_not_implemented(
                 execute_response=execute_response,
                 sea_client=mock_sea_client,
                 result_data=ResultData(data=None, external_links=[]),
+                manifest=self.empty_manifest(),
                 buffer_size_bytes=1000,
                 arraysize=100,
             )
@@ -353,6 +371,7 @@ def test_is_staging_operation(
             execute_response=execute_response,
             sea_client=mock_sea_client,
             result_data=ResultData(data=[]),
+            manifest=self.empty_manifest(),
             buffer_size_bytes=1000,
             arraysize=100,
         )